================
@@ -100,12 +100,13 @@ template <bool Signed> class IntegralAP final {
}
static IntegralAP from(const Boolean &B) {
assert(false);
- return IntegralAP::zero();
+ return IntegralAP::zero(1);
----------------
AaronBallman wrote:
Ah, please add FIXME comments to unimplemented stuff when you can.
(I'll be honest -- reviewing new interpreter patches is getting really
difficult because of the interdependence between so many unrelated reviews and
how much stuff is half-done. That's why these reviews keep getting delayed on
my end, there's just too much to try to keep track of spread out across too
many reviews. I wish we could find a way to improve this without impeding your
ability to make progress. CC @Shafik @erichkeane @cor3ntin as other folks doing
a fair number of these reviews in case this is a shared concern and folks have
ideas on how to improve it.)
https://github.com/llvm/llvm-project/pull/68081
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
