[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553991. saiislam marked 3 inline comments as done. saiislam added a comment. Minor fixes addressing reviewer's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D13973

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

PiotrZSL added a comment. In D156616#4621975 , @mikecrowe wrote: > The removal of `c_str()` happens even without StrictMode set to True. I still think we will be fine. There are not many situations when arguments need to be reorder. And most probably no

[PATCH] D126586: [InstrProf] Single byte counters in coverage

gulfem updated this revision to Diff 553992. gulfem added a comment. Fixed the issue that causes a crash in InstCombinePHI.cpp. Phi instructions need to be inserted at the beginning of basic blocks, and profile increments need to inserted after phis for conditional operators. Repository: rG LL

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana added a comment. In D158709#4621199 , @aaron.ballman wrote: > At a high-level (not just for this patch, but for the entire series): is this > need specific to your downstream or is this a more general need? e.g., should > this complexity be kept d

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553995. ldionne added a comment. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-buildbot

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158709#4622006 , @iana wrote: > In D158709#4621199 , @aaron.ballman > wrote: > >> At a hig

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. I think this looks good to me. I remember I also had to make this change to accept old datalayout strings https://reviews.llvm.org/D67631. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 554002. capfredf added a comment. fix memory issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang-tools-extra/clangd/CodeComplete.cpp clang/includ

[PATCH] D126586: [InstrProf] Single byte counters in coverage

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4812 +} else + CGF.incrementProfileCounter(E); + } This can be hoist outside `if (llvm::EnableSingleByteCoverage)` Comment at: clang/lib/CodeGe

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added a comment. Are these matchers going to be used in-tree (by clang-tidy, or something else)? We typically do not add new AST matches until there's a need for them because the AST matchers have a pretty big impact on build times of Clang itself. Comment at: c

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a small nit Comment at: clang/lib/Sema/SemaDecl.cpp:13453-13466 +if (!VDeclType->isDependentType() && +Context.getAsIncompleteArrayType(VDeclType)) { + if (Init && !Init->getType().i

[PATCH] D158923: [clang-c] Visit ranged for initializer

aaron.ballman added a comment. In D158923#4619375 , @kiloalphaindia wrote: > Can we get this into release/17.x still? Alas, but no -- 17.x changes are being limited to just fixes for critical issues/regressions at this point. (Once we start issuing rel

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

DiggerLin added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:566 static bool checkAliasedGlobal( -DiagnosticsEngine &Diags, SourceLocation Location, bool IsIFunc, -const llvm::GlobalValue *Alias, const llvm::GlobalValue *&GV, +ASTContext &Context,

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

MaskRay created this revision. MaskRay added reviewers: mgorny, thesamesam. Herald added subscribers: pengfei, kristof.beyls. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang.

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:121 const ArgList &Args, - std::vector &Features) { + std::vector &Features, bool ForAS) { + if (ForAS)

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. I think it's fine now given that it's passing tests. Others feel free to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ h

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. > Additionally user could always take "main" version, and use it just to apply > fixes from this check. OK. Can this land on main then? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ https://reviews.

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554015. ldionne added a comment. Set VC variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-

[clang] 9c760ca - [Clang][CodeGen] `typeid` needs special care when `type_info` is not in the default AS

Author: Alex Voicu Date: 2023-08-28T20:44:06+01:00 New Revision: 9c760ca8ecfd570212b47a5e980d38575b879029 URL: https://github.com/llvm/llvm-project/commit/9c760ca8ecfd570212b47a5e980d38575b879029 DIFF: https://github.com/llvm/llvm-project/commit/9c760ca8ecfd570212b47a5e980d38575b879029.diff LO

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c760ca8ecfd: [Clang][CodeGen] `typeid` needs special care when `type_info` is not in the… (authored by AlexVlx). Repository: rG LLVM Github Monor

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554016. ldionne marked an inline comment as done. ldionne added a comment. Herald added a reviewer: bollu. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, Enna1, yota9, ayermolo, jvesely. Herald ad

[clang-tools-extra] c6207f6 - [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

Author: Mike Crowe Date: 2023-08-28T19:44:23Z New Revision: c6207f6e0d04f129b4ec2ada644c0224038f4705 URL: https://github.com/llvm/llvm-project/commit/c6207f6e0d04f129b4ec2ada644c0224038f4705 DIFF: https://github.com/llvm/llvm-project/commit/c6207f6e0d04f129b4ec2ada644c0224038f4705.diff LOG: [c

[clang-tools-extra] 6e2d94a - [clang-tidy][NFC] Relase notes for modernize-use-std-print

Author: Piotr Zegar Date: 2023-08-28T19:44:24Z New Revision: 6e2d94a40d17832a04de7bb5294388fbf7f95991 URL: https://github.com/llvm/llvm-project/commit/6e2d94a40d17832a04de7bb5294388fbf7f95991 DIFF: https://github.com/llvm/llvm-project/commit/6e2d94a40d17832a04de7bb5294388fbf7f95991.diff LOG: [

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6207f6e0d04: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:287 + static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''ゆ' (0

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne added a comment. Herald added a subscriber: JDevlieghere. Sorry for spamming everyone, I'm trying to ensure that the CI will work with all the sub-projects in the monorepo once we move to GH PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554021. AntonRydahl added a comment. Moved emission of warnings from CodeGen to Sema to allow using `-verify -analyze`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D1

[clang-tools-extra] f0e2a5e - [clang-tidy][readability] add Leading_upper_snake_case

Author: MasterCopy8GB Date: 2023-08-28T19:53:09Z New Revision: f0e2a5e260c24597f11b122d20051f057d96b544 URL: https://github.com/llvm/llvm-project/commit/f0e2a5e260c24597f11b122d20051f057d96b544 DIFF: https://github.com/llvm/llvm-project/commit/f0e2a5e260c24597f11b122d20051f057d96b544.diff LOG:

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e2a5e260c2: [clang-tidy][readability] add Leading_upper_snake_case (authored by MasterCopy8GB, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158787?vs=553593&id=554022#toc

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. It's more convenient if you upload new patches into original review and reland that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 __

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Could this be related https://lab.llvm.org/buildbot/#/builders/127/builds/54239 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { Does this need to be in Ba

[clang-tools-extra] 5ab25a4 - Reland "[clang-repl] support code completion at a REPL."

Author: Fred Fu Date: 2023-08-28T19:59:56Z New Revision: 5ab25a42ba70c4b50214b0e78eaaccd30696fa09 URL: https://github.com/llvm/llvm-project/commit/5ab25a42ba70c4b50214b0e78eaaccd30696fa09 DIFF: https://github.com/llvm/llvm-project/commit/5ab25a42ba70c4b50214b0e78eaaccd30696fa09.diff LOG: Relan

[PATCH] D154382: [ClangRepl] support code completion at a REPL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab25a42ba70: Reland "[clang-repl] support code completion at a REPL." (authored by capfredf, committed by v.g.vassilev). Changed prior to commit:

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 updated this revision to Diff 554025. jyu2 added a comment. Thanks @rnk. This is address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158538/new/ https://reviews.llvm.org/D158538 Files: clang/lib/AST/ASTContext.cpp clang/li

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Hi @rnk, Thank you so much for the suggestion. >> Before we do that, you should be able to delete the logic in >> CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. >> Your change should have the same effect. Can you do that, and check that it >>

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-ex

[clang] cd591e0 - Revert "Reland "[Profile] Allow online merging with debug info correlation.""

Author: Vitaly Buka Date: 2023-08-28T13:01:25-07:00 New Revision: cd591e02d4563d4b90792ed5f441e1cf5b30443e URL: https://github.com/llvm/llvm-project/commit/cd591e02d4563d4b90792ed5f441e1cf5b30443e DIFF: https://github.com/llvm/llvm-project/commit/cd591e02d4563d4b90792ed5f441e1cf5b30443e.diff L

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

PiotrZSL updated this revision to Diff 554028. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Fix some Pylint issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929 Files: clang-t

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, see below. Comment at: clang/lib/Sema/SemaExprCXX.cpp:869 bool IsThrownVarInScope) { - // Don't report an error if 'throw' is used

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Reverted. Please continue on original review: `arc diff HEAD^ --revision D157632` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

vitalybuka added a comment. Reverted cd591e02d4563d4b90792ed5f441e1cf5b30443e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 ___

[clang-tools-extra] 752f87c - Revert "Reland "[clang-repl] support code completion at a REPL.""

Author: Vassil Vassilev Date: 2023-08-28T20:05:14Z New Revision: 752f87cd6a1a354790f4728848827077467ac15d URL: https://github.com/llvm/llvm-project/commit/752f87cd6a1a354790f4728848827077467ac15d DIFF: https://github.com/llvm/llvm-project/commit/752f87cd6a1a354790f4728848827077467ac15d.diff LO

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with some tweaks to the test. Comment at: clang/test/CodeGenCXX/ms-inheriting-ctor.cpp:41 + +// CHECK-LABEL: define internal noundef ptr @"??0?$B@_N@@QEAA@AEBVF@@AEBUA@@@Z"(p

[clang] 79af92b - Reland "[clang-repl] support code completion at a REPL."

Author: Fred Fu Date: 2023-08-28T20:09:03Z New Revision: 79af92bb99dd86cc36d6a81066063fb9cd77c78a URL: https://github.com/llvm/llvm-project/commit/79af92bb99dd86cc36d6a81066063fb9cd77c78a DIFF: https://github.com/llvm/llvm-project/commit/79af92bb99dd86cc36d6a81066063fb9cd77c78a.diff LOG: Relan

[clang] dd850f0 - [llvm][clang][modules] Fix test failure on big-endian bots

Author: Jan Svoboda Date: 2023-08-28T13:18:40-07:00 New Revision: dd850f0bae8f38b721e9ae6b8ba915dbf7d9bac7 URL: https://github.com/llvm/llvm-project/commit/dd850f0bae8f38b721e9ae6b8ba915dbf7d9bac7 DIFF: https://github.com/llvm/llvm-project/commit/dd850f0bae8f38b721e9ae6b8ba915dbf7d9bac7.diff L

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

MaskRay added a comment. Tested by parona on Libera Chat IRC. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159010/new/ https://reviews.llvm.org/D159010 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554034. AntonRydahl marked 2 inline comments as done. AntonRydahl added a comment. Replaced instances of `const llvm::Triple T` with `const llvm::Triple &T`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:869 bool IsThrownVarInScope) { - // Don't report an error if 'throw' is used in system headers. - if (!getLangOpts().CXXEx

[clang] f52f8e8 - [Profile] Allow online merging with debug info correlation.

Author: Zequan Wu Date: 2023-08-28T16:35:41-04:00 New Revision: f52f8e817ea36e003e8f09672de48c3c460093f4 URL: https://github.com/llvm/llvm-project/commit/f52f8e817ea36e003e8f09672de48c3c460093f4 DIFF: https://github.com/llvm/llvm-project/commit/f52f8e817ea36e003e8f09672de48c3c460093f4.diff LOG

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf52f8e817ea3: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D157632?vs=550051&id=554035#toc Repository: rG LLVM

[clang] 081afa3 - [Driver,X86] Ignore -mfpmath= for assembler input

Author: Fangrui Song Date: 2023-08-28T13:37:33-07:00 New Revision: 081afa3d04a4bc0d43c62b5b0e5a84f86a8a70ec URL: https://github.com/llvm/llvm-project/commit/081afa3d04a4bc0d43c62b5b0e5a84f86a8a70ec DIFF: https://github.com/llvm/llvm-project/commit/081afa3d04a4bc0d43c62b5b0e5a84f86a8a70ec.diff

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

This revision was automatically updated to reflect the committed changes. Closed by commit rG081afa3d04a4: [Driver,X86] Ignore -mfpmath= for assembler input (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D159010?vs=554010&id=554037#toc Repository: rG LLVM Github Mon

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir updated this revision to Diff 554040. burakemir marked 2 inline comments as done. burakemir added a comment. Addressing reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158407/new/ https://reviews.llvm.org/D158407 Files:

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir added a comment. Thanks for the review. PTAL. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:426 + // considered for the simplification of earlier clauses. Do a final + // pass to find more opportunities for simplification. + CNFFormula Fina

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added subscribers: vadikp-intel, natgla. mstorsjo added a comment. In D152054#4620927 , @mstorsjo wrote: > This new test is failing on Windows, due to `__kmpc_set_thread_limit` not > being exported - see e.g. > https://github.com/mstorsjo/llvm-

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 554044. bogner added a comment. - Now with more const - Added DiagnoseHLSLAttrStageMismatch and avoided using raw strings in diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

rnk added a subscriber: dblaikie. rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +t

[PATCH] D159016: [clang] Fix assertion failure using -MJ with -fsyntax-only

benlangmuir created this revision. benlangmuir added a reviewer: MaskRay. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is no output filename we should not assert when writing output for -

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 554048. zequanwu added a comment. __llvm_prf_names section in the binary could be non-zero because non-instrumented function names are store there to indicate execution of 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 554049. AntonRydahl added a comment. Rebased on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files: clang/docs/OpenMPSupport.rst clang/include/clang/

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks Comment at: clang/test/CodeGenCUDA/amdgpu-code-object-version-linking.cu:12 +// RUN: llvm-link %t_0 %t_5 -o -| llvm-dis -o - | FileCheck -check-prefix=LINKED5 %s + +#include "Inputs/cuda.h" sa

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3135 + if (!Tok) +break; +} When simplifying the function, I forgot that we are in the inner loop here and thus `break` won't exit the outer loop. Repository: rG

[PATCH] D159018: [clang][modules] Add a c23 module feature

iana created this revision. iana added reviewers: ChuanqiXu, Bigcheese, v.g.vassilev, aaron.ballman. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a c23 module fea

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan updated this revision to Diff 554051. owenpan added a comment. Fixed the crash and added a test case in `TokenAnnotatorTest.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/ https://reviews.llvm.org/D157963 Files: clang/lib/Format/TokenAnnotator.cpp clang/unit

[PATCH] D159018: [clang][modules] Add a c23 module feature

iana added a comment. Would we want to back port this to llvm 17? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/ https://reviews.llvm.org/D159018 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D158933: [clang] Implement -funsigned-bitfields

shafik added reviewers: aaron.ballman, clang-language-wg. shafik added a comment. Adding more reviewers for visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158933/new/ https://reviews.llvm.org/D158933 ___ cfe-commits mailing list cf

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

rnk added a subscriber: efriedma. rnk added a comment. +@efriedma, since I think we had that ongoing thread about what to do with i128 alignment in data layout. Is this a reasonable way to handle the datalayout migration? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158857/new/ https

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

vadikp-intel added a comment. Windows importing is now done by name, and new exports do not need to have an ordinal specified for them i.e. you can add a line with just the API name to dllexports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1520

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. Thank you kindly, this is looking very good on our recent changes in my manual usage. (It will take some more work before I can run it in our GitHub Action, which I’m looking forward to.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

rnk added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10110-10111 +// propagated to the new node prior to instantiation. +if (PrevDecl && PrevDecl->hasAttr()) { + Specialization->addAttr(PrevDecl->getAttr()); + Consumer.AssignInheritanceModel(Sp

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

eandrews updated this revision to Diff 554063. eandrews added a comment. Changed a dyn_cast to cast and handled ObjCAtFinallyStmt similar to how ObjCAtTryStmt is handled, i.e. just check that it exists before calling PrintRawCompoundStmt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

brooksmoses added a comment. Just as an FYI note, this found a bug in one of our random-number generators that was taking a random 32-bit integer and applying abs() to it. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

rprichard added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower enh wrote: > srhines wrote: > > MaskRay wrote: > > > enh wrote:

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 created this revision. barannikov88 added reviewers: cor3ntin, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a complementa

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554070. dhoekwater marked 4 inline comments as done. dhoekwater edited the summary of this revision. dhoekwater added a comment. Make a comment more accurate and simplify test command functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

efriedma added a comment. If you don't have autoupgrade, that means you can't link IR built with older versions of LLVM to IR built with newer versions. llvm::UpgradeDataLayoutString is designed to fix this incompatibility. It's probably worth doing here given that it's relatively straightfor

[clang] 1d0bd8e - [MSABI] Remove comdat attribute for inheriting ctor.

Author: Jennifer Yu Date: 2023-08-28T15:19:23-07:00 New Revision: 1d0bd8e51be2627f79bede54735c38b917ea04ee URL: https://github.com/llvm/llvm-project/commit/1d0bd8e51be2627f79bede54735c38b917ea04ee DIFF: https://github.com/llvm/llvm-project/commit/1d0bd8e51be2627f79bede54735c38b917ea04ee.diff L

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0bd8e51be2: [MSABI] Remove comdat attribute for inheriting ctor. (authored by jyu2). Changed prior to commit: https://reviews.llvm.org/D158538?v

[PATCH] D158071: [clang] Remove rdar links; NFC

MaskRay added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.org/D158071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5852 options::OPT_fno_split_machine_functions)) { -// This codegen pass is only available on x86-elf targets. -if (Triple.isX86() && Triple.isOSBinFormatELF

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554082. dhoekwater added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Dr

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 554083. void added a comment. Move the isFlexibleArrayMemberLike fully into Decl and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/cl

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a subscriber: ABataev. tra added a comment. @ABataev This patch breaks breaks two tests: - github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_codegen.cpp - github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_messages.cpp It's

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann marked 2 inline comments as done. tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10110-10111 +// propagated to the new node prior to instantiation. +if (PrevDecl && PrevDecl->hasAttr()) { + Specialization->addAttr(PrevDecl-

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 554089. ellis added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554094. dhoekwater added a comment. Hopefully get rid of a dead dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Files: clang/lib/Driver/ToolChains/Cla

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554098. dhoekwater edited the summary of this revision. dhoekwater added a comment. Remove a dependency to see if that fixes things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554099. dhoekwater edited the summary of this revision. dhoekwater added a comment. Add the old dependency to hopefully get the change to propagate when I remove it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554100. dhoekwater edited the summary of this revision. dhoekwater added a comment. Remove the dependency again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Fil

[PATCH] D159042: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

brad created this revision. brad added reviewers: MaskRay, kpdev42, abhina.sreeskantharajan. brad added a project: clang. Herald added subscribers: abrachet, phosek. Herald added a project: All. brad requested review of this revision. LiteOS (OHOS) and z/ZOS already have header path handling in th

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

jansvoboda11 added a subscriber: rsmith. jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAnd

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad added a comment. David? Frederic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554115. ldionne added a comment. Poke CI -- it seemed to time out this afternoon due to Phab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4622124 , @aaron.ballman wrote: > Are these matchers going to be used in-tree (by clang-tidy, or something > else)? We typically do not add new AST matches until there's a need for them > because the AST matchers ha

[clang] b6a1473 - [driver] Refactor getRuntimePaths. NFC

Author: Shoaib Meenai Date: 2023-08-28T17:34:50-07:00 New Revision: b6a1473f97d38471b08331dee7ae7f6112c495c0 URL: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0 DIFF: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0.diff

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a1473f97d3: [driver] Refactor getRuntimePaths. NFC (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

<    1   2   3   >