MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { ---------------- Does this need to be in Basic/? It's only used by clang/lib/Driver/ToolChains/Darwin.cpp ================ Comment at: clang/include/clang/Basic/SizedDeallocation.h:36 + case llvm::Triple::ZOS: + return llvm::VersionTuple(); // All z/OS versions have no support. + } ---------------- This is major=minor=0, which is probably not desired. We can just omit ZOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits