MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:121
const ArgList &Args,
- std::vector<StringRef> &Features) {
+ std::vector<StringRef> &Features, bool ForAS) {
+ if (ForAS) {
----------------
Note: ClangAs::ConstructJob doesn't call `Clang::RenderTargetOptions` (and
can't as the function is in `Clang::`). `bool ForAS` is a workaround used by
ARM and will also be used by AArch64. I plan to clean this up at some point,
but for release/17.x I intentionally make it simple.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159010/new/
https://reviews.llvm.org/D159010
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
