[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie added a comment. I will submit it again later to update the code as you suggested. Besides, > Build Status > Buildable 242737 > Build 376801: pre-merge checkslibcxx CI FAILED What does this mean? Was this patch correctly compiled and checked in the previous build? How

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme marked an inline comment as done. mboehme added a subscriber: donat.nagy. mboehme added a comment. In D153006#4463759 , @RKSimon wrote: > @mboehme https://lab.llvm.org/buildbot/#/builders/124 is still broken - > please can you revert the patch se

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal added a comment. In D152435#4467672 , @OikawaKirie wrote: > I will submit it again later to update the code as you suggested. Feel free to commit it with that modifications included. > Besides, > >> Build Status >> Buildable 242737 >> Bui

[clang] 77a599a - [analyzer] Fix false negative when using a nullable parameter directly without binding to a variable

Author: tripleCC Date: 2023-07-03T09:28:41+02:00 New Revision: 77a599ae5828df343e2aa6acc634fe9acb152c99 URL: https://github.com/llvm/llvm-project/commit/77a599ae5828df343e2aa6acc634fe9acb152c99 DIFF: https://github.com/llvm/llvm-project/commit/77a599ae5828df343e2aa6acc634fe9acb152c99.diff LOG:

[PATCH] D153017: [analyzer] Fix false negative when using a nullable parameter directly without binding to a variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a599ae5828: [analyzer] Fix false negative when using a nullable parameter directly without… (authored by tripleCC, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal added a comment. There remained a few more cases using raw-for loops, but those were slightly more tricky to uplift as they either use weird iterators or employ some fancy look-ahead/behind or iterate in parallel over different sequences etc. I'll also make a measurement to confirm it d

[PATCH] D153741: [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation.

hokein updated this revision to Diff 536679. hokein added a comment. rebase and update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153741/new/ https://reviews.llvm.org/D153741 Files: clang/lib/Rewrite/Rewriter.cpp Index: clang/lib/Rewrite/Re

[PATCH] D153741: [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation.

hokein added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153741/new/ https://reviews.llvm.org/D153741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 653920c - [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation.

Author: Haojian Wu Date: 2023-07-03T09:38:11+02:00 New Revision: 653920cb158bf895cdb0b32098a105f26007290a URL: https://github.com/llvm/llvm-project/commit/653920cb158bf895cdb0b32098a105f26007290a DIFF: https://github.com/llvm/llvm-project/commit/653920cb158bf895cdb0b32098a105f26007290a.diff LO

[PATCH] D153741: [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG653920cb158b: [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation. (authored by hokein). Repository: rG LLVM Github Monore

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. But this renders much of my C++98 knowledge obsolete!11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154325/new/ https://reviews.llvm

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:13 +#else +#define ARM_STREAMING_ATTR __attribute__((arm_streaming)) +#endif The spelling has recently changed to the `__arm_streaming`. Also with the new attr

[PATCH] D140690: [dfsan] Support Linux loongarch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG280d163887ea: [dfsan] Support Linux loongarch64 (authored by Ami-zhang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153738: Add LibClang guide

manuel5975p accepted this revision. manuel5975p added a comment. This revision is now accepted and ready to land. Thanks a lot for carefully going through this. I will dispose of the documentation for CXType after accepting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 1bd2d33 - [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

Author: Ella Ma Date: 2023-07-03T16:13:47+08:00 New Revision: 1bd2d335b649f2e09d7e4bdd0b92c78489ded022 URL: https://github.com/llvm/llvm-project/commit/1bd2d335b649f2e09d7e4bdd0b92c78489ded022 DIFF: https://github.com/llvm/llvm-project/commit/1bd2d335b649f2e09d7e4bdd0b92c78489ded022.diff LOG:

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd2d335b649: [analyzer][CStringChecker] Adjust the invalidation operation on the super… (authored by OikawaKirie). Changed prior to commit: https

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

jansvoboda11 added a comment. In D135849#4464234 , @benlangmuir wrote: >> Just realized this most likely won't work if the case-insensitive VFS is >> specified with wrong spelling too, e.g. Fw.framework. > > Is this about the spelling in the VFS definit

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/RecordOps.h:26 +/// fields of record type. It also copies properties from the `StructValue` +/// associated with `Dst` to the `StructValue` associated with `Src` (if these +/// `StructValue`s

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

Hahnfeld created this revision. Hahnfeld added reviewers: erichkeane, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These new functions allow to look at specializations without triggeri

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld abandoned this revision. Hahnfeld added a comment. apparently not needed anymore downstream... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/ https://reviews.llvm.org/D137787 ___ cfe-

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

sdesmalen added a comment. Other than my comment on the test, the patch looks good to me. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_zero.c:20 +// +ARM_SHARED_ZA_ATTR void test_svzero_mask_za() { + svzero_mask_za(0); The new keyword attribu

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536688. eopXD added a comment. Update suffix from `vfadd_vv_i32m1_{policy_suffix, if any}_rm` to `vfadd_vv_i32m1_rm_{policy_suffix, if any}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://rev

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal added a comment. The transformations were done by hand. So I'd encourage you all to have a look and find places where it breaks. Also, it might have personal biases about the style I settled with. Feel free to challenge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein created this revision. hokein added reviewers: avl, JDevlieghere. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154329 Files: l

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152356/new/ https://reviews.llvm.org/D152356 ___

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein updated this revision to Diff 536698. hokein added a comment. Restrict the patch to only remove the writeFileAtomically API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https://reviews.llvm.org/D153740 Files: llvm/include/llv

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein marked an inline comment as done. hokein added a comment. Now this patch only contains the removal part of the API (I have cleaned all usages of `writeFileAtomically` API, except a remaining one in lldb https://reviews.llvm.org/D154329). Comment at: lldb/tools/lldb-ser

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536699. eopXD added a comment. Fix bug in ManualCodeGen of vfadd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td c

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

donat.nagy added a comment. In D153776#4467627 , @balazske wrote: > The success/failure note tags are not added to all functions, `dup` is one of > these, this means at `dup` no note tag is shown. A next patch can be made to > add these messages to all

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536700. eopXD added a comment. Undo the previous diff. There was no bug in the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/

[clang] 4a792e0 - [clang] Fix new-expression with elaborated-type-specifier

Author: Mariya Podchishchaeva Date: 2023-07-03T06:07:04-04:00 New Revision: 4a792e06e8e72f4c14e5a5251e71051d7a984820 URL: https://github.com/llvm/llvm-project/commit/4a792e06e8e72f4c14e5a5251e71051d7a984820 DIFF: https://github.com/llvm/llvm-project/commit/4a792e06e8e72f4c14e5a5251e71051d7a9848

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a792e06e8e7: [clang] Fix new-expression with elaborated-type-specifier (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org

[clang] 899c867 - [clang-format] Fixed bad performance with enabled qualifier fixer.

Author: Sedenion Date: 2023-07-03T11:54:33+01:00 New Revision: 899c86779440dca84085fb53a1fbba6c5aa5a3b6 URL: https://github.com/llvm/llvm-project/commit/899c86779440dca84085fb53a1fbba6c5aa5a3b6 DIFF: https://github.com/llvm/llvm-project/commit/899c86779440dca84085fb53a1fbba6c5aa5a3b6.diff LOG:

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG899c86779440: [clang-format] Fixed bad performance with enabled qualifier fixer. (authored by Sedeniono, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `__has_extension (cxx_defaulted_functions)` and `__has_extension (cxx_defaulted_functions)` since they are accepted

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon updated this revision to Diff 536715. Fznamznon added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154334/new/ https://reviews.llvm.org/D154334 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Feature

[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This also does some cleanups,

[clang] 8e9145e - [clang][ExtractAPI] Add --emit-symbol-graph option

Author: Ankur Date: 2023-07-03T17:32:30+05:30 New Revision: 8e9145e4314202b960dd883e6a7b21707ed5c176 URL: https://github.com/llvm/llvm-project/commit/8e9145e4314202b960dd883e6a7b21707ed5c176 DIFF: https://github.com/llvm/llvm-project/commit/8e9145e4314202b960dd883e6a7b21707ed5c176.diff LOG: [c

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e9145e43142: [clang][ExtractAPI] Add --emit-symbol-graph option (authored by Arsenic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for this! LGTM. but can you also be sure to update this table: https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst?plain=1#L1429 Repositor

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11405-11406 + llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBuilder(); + const OMPDependClause *DepC = dyn_cast(C); + const OMPDoacrossClause *DoC = dyn_cast(C); + if ((DoC &&

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1606 + CGOpenMPRuntimeGPU &RT = + *(static_cast(&CGM.getOpenMPRuntime())); + if (RT.isDelayedVariableLengthDecl(*this, &D)) { 1. use `static_cast(CGM.getOpenMPRuntime())` 2

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; probably, it would be better to add error text here? `

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein updated this revision to Diff 536735. hokein marked an inline comment as done. hokein added a comment. address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 Files: lldb/tools/lldb-se

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; avl wrote: > probably, it would be better to add err

[clang] d963420 - [Headers][X86] Ensure all AVX broadcast scalar load intrinsics are unaligned

Author: Simon Pilgrim Date: 2023-07-03T14:04:50+01:00 New Revision: d9634205d999439807a9f6c5a18be58ac1a55ced URL: https://github.com/llvm/llvm-project/commit/d9634205d999439807a9f6c5a18be58ac1a55ced DIFF: https://github.com/llvm/llvm-project/commit/d9634205d999439807a9f6c5a18be58ac1a55ced.diff

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out this didn't need to be a template a

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme marked 3 inline comments as done. mboehme added a comment. https://reviews.llvm.org/D154339 has changes in response to post-commit comments. Comment at: clang/include/clang/Analysis/FlowSensitive/RecordOps.h:26 +/// fields of record type. It also copies properties from

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping. If no objections, I'll merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

hazohelet updated this revision to Diff 536743. hazohelet edited the summary of this revision. hazohelet added a comment. Edited release note so that it only mentions the clang 16 -> 17 changes, and not development internal ones CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D153296#4459769 , @yronglin wrote: > Please help me, I have no better idea on this issue, do you have any better > ideas? @

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo added a comment. while landing it, if someone feels that the release work can be reworded please feel free to do so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154297/new/ https://reviews.llvm.org/D154297 ___ cfe-commits mailing l

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon added a comment. In D154334#4468158 , @aaron.ballman wrote: > Thank you for this! LGTM. but can you also be sure to update this table: > https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst?plain=1#L1429 Hmm, I hav

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

aaron.ballman added a comment. In D154334#4468404 , @Fznamznon wrote: > In D154334#4468158 , @aaron.ballman > wrote: > >> Thank you for this! LGTM. but can you also be sure to update this table: >> https://githu

[clang] 2d4f289 - [clang] Add `__has_extension ()` for C++11 features

Author: Mariya Podchishchaeva Date: 2023-07-03T10:15:40-04:00 New Revision: 2d4f2890823fa3edc6ae563edec4dacad1989564 URL: https://github.com/llvm/llvm-project/commit/2d4f2890823fa3edc6ae563edec4dacad1989564 DIFF: https://github.com/llvm/llvm-project/commit/2d4f2890823fa3edc6ae563edec4dacad19895

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d4f2890823f: [clang] Add `__has_extension ()` for C++11 features (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:116 - -// Now: how do we adjust the previous/next bounds? Three cases: -// A) If they are also part of the s

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

ldionne added a comment. Herald added a subscriber: ekilmer. What is the status of this? We now require CMake 3.20, can this be rebased and landed in some form? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/ https://reviews.llvm.org/D14

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-format.rst:6 + +Converts calls to ``absl::StrFormat`` to equivalent calls to C++20's +``std::format`` function, modifying the format string appropriately. The ---

[PATCH] D154349: [include-cleaner] Add a signal to down-rank exporting headers

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently exporter can have same relevance signals as the origin header whe

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet updated this revision to Diff 536771. hazohelet edited the summary of this revision. hazohelet added a comment. - Removed the `base class inherited here` redundant note - Provided source range and added test for it The provided source range is NOT directly calling `CXXBaseSpecifier::ge

[clang] 9841daf - [clang][tooling] Fix early termination when there are nested expansions

Author: Kadir Cetinkaya Date: 2023-07-03T16:58:04+02:00 New Revision: 9841daf27076886c6ab8e155eb812bda76f77532 URL: https://github.com/llvm/llvm-project/commit/9841daf27076886c6ab8e155eb812bda76f77532 DIFF: https://github.com/llvm/llvm-project/commit/9841daf27076886c6ab8e155eb812bda76f77532.dif

[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9841daf27076: [clang][tooling] Fix early termination when there are nested expansions (authored by kadircet). Repository: rG LLVM Github Monorepo

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari added a comment. In D153881#4467127 , @aaron.ballman wrote: > I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but > separate `constexpr` out into its own warning flag, but I'm also not opposed. Would moving both const and

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:67 /// Determine which headers should be inserted or removed from the main file. /// This exposes conclusions but not reasons: use lower-level walkUsed for t

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther created this revision. cwalther added reviewers: MaskRay, jroelofs. cwalther added projects: clang, PowerPC. Herald added subscribers: luismarques, steven.zhang, s.egerton, shchenz, abidh, PkmX, simoncook, asb, kristof.beyls, arichardson, nemanjai. Herald added a project: All. cwalther re

[PATCH] D154359: [clang] Reset FP options before template instantiation

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. AST nodes that may depend on FP options keep them as a difference relative to the options

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:378 + { {"core_3rd_gen_avx"}, CK_IvyBridge, FEATURE_AVX, FeaturesIvyBridge, 'S', true }, + { {"core-avx-i"}, CK_IvyBridge, FEATURE_AVX, FeaturesIvyBridge, '\0', false }, // Haswell microar

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added a comment. this LGTM. thanks! Please, wait for approve from Jonas. I think someone from lldb needs to check whether new error reporting is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 __

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. In D153296#4468373 , @aaron.ballman wrote: > In D153296#4459769 , @yronglin > wrote: > >> Please help me, I have no better idea on this issue, do you have any better >> ideas? @erichke

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536795. Jake-Egan added a comment. Thanks for the review @scott.linder. I applied the changes you requested with some differences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driv

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536798. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGStmtOpen

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11405-11406 + llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBuilder(); + const OMPDependClause *DepC = dyn_cast(C); + const OMPDoacrossClause *DoC = dyn_cast(C); + if ((DoC && DoC

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan marked 6 inline comments as done. Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1022 + if (PaddingSize) { +assert(PaddedSize - Index == WordSize); +std::array LastWord = {0}; I changed the assert that you requested

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:986 + + // If there's no metadata, the length is 0. + if (MetadataSize == 0) { Handled the 0 length case here. CHANGES SINCE LAST ACTION h

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 536802. yronglin added a comment. Address comment. - Change `EvaluateDependentExpr`. - Add more test for do/while/for/return/ctor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llv

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73 + // puts the width and preicision first. + std::vector> ArgRotates; + mikecrowe wrote: > PiotrZSL wrote: > > mikecrowe wrote: > > > PiotrZSL wrote: > > >

[clang-tools-extra] 2806cf4 - [clang-tidy] Fix width/precision argument order in modernize-use-std-print

Author: Mike Crowe Date: 2023-07-03T16:39:04Z New Revision: 2806cf4b5430ad6d4d5aa2d501aea1de67272876 URL: https://github.com/llvm/llvm-project/commit/2806cf4b5430ad6d4d5aa2d501aea1de67272876 DIFF: https://github.com/llvm/llvm-project/commit/2806cf4b5430ad6d4d5aa2d501aea1de67272876.diff LOG: [c

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

This revision was automatically updated to reflect the committed changes. Closed by commit rG2806cf4b5430: [clang-tidy] Fix width/precision argument order in modernize-use-std-print (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ce2d44b - [clang-tidy] Accessing checks not done for aliases of `std::array`

Author: Jorge Pinto Sousa Date: 2023-07-03T16:43:08Z New Revision: ce2d44b0ab6da147931e9711e01d44a672ec3854 URL: https://github.com/llvm/llvm-project/commit/ce2d44b0ab6da147931e9711e01d44a672ec3854 DIFF: https://github.com/llvm/llvm-project/commit/ce2d44b0ab6da147931e9711e01d44a672ec3854.diff

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

This revision was automatically updated to reflect the committed changes. Closed by commit rGce2d44b0ab6d: [clang-tidy] Accessing checks not done for aliases of `std::array` (authored by sousajo, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D154297?vs=536622&id=5368

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

benlangmuir added a comment. > You mean diagnosing whenever the spelling in the VFS definition differs from > its realpath? Right, this would be ideal, but may be too expensive in practice. > How could we make that work with symlinks in place? Ah right, we are intentionally allowing symlinks i

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11410 } else { -assert(C->getDependencyKind() == OMPC_DEPEND_sink); +assert(ODK.isSink(C)); RTLFn = OMPBuilder.getOrCreateRuntimeFunction(CGM.getModule(), Add a messa

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch adds additional printing of template argument list when the described function is a

[PATCH] D154368: [Clang] Fix constraint checking of non-generic lambdas.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A lambda call operator can be a templated entity - and therefore have constraints while not being a function template t

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536838. jyu2 added a comment. Thanks Alexey for the review!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11410 } else { -assert(C->getDependencyKind() == OMPC_DEPEND_sink); +assert(ODK.isSink(C)); RTLFn = OMPBuilder.getOrCreateRuntimeFunction(CGM.getModule(), ABataev wrote:

[PATCH] D154378: [LinkerWrapper] Set the GPU LTO job to be freestanding

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, yaxunl, tianshilei1992. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO c

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. > It seems to me that maybe anything with OS none (although that doesn’t seem > to be distinguished from unknown) I considered splitting `none` from `unknown` in Triple, but never had the time to do it. I think this would be good for baremetal toolchains in light of th

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf created this revision. capfredf added a reviewer: v.g.vassilev. Herald added a project: All. capfredf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enabled users to use code completion in a REPL session. The solution

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

jansvoboda11 added a comment. Okay, I'll try to figure out how expensive this would be. I'd like Clang to be stricter in situations like these, but if that's not feasible, I'll probably implement the first workaround. For the second workaround, I don't think that moves us in better direction -

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

benlangmuir added a comment. In D135849#4469347 , @jansvoboda11 wrote: > It'd be really nice to have DirectoryEntry::getDir() API, so that we can walk > up the directory hierarchy while preserving the virtual/real distinction > between directories in t

[PATCH] D154385: [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, arsenm. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. `-fno-hip-fp32-correctly-rounded-divide-sqrt` affects clang codegen and should be passed to clang -cc1 by clang driver

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:2285-2297 +return (C->getDependencyKind() == OMPC_DEPEND_sink); + } + bool isSource(const OMPDependClaus

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

garymm added a comment. Herald added subscribers: carlosgalvezp, mgehre. Herald added a project: All. @aaron.ballman what's remaining for this to be mergeable? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61508/new/ https://reviews.llvm.org/D61508

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

shafik added a comment. Thank you or the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154334/new/ https://reviews.llvm.org/D154334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef C

[PATCH] D154385: [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4eef52885341: [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1 (authored by yaxunl). Herald added a project: clang. Repository:

[clang] 4eef528 - [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1

Author: Yaxun (Sam) Liu Date: 2023-07-03T16:19:25-04:00 New Revision: 4eef528853418fd72bffbb139d953520bb7b4c73 URL: https://github.com/llvm/llvm-project/commit/4eef528853418fd72bffbb139d953520bb7b4c73 DIFF: https://github.com/llvm/llvm-project/commit/4eef528853418fd72bffbb139d953520bb7b4c73.dif

  1   2   >