steakhal added a comment.

In D152435#4467672 <https://reviews.llvm.org/D152435#4467672>, @OikawaKirie 
wrote:

> I will submit it again later to update the code as you suggested.

Feel free to commit it with that modifications included.

> Besides,
>
>> Build Status
>> Buildable 242737     
>> Build 376801: pre-merge checks       libcxx CI FAILED
>
> What does this mean? Was this patch correctly compiled and checked in the 
> previous build? How can I avoid this failure?

This is likely some anomaly. In general, you should check those logs to see if 
it's related to your patch. If not, than you can proceed and check if any of 
the bots cry after you commit.
If they do, triage what went wrong and decide if you attempt a fix commit or a 
revert.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152435/new/

https://reviews.llvm.org/D152435

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to