sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:116 - - // Now: how do we adjust the previous/next bounds? Three cases: - // A) If they are also part of the same macro arg, we translate them too. ---------------- (no action needed) we had extensive discussion of why this change is a no-op, and how to prove it, and what comments to leave. However in the end I don't think such a comment is necessary, because the code makes sense in isolation, and equivalence-to-previous-version isn't very interesting! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154335/new/ https://reviews.llvm.org/D154335 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
