sdesmalen added a comment.
Other than my comment on the test, the patch looks good to me.
================
Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_zero.c:20
+//
+ARM_SHARED_ZA_ATTR void test_svzero_mask_za() {
+ svzero_mask_za(0);
----------------
The new keyword attributes are a bit stricter on the placement.
Because this is a //type// attribute (as opposed to a //declaration//
attribute), it should be placed like this:
void test_svzero_mask_za() ARM_SHARED_ZA_ATTR {
As I mentioned on D128648, I think it's better to remove all these macros for
now and only add the attributes when we add diagnostics in Sema for missing
attributes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
