[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 530408. eopXD added a comment. Add semantic checking for the vxrm paramter. Test case are added `CodeGen/RISCV/rvv-intrinsics-handcrafted/{vaadd/vaaddu/vasub/vasubu}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D152443: Add operator style options to clang-format

MyDeveloperDay added a comment. did you cover the case where I have a namespaced, static foo::Bar->operator==() foo::Bar->m_oper->operator==() foo::Bar->m_oper.operator==() foo::Bar.operator==() Comment at: clang/lib/Format/TokenAnnotator.cpp:4207-4210 +if (!To

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot for bearing with me, LGTM! let me know if i should land this for you. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:165 bool CollectInactiveRegio

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/include/clang/Driver/Options.td:2303 + Group, Flags<[NoXarchOption, CC1Option, CoreOption]>, + HelpText<"Set the maximum number of source lines to show in a caret diagnostic">, + Marsha

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang planned changes to this revision. tingwang added a comment. Hi Matt @arsenm, thank you for your comments, and I will incorporate your suggestions in the next version. Since the review process of dependent patch https://reviews.llvm.org/D125095 didn't get any progress for a long time, I

[PATCH] D152683: [clang][dataflow] Model pointer value for builtin functions.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a false positive in the Crubit nullab

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

Szelethus added a comment. In D152436#4411912 , @steakhal wrote: > In D152436#4408811 , @balazske > wrote: > >> In D152436#4408301 , @steakhal >> wrote: >> >>> I looked

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

mboehme added a comment. libcxx failures look unrelated (this is a comment-only change that doesn't touch libcxx) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152369/new/ https://reviews.llvm.org/D152369 _

[clang] bbeda83 - [clang][dataflow][NFC] Expand comments on losing values in optional checker.

Author: Martin Braenne Date: 2023-06-12T08:46:34Z New Revision: bbeda83090adcb3609f9c1331b2345e7fa547f90 URL: https://github.com/llvm/llvm-project/commit/bbeda83090adcb3609f9c1331b2345e7fa547f90 DIFF: https://github.com/llvm/llvm-project/commit/bbeda83090adcb3609f9c1331b2345e7fa547f90.diff LOG

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbeda83090ad: [clang][dataflow][NFC] Expand comments on losing values in optional checker. (authored by mboehme). Repository: rG LLVM Github Monor

[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This should hel

[PATCH] D152686: [clangd] Enforce strict unused includes by default

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Depen

[PATCH] D152687: [clangd] Turn on missing-include diags by default

kadircet created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. By disabling include-cleaner analysis for Diagnost

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D152689: [NFC] Remove dead conditionals

schittir created this revision. schittir added reviewers: tahonermann, aaron.ballman, erichkeane. Herald added a subscriber: hiraditya. Herald added a project: All. schittir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon updated this revision to Diff 530434. Fznamznon added a comment. Rebase, update value of macro since P2564 is implemented now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm

[PATCH] D147717: [C++20] Claim full support for consteval again

Fznamznon added a comment. https://github.com/llvm/llvm-project/issues/62886 has been fixed, I'm trying to figure out or at least reduce https://github.com/llvm/llvm-project/issues/60709 so it doesn't have headers included, but no progress so far. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks good! Comment at: clang-tools-extra/clangd/IncludeCleaner.h:60 +issueIncludeCleanerDiagnostics(ParsedAST &AST, llvm::StringRef Code, +

[PATCH] D152686: [clangd] Enforce strict unused includes by default

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:9 +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clang-tidy/ClangTidyOptio

[PATCH] D147227: [clangd] Support Config in TestTU.

hokein abandoned this revision. hokein added a comment. abandon this in favour of https://reviews.llvm.org/D152685/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147227/new/ https://reviews.llvm.org/D147227

[clang-tools-extra] 031ffc3 - [clangd] Decouple IncludeCleaner implementation from Config

Author: Kadir Cetinkaya Date: 2023-06-12T11:38:58+02:00 New Revision: 031ffc3e064525731914eff2ea0dfab1ff34cce1 URL: https://github.com/llvm/llvm-project/commit/031ffc3e064525731914eff2ea0dfab1ff34cce1 DIFF: https://github.com/llvm/llvm-project/commit/031ffc3e064525731914eff2ea0dfab1ff34cce1.dif

[PATCH] D147233: [clangd] Enable unused-include diagnostic by default.

hokein abandoned this revision. hokein added a comment. Abandon in favour of https://reviews.llvm.org/D152686. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147233/new/ https://reviews.llvm.org/D147233 _

[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG031ffc3e0645: [clangd] Decouple IncludeCleaner implementation from Config (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D152685?vs=

[clang-tools-extra] ea20f33 - [clangd] Enforce strict unused includes by default

Author: Kadir Cetinkaya Date: 2023-06-12T11:47:03+02:00 New Revision: ea20f339d91f57694899c29198f2dfb41bf9a03a URL: https://github.com/llvm/llvm-project/commit/ea20f339d91f57694899c29198f2dfb41bf9a03a DIFF: https://github.com/llvm/llvm-project/commit/ea20f339d91f57694899c29198f2dfb41bf9a03a.dif

[PATCH] D152686: [clangd] Enforce strict unused includes by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGea20f339d91f: [clangd] Enforce strict unused includes by default (authored by kadircet). Changed prior to

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

indev29 added a comment. @PiotrZSL could you please commit? I don't think I have access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152625/new/ https://reviews.llvm.org/D152625 ___ cfe-commits mai

[clang] 8a19af5 - [Clang] Remove uses of PointerType::getWithSamePointeeType (NFC)

Author: Nikita Popov Date: 2023-06-12T12:18:28+02:00 New Revision: 8a19af513d549c173b5919fe697828c84cecc396 URL: https://github.com/llvm/llvm-project/commit/8a19af513d549c173b5919fe697828c84cecc396 DIFF: https://github.com/llvm/llvm-project/commit/8a19af513d549c173b5919fe697828c84cecc396.diff

[clang] 5cc721b - [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

Author: Timm Bäder Date: 2023-06-12T12:44:25+02:00 New Revision: 5cc721b3f96e40524cd95e7d4aabb6727de83ee3 URL: https://github.com/llvm/llvm-project/commit/5cc721b3f96e40524cd95e7d4aabb6727de83ee3 DIFF: https://github.com/llvm/llvm-project/commit/5cc721b3f96e40524cd95e7d4aabb6727de83ee3.diff LO

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG5cc721b3f96e: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option (authored by tbaeder).

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme created this revision. Herald added a subscriber: thopre. Herald added a project: All. mboehme requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We have recently started seeing deadlocks in death tests while running

[PATCH] D152443: Add operator style options to clang-format

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4203 return true; - -if (Left.is(tok::kw_operator)) - return Right.is(tok::coloncolon); +// Operator overloads, calls and address-of expressions +if (Left.is(tok::kw_

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

PiotrZSL added a comment. In D152625#4413242 , @indev29 wrote: > @PiotrZSL could you please commit? I don't think I have access yet. Author & Email please for git, under which should it be delivered. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152697: AMDGPU: Add llvm.amdgcn.log intrinsic

arsenm created this revision. arsenm added reviewers: AMDGPU, foad, rampitec, Pierre-vh, cdevadas, jhuber6. Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a sub

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak added a comment. Thank you for the feedback. I expect I will be able to refactor the `analyzeOpenMPDeclarative()` function to OpenMP.cpp as suggested, but I'll bring that together with other changes to make it integrate cleanly with the latest changes to D149337

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

indev29 added a comment. In D152625#4413366 , @PiotrZSL wrote: > In D152625#4413242 , @indev29 wrote: > >> @PiotrZSL could you please commit? I don't think I have access yet. > > Author & Email please for git, und

[clang] a8ad413 - [RFC][clangd] Move preamble index out of document open critical path

Author: Kugan Vivekanandarajah Date: 2023-06-12T12:56:41+01:00 New Revision: a8ad413f0d18c07a4adaa0d547e0096874d809c5 URL: https://github.com/llvm/llvm-project/commit/a8ad413f0d18c07a4adaa0d547e0096874d809c5 DIFF: https://github.com/llvm/llvm-project/commit/a8ad413f0d18c07a4adaa0d547e0096874d80

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8ad413f0d18: [RFC][clangd] Move preamble index out of document open critical path (authored by kuganv, committed by ivanmurashko). Repository: rG

[PATCH] D147717: [C++20] Claim full support for consteval again

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (though I wonder if we should add a release note as well) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717

[PATCH] D152689: [NFC] Remove dead conditionals

aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. The other two changes LGTM, but the objc changes bring up a question about what the correct fix is. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV

[PATCH] D152697: AMDGPU: Add llvm.amdgcn.log intrinsic

foad accepted this revision. foad added a comment. This revision is now accepted and ready to land. Seems fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152697/new/ https://reviews.llvm.org/D152697 ___ cfe-commits mailing list cfe-commit

[clang] 3f31d32 - [clang][dataflow] Model pointer value for builtin functions.

Author: Martin Braenne Date: 2023-06-12T12:23:18Z New Revision: 3f31d3204bd2726fa8e5c56ea27c8bba0074790e URL: https://github.com/llvm/llvm-project/commit/3f31d3204bd2726fa8e5c56ea27c8bba0074790e DIFF: https://github.com/llvm/llvm-project/commit/3f31d3204bd2726fa8e5c56ea27c8bba0074790e.diff LOG

[PATCH] D152683: [clang][dataflow] Model pointer value for builtin functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f31d3204bd2: [clang][dataflow] Model pointer value for builtin functions. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152683/new/

[clang-tools-extra] 2499bee - [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

Author: indev Date: 2023-06-12T12:24:08Z New Revision: 2499beeb5a3d3d2062b14be8ae0f967ef44968ba URL: https://github.com/llvm/llvm-project/commit/2499beeb5a3d3d2062b14be8ae0f967ef44968ba DIFF: https://github.com/llvm/llvm-project/commit/2499beeb5a3d3d2062b14be8ae0f967ef44968ba.diff LOG: [clang-

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG2499beeb5a3d: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument (authored by indev29, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D147717: [C++20] Claim full support for consteval again

Fznamznon added a comment. In D147717#4413522 , @aaron.ballman wrote: > LGTM (though I wonder if we should add a release note as well) I can add a note saying that the macro is now defined. Is somewhere under `C++ Language Changes` title the right plac

[PATCH] D147717: [C++20] Claim full support for consteval again

aaron.ballman added a comment. In D147717#4413593 , @Fznamznon wrote: > In D147717#4413522 , @aaron.ballman > wrote: > >> LGTM (though I wonder if we should add a release note as well) > > I can add a note saying

[PATCH] D149548: [IR] Update to use new shufflevector semantics

uweigand added a comment. So the semantics of the `vec_promote(a, b)` intrinsic is defined as: > Returns a vector with a in element position b. The result is a vector with a > in element position b. [...] The other elements of the vector are undefined. This is currently implemented by using `in

[PATCH] D147717: [C++20] Claim full support for consteval again

Fznamznon updated this revision to Diff 530477. Fznamznon added a comment. Rebase, add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 Files: clang/docs/ReleaseNotes.rst clang/lib/Front

[PATCH] D152696: Prevent deadlocks in death tests.

hans added a comment. I'm no expert here, but I went to check what Chromium does, and it seems to set the death_test_style to "threadsafe" for the whole test suite: https://source.chromium.org/chromium/chromium/src/+/main:base/test/test_suite.cc;l=367 > As the page linked above notes, "flags ar

[PATCH] D149548: [IR] Update to use new shufflevector semantics

nlopes added a comment. In D149548#4413598 , @uweigand wrote: > So the semantics of the `vec_promote(a, b)` intrinsic is defined as: > >> Returns a vector with a in element position b. The result is a vector with a >> in element position b. [...] The oth

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, cjdb, tbaeder. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. When the diagnosed function/variable is a template specialization, the source range covers the special

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 lines breaks in inline asm

rymiel updated this revision to Diff 530486. rymiel added a comment. Apply suggestions from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150848/new/ https://reviews.llvm.org/D150848 Files: clang/lib/Format/ContinuationIndenter.cpp clan

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

StephenTozer created this revision. StephenTozer added a project: debug-info. Herald added subscribers: ormris, hiraditya. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jplehr, sstefan1, MaskRay. Hera

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

TWeaver added a comment. Hello and good afternoon from the UK, It looks as though this change has caused the following buildbot to start failing (it's temporarily on staging server so you may not have seen it on the public build bot page): https://lab.llvm.org/staging/#/builders/204/builds/214

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D149548: [IR] Update to use new shufflevector semantics

uweigand added a comment. In D149548#4413639 , @nlopes wrote: > If a vector is fully initialized with `insertvector` (i.e., one operation per > index), then the value of the base vector is irrelevant. It can be poison. > Poison in vectors is element-wise

[clang] aa28875 - [clang][tests] Replace a %clang++ with %clang

Author: Timm Bäder Date: 2023-06-12T15:42:26+02:00 New Revision: aa28875a745d4d70f491b59e1b50f592994c923b URL: https://github.com/llvm/llvm-project/commit/aa28875a745d4d70f491b59e1b50f592994c923b DIFF: https://github.com/llvm/llvm-project/commit/aa28875a745d4d70f491b59e1b50f592994c923b.diff LO

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax updated this revision to Diff 530501. Sinitax added a comment. Rebase patch against branch main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td cla

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

aprantl added a comment. Thanks for prototyping this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152708/new/ https://reviews.llvm.org/D152708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 530505. stuij marked 2 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driv

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 530508. TIFitis marked 4 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

TWeaver added a comment. Thanks for the fix! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 3401a5f - [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

Author: Akash Banerjee Date: 2023-06-12T15:43:09+01:00 New Revision: 3401a5f7584a2f12a90a7538aee2ae37038c82a9 URL: https://github.com/llvm/llvm-project/commit/3401a5f7584a2f12a90a7538aee2ae37038c82a9 DIFF: https://github.com/llvm/llvm-project/commit/3401a5f7584a2f12a90a7538aee2ae37038c82a9.diff

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3401a5f7584a: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

tbaeder added inline comments. Comment at: clang/test/Misc/diag-unused-source-ranges.cpp:1 +// RUN: %clang -fsyntax-only -Wunused -Wunused-template -Wunused-exception-parameter -Wunused-member-function -fdiagnostics-print-source-range-info %s 2>&1 | FileCheck %s --strict-whites

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

tbaeder added a comment. Precommit-CI also found some problems on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152707/new/ https://reviews.llvm.org/D152707 ___ cfe-commits mailing list cfe-commi

[PATCH] D152627: [RISCV] Change the immediate argument to Zvk intrinsics/builtins to i8.

asb added a comment. The patch title should indicate "from i8 to i32" or similar? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152627/new/ https://reviews.llvm.org/D152627 ___ cfe-commits mailing list c

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

tbaeder added inline comments. Comment at: clang/test/Misc/diag-unused-source-ranges.h:1 +static void thing(void) {} Moving this file to `Inputs/` would make sense I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 583371b - [FlowSensitive] Use {DenseMapBase, StringMap}::lookup (NFC)

Author: Kazu Hirata Date: 2023-06-12T08:11:01-07:00 New Revision: 583371be4d341b92de8fe2fa0261b88c404ed31d URL: https://github.com/llvm/llvm-project/commit/583371be4d341b92de8fe2fa0261b88c404ed31d DIFF: https://github.com/llvm/llvm-project/commit/583371be4d341b92de8fe2fa0261b88c404ed31d.diff L

[clang] b18ca72 - Revert "[Driver] Mark many target-specific driver-only options as TargetSpecific"

Author: Hans Wennborg Date: 2023-06-12T17:18:09+02:00 New Revision: b18ca7296ef16700fadac98abe7fac8c8b44b4da URL: https://github.com/llvm/llvm-project/commit/b18ca7296ef16700fadac98abe7fac8c8b44b4da DIFF: https://github.com/llvm/llvm-project/commit/b18ca7296ef16700fadac98abe7fac8c8b44b4da.diff

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530518. TIFitis marked 5 inline comments as done and an inline comment as not done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://review

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4727 + Builder.ClearInsertionPoint(); +} + jdoerfert wrote: > This function doesn't make sense to me. For one, I don't know what a "unreal > block" is. Nor would I have expecte

[PATCH] D152713: [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, Izaron, fwolff. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 530533. TIFitis marked an inline comment as done. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMP

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

simon_tatham updated this revision to Diff 530544. simon_tatham added a comment. Fixed the isReadTPSoft predicate (sorry – I always get confused by when Tablegen autogenerates those predicates and when it doesn't), and reorganised the tests. I couldn't find any existing test file, so I made a n

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 530548. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4409671 , @oontvoo wrote: > P.S This might have the same root-cause with the previous comment and could > be fixed by D152540 as well. > (not able to repro the failures yet - don't

[clang] ed506dd - [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

Author: Vladislav Dzhidzhoev Date: 2023-06-12T18:38:47+02:00 New Revision: ed506dd6cecd9653cf9202bfe195891a33482852 URL: https://github.com/llvm/llvm-project/commit/ed506dd6cecd9653cf9202bfe195891a33482852 DIFF: https://github.com/llvm/llvm-project/commit/ed506dd6cecd9653cf9202bfe195891a3348285

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. Updated DebugInfo test of OCaml binding. In D143984#4409015 , @dblaikie wrote: > When we migrated to github we gained higher fidelity for attributing authors > (we can now commit on someone's behalf but have the commit author

[PATCH] D152570: [clang] Fix filename remapping in template arguments

dankm updated this revision to Diff 530563. dankm added a comment. Rebase and hopefully fix builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Exp

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. Can we land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151820/new/ https://reviews.llvm.org/D151820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

aaron.ballman added a comment. In D142388#4412521 , @rsmith wrote: > I have a concern with the name of this builtin. People are going to assume it > produces a nondeterministic value, and use it for seeding random number > generators and similar, and wi

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

dblaikie added a comment. Really appreciate you providing this prototype. > This solves one of the current weaknesses in DWARF debugging, which is the > inability to set breakpoints or step onto inlined callsites. However, there > are other proposals (such as Location View Numbering) that could

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

aaron.ballman added a comment. In D152246#4412333 , @aaronpuchert wrote: > That's a tough one. The change seems to be correct, and makes more patterns > visible. Of course I wonder how it comes that we see calls of a function > pointer with a uniquely

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

dblaikie added a comment. Are there any known (or vague/unknown) limitations on the implementation with respect to the actual output/on-disk representation? (like, would doing some kind of size analysis of the output when using this patch/feature lead to incorrect conclusions about the cost of

[PATCH] D152634: [Sema] Remove unused isNonTypeNestedNameSpecifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152634/new/ https://reviews.llvm.org/D152634 _

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

xbolva00 added a comment. https://reviews.llvm.org/D136737 used 'builtin_unspecified_value' which could be okay. Are we sure we want to expose this intrinsic as it can be easily misused (as mentioned, as random generator) and/or cause security issues? Maybe only allow it in system headers (ori

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

xbolva00 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3087 + +``__builtin_nondeterministic_value`` returns a valid nondeterministic value of the same type as the provided argument. + This text really sells this new builtin as a random val

[PATCH] D152689: [NFC] Remove dead conditionals

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV = aaron.ballman wrote: > I agree this is dead

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

hiraditya added a comment. In D152279#4406896 , @MaskRay wrote: > In D152279#4405901 , @asb wrote: > >> One of the key things we've been discussing on this at the LLVM call is that >> we probably want to keep the

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel created this revision. ymandel added reviewers: kinu, xazax.hun, mboehme, sgatev. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch allows the client of a `Watc

[PATCH] D152734: [HIP] Fix HIP path detection

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Fix two issues: 1. `--hip-path` should not do rigorous checking, i.e. if .hipVersion e

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 530591. sandeepkosuri added a comment. Updated `target_codegen.cpp` test case to incorporate my changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 Files:

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Huge +1, I think most solvers need to have some resource limits in place as the runtime can explode. I am just not 100% what is the best approach here, putting a global limit on the solv

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1487 + // possible, or else at the end of the function. + void emitBlock(BasicBlock *BB, Function *CurFn, bool IsFinished = false); + This does not mention the deletio

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel added a comment. In D152732#4414661 , @xazax.hun wrote: > Huge +1, I think most solvers need to have some resource limits in place as > the runtime can explode. I am just not 100% what is the best approach here, > putting a global limit on the s

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

kinu added a comment. LGTM as well, I was initially thinking about having a local limit per query (which could be easier to pinpoint the particular query that explodes), but per-solver instance limit could make sense as a starter too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D152072: [4/11][Clang][RISCV] Expand all variants for unit stride segment store

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152072/new/ https://reviews.llvm.org/D152072 ___

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

xazax.hun added a comment. In D152732#4414707 , @ymandel wrote: > Ultimately what matters for a user is the global limit. I am not 100% sure about that. While it is true that the user cares about the process not hanging, but global vs local limits can h

  1   2   >