kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks a lot for bearing with me, LGTM! let me know if i should land this for you. ================ Comment at: clang-tools-extra/clangd/ClangdServer.cpp:165 bool CollectInactiveRegions; + const ClangdServer::Options &Opts; }; ---------------- nit: no need to store a reference to whole Options struct, you can have single boolean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://reviews.llvm.org/D148088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
