Fznamznon updated this revision to Diff 530434.
Fznamznon added a comment.
Rebase, update value of macro since P2564 <https://reviews.llvm.org/P2564> is
implemented now
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147717/new/
https://reviews.llvm.org/D147717
Files:
clang/lib/Frontend/InitPreprocessor.cpp
clang/test/Lexer/cxx-features.cpp
clang/www/cxx_status.html
Index: clang/www/cxx_status.html
===================================================================
--- clang/www/cxx_status.html
+++ clang/www/cxx_status.html
@@ -643,14 +643,7 @@
<tr>
<td rowspan=2>Immediate functions (<tt>consteval</tt>)</td>
<td><a href="https://wg21.link/p1073r3";>P1073R3</a></td>
- <td class="partial" align="center">
- <details><summary>Clang 15 (Partial)</summary>
- Clang still incorrectly defers some consteval executions to runtime,
- resulting in CodeGen crashes. Additionally, Clang does not properly
- handle default arguments in consteval functions under all
- circumstances.
- </details>
- </td>
+ <td class="full" align="center">Clang 17</td>
</tr>
<tr> <!-- from Prague -->
<td><a href="https://wg21.link/p1937r2";>P1937R2</a></td>
Index: clang/test/Lexer/cxx-features.cpp
===================================================================
--- clang/test/Lexer/cxx-features.cpp
+++ clang/test/Lexer/cxx-features.cpp
@@ -78,8 +78,7 @@
#error "wrong value for __cpp_conditional_explicit"
#endif
-#if check(consteval, 0, 0, 0, 0, 0, 0)
-// FIXME: 201811 in C++20
+#if check(consteval, 0, 0, 0, 0, 202211, 202211)
#error "wrong value for __cpp_consteval"
#endif
Index: clang/lib/Frontend/InitPreprocessor.cpp
===================================================================
--- clang/lib/Frontend/InitPreprocessor.cpp
+++ clang/lib/Frontend/InitPreprocessor.cpp
@@ -683,7 +683,7 @@
// Refer to the discussion of this at https://reviews.llvm.org/D128619.
Builder.defineMacro("__cpp_concepts", "201907L");
Builder.defineMacro("__cpp_conditional_explicit", "201806L");
- // Builder.defineMacro("__cpp_consteval", "202211L");
+ Builder.defineMacro("__cpp_consteval", "202211L");
Builder.defineMacro("__cpp_constexpr_dynamic_alloc", "201907L");
Builder.defineMacro("__cpp_constinit", "201907L");
Builder.defineMacro("__cpp_impl_coroutine", "201902L");
Index: clang/www/cxx_status.html
===================================================================
--- clang/www/cxx_status.html
+++ clang/www/cxx_status.html
@@ -643,14 +643,7 @@
<tr>
<td rowspan=2>Immediate functions (<tt>consteval</tt>)</td>
<td><a href="https://wg21.link/p1073r3";>P1073R3</a></td>
- <td class="partial" align="center">
- <details><summary>Clang 15 (Partial)</summary>
- Clang still incorrectly defers some consteval executions to runtime,
- resulting in CodeGen crashes. Additionally, Clang does not properly
- handle default arguments in consteval functions under all
- circumstances.
- </details>
- </td>
+ <td class="full" align="center">Clang 17</td>
</tr>
<tr> <!-- from Prague -->
<td><a href="https://wg21.link/p1937r2";>P1937R2</a></td>
Index: clang/test/Lexer/cxx-features.cpp
===================================================================
--- clang/test/Lexer/cxx-features.cpp
+++ clang/test/Lexer/cxx-features.cpp
@@ -78,8 +78,7 @@
#error "wrong value for __cpp_conditional_explicit"
#endif
-#if check(consteval, 0, 0, 0, 0, 0, 0)
-// FIXME: 201811 in C++20
+#if check(consteval, 0, 0, 0, 0, 202211, 202211)
#error "wrong value for __cpp_consteval"
#endif
Index: clang/lib/Frontend/InitPreprocessor.cpp
===================================================================
--- clang/lib/Frontend/InitPreprocessor.cpp
+++ clang/lib/Frontend/InitPreprocessor.cpp
@@ -683,7 +683,7 @@
// Refer to the discussion of this at https://reviews.llvm.org/D128619.
Builder.defineMacro("__cpp_concepts", "201907L");
Builder.defineMacro("__cpp_conditional_explicit", "201806L");
- // Builder.defineMacro("__cpp_consteval", "202211L");
+ Builder.defineMacro("__cpp_consteval", "202211L");
Builder.defineMacro("__cpp_constexpr_dynamic_alloc", "201907L");
Builder.defineMacro("__cpp_constinit", "201907L");
Builder.defineMacro("__cpp_impl_coroutine", "201902L");
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
