[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. > They are NFC, it's just not 100% only a refactoring, since it adds the new > ASCII-only case. Ok, thanks. Changes look good. I noticed one comment that appears to be incorrect; pl

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex added a comment. In D152443#4408991 , @MyDeveloperDay wrote: > In D152443#4407438 , @KitsuneAlex > wrote: > >> I had some issues with Git there because i messed up a merge, so the diff >> was bad. H

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

david-sawatzke added a comment. Hey I've tried using this patch (roughly following https://noxim.xyz/blog/rust-ch32v003/). It uses the older version of this patch for the rust llvm version (here the llvm tree https://github.com/Noxime/llvm-project/tree/rv32e) and I use rust commit 0939ec13 (to

[PATCH] D152351: [clang] Add __builtin_isfpclass

tschuett added a comment. Could Clang offer a builtin.h file? It is always included. You place named constants and enums inside. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 __

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

beanz added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; philnik wrote: > beanz wrote: > > aaron.ballman wrote: > > > philnik wrote: > > > > Should this als

[PATCH] D152570: [clang] Fix file mapping template arguments

shafik added inline comments. Comment at: clang/lib/AST/Expr.cpp:789 +class PrettyCallbacks final : public PrintingCallbacks { +public: This looks consistent with how other places that set `CallBacks` but I am not familiar with this area. ==

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

erichkeane added inline comments. Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:8 // CHECK-LABEL: entry -// CHECK: [[A:%.*]] = alloca i32, align 4 -// CHECK: store i32 [[X:%.*]], ptr [[A]], align 4 +// CHECK: [[A:%.*]] = alloca i32, align +// CHECK: store i32

[PATCH] D152570: [clang] Fix file mapping template arguments

dankm added inline comments. Comment at: clang/lib/AST/Expr.cpp:791 +public: + PrettyCallbacks(const LangOptions &L) : LO(L) {} + std::string remapPath(StringRef Path) const override { shafik wrote: > This may not be a well known idiom but is widely

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 530057. ychen added a comment. - add one extra test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclB

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen marked an inline comment as done. ychen added inline comments. Comment at: clang/test/SemaTemplate/aggregate-deduction-candidate.cpp:101 + + template struct E { +T t; shafik wrote: > I would also like to see this test: > > ``` > template > struct I

Re: [PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

I'll be unavailable the next 2 weeks, feel free to do it if you want! On Fri, Jun 9, 2023, 21:10 Tom Honermann via Phabricator < revi...@reviews.llvm.org> wrote: > tahonermann added a comment. > > @cor3ntin, sorry for failing to keep up with reviews; I know this has > already been committed. I di

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. In D152090#4407632 , @dyung wrote: > If we do not accept the form "`-fcaret-diagnostics-max-lines n`", can we add > a negative for that? Or if we do a positive test for it as well? I think this is not very useful. This is a new

[clang] b6a7180 - [clang-format] Add test case for issue 63170

Author: Paul Kirth Date: 2023-06-09T20:10:19Z New Revision: b6a718016c0fd7a0d883214ba19d88b6f96e3ae1 URL: https://github.com/llvm/llvm-project/commit/b6a718016c0fd7a0d883214ba19d88b6f96e3ae1 DIFF: https://github.com/llvm/llvm-project/commit/b6a718016c0fd7a0d883214ba19d88b6f96e3ae1.diff LOG: [c

[PATCH] D152473: [clang-format] Add test case for issue 63170

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a718016c0f: [clang-format] Add test case for issue 63170 (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay reopened this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Did this need an immediate revert? was the unit tests failing? Comment at: clang/test/Format/overlapping-lines.cpp:1 +// RUN: grep -Ev "// *[A-Z-]+:" %s | cla

[PATCH] D152570: [clang] Fix file mapping template arguments

dankm updated this revision to Diff 530069. dankm added a comment. Added unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr.cpp clang/tes

[PATCH] D152570: [clang] Fix file mapping template arguments

dankm updated this revision to Diff 530070. dankm added a comment. Fix typo in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr.cpp

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:4941-4943 if (LoadImmOpc == ARM::MRC || LoadImmOpc == ARM::t2MRC) { -assert(Subtarget.isReadTPHard() && +assert(!Subtarget.isReadTPSoft() && "TLS stack protector req

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

MaskRay added a comment. In D141907#4094748 , @MaskRay wrote: > [...] > edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable > `CLANG_RESOURCE_DIR` but did not explain why. > In the long term, the CMake variable `CLANG_RESOURCE_DIR`

[clang-tools-extra] 2adf9c9 - [clang-tidy] Fix error in documentation of bugprone-unchecked-optional-access.

Author: Yitzhak Mandelbaum Date: 2023-06-09T20:42:09Z New Revision: 2adf9c9f502acacf3b846cbf64d8a4739c803de6 URL: https://github.com/llvm/llvm-project/commit/2adf9c9f502acacf3b846cbf64d8a4739c803de6 DIFF: https://github.com/llvm/llvm-project/commit/2adf9c9f502acacf3b846cbf64d8a4739c803de6.diff

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay added a comment. In D152473#4409146 , @paulkirth wrote: > The point of this patch was to show a regression. I'm not trying to fix > anything per se. I'd like https://reviews.llvm.org/D151954 and anything that > depends on it reverted, si

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay added a comment. In D152473#4409652 , @phosek wrote: > LGTM @phosek can I ask you review https://llvm.org/docs/CodeReview.html When providing an unqualified LGTM (approval to commit), it is the responsibility of the reviewer to have re

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

MaskRay added inline comments. Comment at: clang/test/Driver/clang-translation.c:132 +// ARMv7_THREAD_POINTER-HARD: "-target-feature" "+read-tp-tpidruro" + +// RUN: %clang -target armv7-linux -mtp=tpidruro -### -S %s 2>&1 | \ `clang-translation.c`'s job is shifti

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4409975 , @MyDeveloperDay wrote: > In D152473#4409146 , @paulkirth > wrote: > >> The point of this patch was to show a regression. I'm not trying to fix >> anything per se.

[PATCH] D152584: [clang-format] Remove redundant test case

paulkirth created this revision. paulkirth added reviewers: owenpan, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks. paulkirth requested review of this revision. Herald added a comment. NOT

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4409973 , @MaskRay wrote: > In D141907#4094748 , @MaskRay wrote: > >> [...] >> edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable >> `CLANG_RESOURCE_DIR`

[clang] de3c01b - Fix regex in test case so that it doesn't match "coverage" in directory

Author: Akira Hatanaka Date: 2023-06-09T14:20:17-07:00 New Revision: de3c01b06fe5854d2bf72c516e63eaa294e75fd2 URL: https://github.com/llvm/llvm-project/commit/de3c01b06fe5854d2bf72c516e63eaa294e75fd2 DIFF: https://github.com/llvm/llvm-project/commit/de3c01b06fe5854d2bf72c516e63eaa294e75fd2.diff

[PATCH] D152485: Fix regex in test case so that it doesn't match "coverage" in directory names

This revision was automatically updated to reflect the committed changes. Closed by commit rGde3c01b06fe5: Fix regex in test case so that it doesn't match "coverage" in directory (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:615 // need to deal with. if (Vector.getSimpleValueType() != MVT::v2f16) return false; This needs to be updated to include v2bf16 Repository: rG LLVM Github Monorepo

[PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

garymm added a comment. Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. Could you please add this to the documentation? Could this be made the default? It seems like nvcc does this by default. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

tra added a comment. In D16559#4410067 , @garymm wrote: > Could you please add this to the documentation? > Could this be made the default? It seems like nvcc does this by default. Clang already does that, though we only allow variadic functions that don'

[PATCH] D152473: [clang-format] Add test case for issue 63170

phosek added a comment. I understand the concerns and I apologize if my LGTM came out as disrespectful, but there has been an issue reported with the original change over two days ago, including a reproducer, and given given that this issue is

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias added a comment. In D151761#4404179 , @HazardyKnusperkeks wrote: > In D151761#4403828 , @galenelias > wrote: > >> In D151761#4400693 , >> @HazardyKnusperkeks

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 530089. myhsu retitled this revision from "[M68k] Add Clang support for the new M68k_RTD CC" to "[Clang][M68k] Add Clang support for the new M68k_RTD CC". myhsu edited the summary of this revision. myhsu set the repository for this revision to rG LLVM Github Mon

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu marked 3 inline comments as done. myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:4 -// CHECK: mrtd.c:10:3: warning: function with no prototype cannot use the stdcall calling convention +// CHECK: mrtd.c:13:3: warning: function with no prototype cannot

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

MaskRay added a comment. In D151683#4409633 , @aaron.ballman wrote: > In D151683#4384017 , @erichkeane > wrote: > >> In D151683#4382408 , @philnik >> wrote: >> >>> No.

[PATCH] D152589: Add readability test for not allowing relative includes

ErezAmihud created this revision. ErezAmihud added reviewers: clang-tools-extra, njames93. ErezAmihud created this object with edit policy "Administrators". ErezAmihud added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a project: All. ErezAmihud requ

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

NoQ added a comment. I think this is the right solution and I'm happy to see it! We have a few "direct" CFG tests in `test/Analysis/cfg.c` etc.; your patch doesn't seem to be specific to thread safety analysis so it's probably a good idea to add a few direct tests. Comment a

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + efriedma wrote: > efriedma wrote: > > This needs a comment explaining why we're bailing out here. > We might need to do a re

[PATCH] D152589: Add readability test for not allowing relative includes

ErezAmihud updated this revision to Diff 530102. ErezAmihud added a comment. Remove a line in absolute-includes-only.cpp (fix formatting) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152589/new/ https://reviews.llvm.org/D152589 Files: clang-tools-extra/clang-tidy/readability/Absolut

[clang] 1e270be - [-Wunsafe-buffer-usage] Add fix-its for function parameters using the `span` strategy

Author: ziqingluo-90 Date: 2023-06-09T15:44:38-07:00 New Revision: 1e270be0886c3a770e7a967679552a02dfc1dca9 URL: https://github.com/llvm/llvm-project/commit/1e270be0886c3a770e7a967679552a02dfc1dca9 DIFF: https://github.com/llvm/llvm-project/commit/1e270be0886c3a770e7a967679552a02dfc1dca9.diff

[PATCH] D143048: [-Wunsafe-buffer-usage] Add T* -> span Fix-Its for function parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e270be0886c: [-Wunsafe-buffer-usage] Add fix-its for function parameters using the `span`… (authored by ziqingluo-90). Herald added a project: clang

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 530107. nickdesaulniers added a comment. - resurrect HasAnyMaterializeTemporaryExpr, add @efriedma's test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay added a comment. My additional concern is, is the original patch is the root cause of the regression?, so I’m struggling to understand why this in particular is being reverted or are we just going backwards through all commits? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 530109. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - remove fixme, restore isReferenceType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://revie

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 530110. nickdesaulniers added a comment. - move added test case CHECK lines closer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files: clang/lib/CodeGen/

[PATCH] D152589: Add readability test for not allowing relative includes

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AbsoluteIncludesOnlyCheck.cpp:16 + + +namespace clang::tidy::readability { Excessive newline. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:187 +

[clang] a28a466 - [clang-format] Remove redundant test case

Author: Paul Kirth Date: 2023-06-09T23:41:32Z New Revision: a28a46665529992cefb78049da79f2125f6b6c2d URL: https://github.com/llvm/llvm-project/commit/a28a46665529992cefb78049da79f2125f6b6c2d DIFF: https://github.com/llvm/llvm-project/commit/a28a46665529992cefb78049da79f2125f6b6c2d.diff LOG: [c

[PATCH] D152584: [clang-format] Remove redundant test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa28a46665529: [clang-format] Remove redundant test case (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 10e8300 - [-Wunsafe-buffer-usage] Remove the unnecessary `const` qualifier in safe buffer analysis

Author: ziqingluo-90 Date: 2023-06-09T16:41:49-07:00 New Revision: 10e83005367c595821749896e5938ff4f374601b URL: https://github.com/llvm/llvm-project/commit/10e83005367c595821749896e5938ff4f374601b DIFF: https://github.com/llvm/llvm-project/commit/10e83005367c595821749896e5938ff4f374601b.diff

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth marked an inline comment as done. paulkirth added a comment. In D152473#4410331 , @MyDeveloperDay wrote: > My additional concern is, is the original patch is the root cause of the > regression?, so I’m struggling to understand why this in part

[clang] 2e16df3 - [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

Author: Volodymyr Sapsai Date: 2023-06-09T17:09:28-07:00 New Revision: 2e16df352c7acb910313c80ac90b650ad9c14a3d URL: https://github.com/llvm/llvm-project/commit/2e16df352c7acb910313c80ac90b650ad9c14a3d DIFF: https://github.com/llvm/llvm-project/commit/2e16df352c7acb910313c80ac90b650ad9c14a3d.di

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e16df352c7a: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have… (authored by vsapsai). Repository: rG LLVM Github Monorepo

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai added a comment. If anybody has further comments about the condition style, I'm happy to change the code post-commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151523/new/ https://reviews.llvm.org/D151523 _

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1686 -/// [C++17] Only used by CXXDeductionGuideDecl. Indicates that -/// the Deduction Guide is the implicitly generated 'copy -/// deduction candidate' (is used during overload resolution

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 530123. kushanam added a comment. Adding new bf16 tests and refactoring the code with new conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/i

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + nickdesaulniers wrote: > efriedma wrote: > > efriedma wrote: > > > This needs a comment explaining why we're bailing out here. > >

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

arsenm added inline comments. Comment at: clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp:1 +// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -O3 -x c++ < %s | FileCheck %s + Don't use -O3, maybe -O1 -disable-llvm-passes Comment

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

arsenm added a comment. Herald added a subscriber: arichardson. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137524/new/ https://reviews.llvm.org/D137524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

arsenm abandoned this revision. arsenm added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. This was already done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84068/new/ https://reviews.llvm.org/D84068 ___ cfe-co

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added a comment. D84639 is an old version of this. It has some additional tests not covered here, can you copy them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147732/new/ https://reviews.llvm.org/D14773

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

MaskRay created this revision. MaskRay added reviewers: Sanitizers, aeubanks, rnk, eugenis, phosek, probinson. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -fsanitize-address-globals-dead-stripping is

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152604/new/ https://reviews.llvm.org/D152604 ___

[clang] 0e9843b - [clang][parse][NFC] Fix grammar in a comment

Author: Timm Bäder Date: 2023-06-10T07:51:36+02:00 New Revision: 0e9843bf35d94100a843baf660700011227a6cc4 URL: https://github.com/llvm/llvm-project/commit/0e9843bf35d94100a843baf660700011227a6cc4 DIFF: https://github.com/llvm/llvm-project/commit/0e9843bf35d94100a843baf660700011227a6cc4.diff LO

[clang] 6669dc0 - [clang][NFC] Refactor printableTextForNextCharacter

Author: Timm Bäder Date: 2023-06-10T07:51:36+02:00 New Revision: 6669dc09a441f27f3b5e18805a1a59fbe93a4cd6 URL: https://github.com/llvm/llvm-project/commit/6669dc09a441f27f3b5e18805a1a59fbe93a4cd6 DIFF: https://github.com/llvm/llvm-project/commit/6669dc09a441f27f3b5e18805a1a59fbe93a4cd6.diff LO

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

This revision was automatically updated to reflect the committed changes. Closed by commit rG6669dc09a441: [clang][NFC] Refactor printableTextForNextCharacter (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D150843?vs=529170&id=530160#toc Repository: rG LLVM Github M

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev added inline comments. Comment at: clang/docs/ClangRepl.rst:119 + clang-repl> int c = sum(9,10); + clang-repl> std::cout << c; + 19clang-repl> Comment at: clang/docs/ClangRepl.rst:120 + clang-repl> std::cout << c; + 19cl

<    1   2