dankm added inline comments.
================
Comment at: clang/lib/AST/Expr.cpp:791
+ public:
+ PrettyCallbacks(const LangOptions &L) : LO(L) {}
+ std::string remapPath(StringRef Path) const override {
----------------
shafik wrote:
> This may not be a well known idiom but is widely used within llvm.
Makes sense, I was going for unambiguity between the class's member name and
the constructor argument name, but if it's widely used that's fine. I'll add
that change when I add unit tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152570/new/
https://reviews.llvm.org/D152570
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
