[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp:1
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -O3 -x c++ < %s 
| FileCheck %s
+
----------------
Don't use -O3, maybe -O1 -disable-llvm-passes


================
Comment at: clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp:1
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -O3 -x c++ < %s 
| FileCheck %s
+
----------------
arsenm wrote:
> Don't use -O3, maybe -O1 -disable-llvm-passes
Use generated checks with --check-globals?


================
Comment at: clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp:22
+// CHECK: @base_rview = local_unnamed_addr global %struct.ext zeroinitializer, 
align [[ALIGN:[0-9]+]]
+// XFAIL-CHECK: @base_rview = local_unnamed_addr global %struct.ext 
zeroinitializer, align [[ALIGN:[0-9]+]], !associated ![[ASSOC0:[0-9]+]]
+// CHECK: @llvm.global_ctors = appending global [0 x { i32, ptr, ptr }] 
zeroinitializer
----------------
XFAIL-CHECK doesn't do anything


================
Comment at: clang/test/CodeGen/PowerPC/aix-ref-static-var.cpp:11
+// CHECK: @_ZZ1fvE1s = internal global %struct.S zeroinitializer, align 
[[ALIGN:[0-9]+]]
+// XFAIL-CHECK: @_ZZ1fvE1s = internal global %struct.S zeroinitializer, align 
[[ALIGN:[0-9]+]], !associated ![[ASSOC0:[0-9]+]]
+// CHECK: define internal void @__dtor__ZZ1fvE1s() [[ATTR:#[0-9]+]] {
----------------
XFAIL-CHECK doesn't do anything


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145767/new/

https://reviews.llvm.org/D145767

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits