tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land.
> They are NFC, it's just not 100% only a refactoring, since it adds the new > ASCII-only case. Ok, thanks. Changes look good. I noticed one comment that appears to be incorrect; please just remove it when committing the changes. ================ Comment at: clang/lib/Frontend/TextDiagnostic.cpp:128 + + // We now know that the next character is a multi-byte character. + // Convert it to UTF32 and check if it's printable. ---------------- This comment is not correct; `Begin` might still point to a non-printable character with a code point value less than 0x80. I suggest just removing the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
