[PATCH] D151051: [clang-tidy] Optimize misc-confusable-identifiers

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Memoizing the calls to getPrimaryContext()... LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151051/new/ https://revi

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

nridge accepted this revision. nridge added a comment. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 ___ cfe-commits mailing list cfe-commits@li

[clang] 52d3255 - [Clang][RISCV] Add description for test case . NFC

Author: eopXD Date: 2023-05-26T00:22:48-07:00 New Revision: 52d3255704187c3e60de8657d6ece7ab73e07b68 URL: https://github.com/llvm/llvm-project/commit/52d3255704187c3e60de8657d6ece7ab73e07b68 DIFF: https://github.com/llvm/llvm-project/commit/52d3255704187c3e60de8657d6ece7ab73e07b68.diff LOG: [C

[clang-tools-extra] 6feaa54 - [clangd] Implement configs to stop clangd produce a certain semantic tokens

Author: Qingyuan Zheng Date: 2023-05-26T03:25:35-04:00 New Revision: 6feaa5416bf63f9609478d4458485c7306506e26 URL: https://github.com/llvm/llvm-project/commit/6feaa5416bf63f9609478d4458485c7306506e26 DIFF: https://github.com/llvm/llvm-project/commit/6feaa5416bf63f9609478d4458485c7306506e26.diff

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rG6feaa5416bf6: [clangd] Implement configs to stop clangd produce a certain semantic tokens (authored by daiyousei-qz, committed by nridge). Changed prior to commit: https://reviews.llvm.org/D148489?vs=5

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

nridge added a comment. I went ahead and merged this. When you get a chance, could you update https://github.com/llvm/clangd-www/pull/85 as well so we can merge that too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.l

[PATCH] D147894: [clang-format][doc] SortIncludes documentation: remove contradiction in its description

michael-g-matthews added a comment. If this is considered fully approved, would someone with commit access be able to commit this on my behalf? This is my first contribution so I do not have access. My name and email are Mike Matthews and michael.g.matthe...@gmail.com. Thank you! CHANGES SINC

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge planned changes to this revision. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; daiyousei-qz wrote: > hokein wrote: > > While this patch

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Thank you! Since the documentation shouldn't be available until LLVM 17, I'm slowly working on it. Let me update the PR in this weekend :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

porglezomp updated this revision to Diff 525974. porglezomp added a comment. Add significantly more variations in this test case. I discovered multiple inconsistencies while expanding this list out. Filed an issue on GitHub here: https://github.com/llvm/llvm-project/issues/62949 Repository: rG

[clang] 7c52520 - [Clang][RISCV] Add test coverage for typedef of RVV intrinsic data types under riscv_vector.h. NFC

Author: eopXD Date: 2023-05-26T01:27:37-07:00 New Revision: 7c52520c8d0c44230bf5b480d83f8148bdea3232 URL: https://github.com/llvm/llvm-project/commit/7c52520c8d0c44230bf5b480d83f8148bdea3232 DIFF: https://github.com/llvm/llvm-project/commit/7c52520c8d0c44230bf5b480d83f8148bdea3232.diff LOG: [C

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 525978. tomasz-kaminski-sonarsource added a comment. Fixed formatting to match clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 Files:

[clang-tools-extra] fe7afcf - [clangd] Remove inline Specifier for DefineOutline Tweak

Author: Brian Gluzman Date: 2023-05-26T10:43:08+02:00 New Revision: fe7afcf70c93223a16ec7a2a5e07c4ace16c9a04 URL: https://github.com/llvm/llvm-project/commit/fe7afcf70c93223a16ec7a2a5e07c4ace16c9a04 DIFF: https://github.com/llvm/llvm-project/commit/fe7afcf70c93223a16ec7a2a5e07c4ace16c9a04.diff

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe7afcf70c93: [clangd] Remove inline Specifier for DefineOutline Tweak (authored by bgluzman, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 10518fe - [clang-format][doc] Fix contradiction in SortIncludes description

Author: Mike Matthews Date: 2023-05-26T01:58:57-07:00 New Revision: 10518feaf33760e77be46af62c41a1caf4ef1da2 URL: https://github.com/llvm/llvm-project/commit/10518feaf33760e77be46af62c41a1caf4ef1da2 DIFF: https://github.com/llvm/llvm-project/commit/10518feaf33760e77be46af62c41a1caf4ef1da2.diff

[PATCH] D147894: [clang-format][doc] SortIncludes documentation: remove contradiction in its description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10518feaf337: [clang-format][doc] Fix contradiction in SortIncludes description (authored by michael-g-matthews, committed by owenpan). Changed prio

[clang] aed7959 - [clang-format][doc] Fix a typo introduced in 9aab0db13fb6d

Author: Owen Pan Date: 2023-05-26T02:11:42-07:00 New Revision: aed795942b78876d004c146133d9077012256aff URL: https://github.com/llvm/llvm-project/commit/aed795942b78876d004c146133d9077012256aff DIFF: https://github.com/llvm/llvm-project/commit/aed795942b78876d004c146133d9077012256aff.diff LOG:

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, jdoerfert, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, ed

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. Is the __riscv_ntl_* interface finalised and agreed? I'm wary of repeating the mistake we made with the V extension where we exposed intrinsics that weren't yet finalised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/n

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ugh, yeah, so it has come to this. I championed my idea of granulalizing checkers into modeling and reporting components since what... 2018? I think the goal is still something to shoot

[PATCH] D151549: [clang][dataflow] Remove unnecessary `ASTContext` parameter from `ControlFlowContext::build` overload.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When introducing this new overload in https://re

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

steakhal added a comment. I think I'm also for this change. I also wonder why we can't enable posix modeling by default. If we still can't, then when will we? Do you think it would make sense to enable them in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 526013. Endill edited the summary of this revision. Endill added a comment. Address feedback Docs contributed by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang used to reject consteval operators if they're used inside a template due to TreeTransform putting two different `D

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added a comment. Thank you for the review! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11940-11943 - ExprResult Callee = getDerived().TransformExpr(E->getCallee()); - if (Callee.isInvalid()) -return ExprError(); - I don't understand why we would not need to transform t

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11940-11943 - ExprResult Callee = getDerived().TransformExpr(E->getCallee()); - if (Callee.isInvalid()) -return ExprError(); - cor3ntin wrote: > I don't understand why we would not

[PATCH] D146987: [Assignment Tracking] Enable by default

hctim added a comment. Hey, found another error that looks to be different from @maskray's revert. $ bin/clang -c -O2 -g -ftrivial-auto-var-init=zero /tmp/repro.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis added inline comments. Comment at: flang/lib/Lower/OpenMP.cpp:2552 + +void handleDeclareTarget(Fortran::lower::AbstractConverter &converter, + Fortran::lower::pft::Evaluation &eval, This seems to be the only function name with the

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

cor3ntin updated this revision to Diff 526034. cor3ntin added a comment. Address Erich's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151342/new/ https://reviews.llvm.org/D151342 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/Pa

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 526044. pmatos added a comment. Update the patch by removing target specific changes in CGBuiltin. Leave fshl/fshr unchanged for rotates. This actually fixes a todo in fshl/r test. @nikic What do you think of the current patch? Repository: rG LLVM Github

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/fsh.ll:664 +; CHECK-NEXT:[[T1:%.*]] = and i32 [[A:%.*]], -65536 +; CHECK-NEXT:[[T2:%.*]] = call i32 @llvm.fshl.i32(i32 [[T1]], i32 [[T1]], i32 16) ; CHECK-NEXT:ret i32 [[T2]]

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added inline comments. Comment at: llvm/test/Transforms/InstCombine/fsh.ll:664 +; CHECK-NEXT:[[T1:%.*]] = and i32 [[A:%.*]], -65536 +; CHECK-NEXT:[[T2:%.*]] = call i32 @llvm.fshl.i32(i32 [[T1]], i32 [[T1]], i32 16) ; CHECK-NEXT:ret i32 [[T2]]

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

This revision was automatically updated to reflect the committed changes. Closed by commit rG75cd8cdbde45: [Clang] Correctly handle generic lambda used as default template argument. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 75cd8cd - [Clang] Correctly handle generic lambda used as default template argument.

Author: Corentin Jabot Date: 2023-05-26T16:04:10+02:00 New Revision: 75cd8cdbde45d07800d5cefa6f7a213271245e4a URL: https://github.com/llvm/llvm-project/commit/75cd8cdbde45d07800d5cefa6f7a213271245e4a DIFF: https://github.com/llvm/llvm-project/commit/75cd8cdbde45d07800d5cefa6f7a213271245e4a.diff

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille updated this revision to Diff 526059. serge-sans-paille retitled this revision from "[clang] Fix comdat for InlineBuiltin declarations" to "[clang] Restrict Inline Builtin to non-static, non-odr linkage". serge-sans-paille edited the summary of this revision. serge-sans-paille a

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:159 + anyOf(isInstantiatedFrom(hasAnyName(FunVec)), + hasAnyReturnType(RetTypeVec) .bind("match";

[PATCH] D151517: Fix wrong error message when compiling C souce code

jyu2 added a comment. In D151517#4374583 , @ABataev wrote: > Could you split it into 3 separate patch Thanks Alexey! Sure I am split into three. Here is first one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske updated this revision to Diff 526063. balazske marked an inline comment as done. balazske added a comment. Fixed the documentation issue. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/ https://reviews.llvm.org/D1514

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 526064. VitaNuo marked 13 inline comments as done. VitaNuo added a comment. Rework according to the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 F

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske added a comment. The case of fully dependent type (`unique_ptr`) is not working in this checker and likely not in `SharedPtrArrayMismatchCheck`. I can fix this in a next patch (for both checkers). Maybe we can remove the warning in all cases when the type is a POD type (or add a check

[PATCH] D151517: Fix wrong error message when compiling C souce code

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151517/new/ https://reviews.llvm.org/D151517 ___

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should pa

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

shafik added a comment. Thank you for the patch! Please apply clang-format at least one of pre-commit failures is due to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

dang added a comment. LGTM with minor changes Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:58 - virtual ~APISerializer() = default; }; It would be nice to keep this as default, i.e. ``` ~APISetVisitor() = default; ``` ===

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs updated this revision to Diff 526072. codemzs marked an inline comment as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Addresses @rjmccall suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

PiotrZSL accepted this revision. PiotrZSL added a comment. In D151431#4376181 , @balazske wrote: > Maybe we can remove the warning in all cases when the type is a POD type (or > add a check option)? **Leave it... **From a user perspective, it doesn't ma

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen updated this revision to Diff 526090. qianzhen added a comment. Update the option text to be more descriptive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 Files: clang/include/clang/Basic/Co

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. For what it's worth, this change is quite noisy for the Linux kernel, as there are certain macros undefined in header files that are included in many other headers. Additionally, at least one new instanc

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 526101. Endill added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/

[clang] 4a16f65 - [Driver][X86] Reject unsupported value for -mabi=

Author: Fangrui Song Date: 2023-05-26T09:52:57-07:00 New Revision: 4a16f65fc83df494318ced1d894f6b1e562d330c URL: https://github.com/llvm/llvm-project/commit/4a16f65fc83df494318ced1d894f6b1e562d330c DIFF: https://github.com/llvm/llvm-project/commit/4a16f65fc83df494318ced1d894f6b1e562d330c.diff

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a16f65fc83d: [Driver][X86] Reject unsupported value for -mabi= (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D151509?v

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should pa

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 ___ cfe-commits mailing list cfe-commi

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Thanks for addressing all my concerns. LGTM except for a test issue I just commented on. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = Ve

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs added a comment. Hi @rjmccall, @pengfei, and @zahiraam, Thank you for your valuable review and acceptance of my patch. As I lack commit access, could I kindly request one of you to perform the commit on my behalf? Please use the following command: `git commit --amend --author="M. Zeesha

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

rnk added subscribers: efriedma, rjmccall, rnk. rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4376 +.getTypePtr() +->getPointeeOrArrayElementType(); + const Type *CanonicalArgTy = g

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 526115. electriclilies added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

[clang] acb1b4f - Fix wrong error message when compiling C souce code:

Author: Jennifer Yu Date: 2023-05-26T10:14:52-07:00 New Revision: acb1b4fbb7939faa369337b9b26b960fdc91e4b8 URL: https://github.com/llvm/llvm-project/commit/acb1b4fbb7939faa369337b9b26b960fdc91e4b8 DIFF: https://github.com/llvm/llvm-project/commit/acb1b4fbb7939faa369337b9b26b960fdc91e4b8.diff L

[PATCH] D151517: Fix wrong error message when compiling C souce code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacb1b4fbb793: Fix wrong error message when compiling C souce code: (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 526117. electriclilies added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td mli

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

efriedma added a comment. Relevant bit of the AST: `-ExprWithCleanups 0xd16a780 'void':'void' `-CXXOperatorCallExpr 0xd16a678 'void':'void' '()' |-ImplicitCastExpr 0xd16a5a8 'void (*)(int (&&)[]) const' | `-DeclRefExpr 0xd16a528 'void (int (&&)[]) const' lvalue CXXMethod

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by @efriedma in: https://reviews.llvm.org/D76096#4370369 Some minor code style fixes as well i

[clang-tools-extra] 2a84c63 - [clang-tidy] Optimize misc-confusable-identifiers

Author: Piotr Zegar Date: 2023-05-26T17:46:13Z New Revision: 2a84c635f2a1dcb4546a5d751a32eac24103c7e6 URL: https://github.com/llvm/llvm-project/commit/2a84c635f2a1dcb4546a5d751a32eac24103c7e6 DIFF: https://github.com/llvm/llvm-project/commit/2a84c635f2a1dcb4546a5d751a32eac24103c7e6.diff LOG: [

[PATCH] D151051: [clang-tidy] Optimize misc-confusable-identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a84c635f2a1: [clang-tidy] Optimize misc-confusable-identifiers (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151051/new/ https://re

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

rjmccall added a comment. Yeah, I agree with Eli, there should be a cast here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 ___ cfe-commits mailing list cfe-

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

li.zhe.hua updated this revision to Diff 526128. li.zhe.hua added a comment. Switch option name to SuppressElaboration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149677/new/ https://reviews.llvm.org/D149677 Files: clang/include/clang/AST/Pret

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

li.zhe.hua added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1570 + if (Policy.IgnoreElaboratedQualifiers) { +printBefore(T->getNamedType(), OS); aaron.ballman wrote: > So, effectively, the idea here is: you want the ability to skip printing

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D150985#4369279 , @tra wrote: > As I said, I'm OK with the patch in principle, I just don't know what other > factors I may be missing. > > Tests seem to be missing for c11 variants of t

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526131. nickdesaulniers added a comment. - one more style update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151572/new/ https://reviews.llvm.org/D151572 Files: clang/lib/CodeGen/CGExprConstant.cpp

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

efriedma added a comment. Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant evaluator.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151572/new/ https://reviews.l

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes PR#62001. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151575 Files: clang/lib/Fr

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. @NoQ **Re: ElementRegion hacks:** Your suggestion is very convincing, and I agree that while my idea would bring some clarity to some particular issues, overall it would just worsen the "chaotic heap of classes" situation. The only advantage of my solution is that it

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, jplehr, sstefan1. It seems load of traits.addr should be passed in r

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers added a comment. In D151572#4376697 , @efriedma wrote: > Did you intentionally skip moving the ConstExprEmitter call in > tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant > evaluator.) Yes, I'll do that in a follow

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 526144. SlaterLatiao added a comment. - Add newline to end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files: clang/lib/Frontend/DiagnosticRendere

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 526148. evelez7 added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151477/new/ https://reviews.llvm.org/D151477 Files: clang/include/clang/ExtractAPI/Serialization/Seriali

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG9346dc6f675e: Add fastmath attributes to llvm.call_intrinsic (authored by electriclilies, committed by Mogball). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton created this revision. benhamilton added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. benhamilton requested review of this revision. This adds to the Obj

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton updated this revision to Diff 526151. benhamilton added a comment. Fix auto-complete-o. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://reviews.llvm.org/D151578 Files: clang/lib/Format/Format.cpp clang/test/Format

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton updated this revision to Diff 526154. benhamilton added a comment. Add `FOUNDATION_EXTERN` alias for `FOUNDATION_EXPORT` (Apple `#define`s the former to the latter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://rev

[PATCH] D151581: [clang][modules] NFCI: Distinguish written/effective umbrella directories

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For modules with umbrell

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526159. chaitanyav marked 4 inline comments as done. chaitanyav added a comment. Make changes as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:129 + CheckedReturnTypes(utils::options::parseStringList( + Options.get("Ch

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 526163. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitiz

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. @jyu2 : could you test that patch in your setup ? Also I can't find the bug id associated with your original bug anymore... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 ___

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( Do we need an install target for `${cuda_wrapper_bits_files}` for the `cuda-resource-headers` component as well? It seems to be the

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526173. chaitanyav marked an inline comment as done. chaitanyav added a comment. use fully qualified name in code and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.l

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes some deprec

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added a comment. @steakhal did you get a chance to look at my comment? I would really love to see this merged upstream if you think this could be a beneficial change :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM, you may consider reducing commit message (aka review description by removing example and error from it, and leaving just plain description of a change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. In D151383#4377043 , @PiotrZSL wrote: > LGTM, you may consider reducing commit message (aka review description by > removing example and error from it, and leaving just plain description of a > change). got it, will make sur

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

jyu2 added a comment. In D148723#4376946 , @serge-sans-paille wrote: > @jyu2 : could you test that patch in your setup ? Also I can't find the bug > id associated with your original bug anymore... I just submit bug in https://github.com/llvm/llvm-proje

[PATCH] D151586: [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most users of `Module::H

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by @efriedma in: https://reviews.llvm.org/D76096#4370369 Signed-off-by: Nick Desaulniers Re

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, jansvoboda11, pengfei, power-llvm-team. Herald added subscribers: jrtc27, fedor.sergeev, nemanjai, jyknight. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526192. nickdesaulniers added a comment. - also remove VisitExprWithCleanups, down to two outstanding test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D15

[PATCH] D151581: [clang][modules] NFCI: Distinguish written/effective umbrella directories

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Module.h:655 + /// Retrieve the explicitly written umbrella directory for this module. + DirectoryName getWrittenUmbrell

[clang-tools-extra] 785b30b - [clang-tidy] Check for specific return types on all functions

Author: NagaChaitanya Vellanki Date: 2023-05-26T13:59:18-07:00 New Revision: 785b30b8a33a394a677b1b8ce35c66ba482db169 URL: https://github.com/llvm/llvm-project/commit/785b30b8a33a394a677b1b8ce35c66ba482db169 DIFF: https://github.com/llvm/llvm-project/commit/785b30b8a33a394a677b1b8ce35c66ba482db

  1   2   >