PiotrZSL accepted this revision. PiotrZSL added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:129 + CheckedReturnTypes(utils::options::parseStringList( + Options.get("CheckedReturnTypes", "std::error_code;" + "std::expected;" ---------------- good but put those all as fully qualified names (starting with ::) like in Checkedfunctions, and align documentation ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/unused-return-value.rst:53 + By default the following function return types are checked: + `std::error_code, std::expected, boost::system::error_code, abseil::Status` + ---------------- split this, into `::std::error_code`, `::std::expected`, and so on... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits