chaitanyav added a comment.
In D151383#4377043 <https://reviews.llvm.org/D151383#4377043>, @PiotrZSL wrote:
> LGTM, you may consider reducing commit message (aka review description by
> removing example and error from it, and leaving just plain description of a
> change).
got it, will make sure to remove them from the arc generated commit message.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:159
+ anyOf(isInstantiatedFrom(hasAnyName(FunVec)),
+ hasAnyReturnType(RetTypeVec)))))
.bind("match"))));
----------------
PiotrZSL wrote:
> Consider:
>
> hasAnyReturnType ->
> `returns(hasCanonicalType(hasDeclaration(namedDecl(matchers::matchesAnyListedName(RetTypeVec))))`
> Note that to use matchesAnyListedName, you should save RetTypeVec as class
> member, just to be safe.
I followed the code in ForRangeCopyCheck.cpp and made the changes accordingly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151383/new/
https://reviews.llvm.org/D151383
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
