[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder created this revision. tbaeder added reviewers: clang, cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Seems unnecessary to create a `StringRef` here just so we can drop the

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder updated this revision to Diff 525031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151300/new/ https://reviews.llvm.org/D151300 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp =

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

tbaeder created this revision. tbaeder added reviewers: clang, cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should preserve empty lines in output snippets. Repository: rG L

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. In D151298#4367163 , @xry111 wrote: > Blocking this as it's a deliberate decision made in D132285 > . > > Is there any imperative reason we must really pass the empty struct? The C++ > standa

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367215 , @wangleiat wrote: > In D151298#4367163 , @xry111 wrote: > >> Blocking this as it's a deliberate decision made in D132285 >> . >> >> I

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

tbaeder added inline comments. Comment at: clang/test/Misc/diag-style.cpp:10 +// CHECK-NEXT: {{^}} | ^~~~{{$}} +// CHECK-NEXT: {{^}}5 | {{$}} +// CHECK-NEXT: {{^}}6 | true, "");{{$}} Questionable whether the space afte

[clang] 1c9a800 - Recommit [C++20] [Modules] Serialize the evaluated constant values for VarDecl

Author: Chuanqi Xu Date: 2023-05-24T15:45:16+08:00 New Revision: 1c9a8004ed88c9a5e42e5b247cb489456559b845 URL: https://github.com/llvm/llvm-project/commit/1c9a8004ed88c9a5e42e5b247cb489456559b845 DIFF: https://github.com/llvm/llvm-project/commit/1c9a8004ed88c9a5e42e5b247cb489456559b845.diff LO

[PATCH] D151303: [clangd] Fix add-using tweak on declrefs with template arguments

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D151303: [clangd] Fix add-using tweak on declrefs with template arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51df1a9ac96f: [clangd] Fix add-using tweak on declrefs with template arguments (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGE

[clang-tools-extra] 51df1a9 - [clangd] Fix add-using tweak on declrefs with template arguments

Author: Kadir Cetinkaya Date: 2023-05-24T09:56:53+02:00 New Revision: 51df1a9ac96f0cf588e97d3174d5c16ed9577b96 URL: https://github.com/llvm/llvm-project/commit/51df1a9ac96f0cf588e97d3174d5c16ed9577b96 DIFF: https://github.com/llvm/llvm-project/commit/51df1a9ac96f0cf588e97d3174d5c16ed9577b96.dif

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. In D151298#4367225 , @xry111 wrote: > In D151298#4367215 , @wangleiat > wrote: > >> In D151298#4367163 , @xry111 wrote: >> >>> Blocking this as

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

tbaeder updated this revision to Diff 525050. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151301/new/ https://reviews.llvm.org/D151301 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Misc/diag-style.cpp Index: clang/test/Misc/diag-style.cpp ===

[clang] c3c0774 - [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

Author: Jens Massberg Date: 2023-05-24T10:02:58+02:00 New Revision: c3c0774b1d6ef524de3a25e1f13828d2f9861aad URL: https://github.com/llvm/llvm-project/commit/c3c0774b1d6ef524de3a25e1f13828d2f9861aad DIFF: https://github.com/llvm/llvm-project/commit/c3c0774b1d6ef524de3a25e1f13828d2f9861aad.diff

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparison operator aren't as expected.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c0774b1d6e: [Clang][C++20] Error out if parameter types of a defaulted comparion operator… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1246 // line from what the user is intended to see. -if (DiagOpts->ShowSourceRanges) { +if (DiagOpts->ShowSourceRanges && !SourceLine.empty()) { SourceLine = ' ' + SourceLine; ---

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 525054. cor3ntin added a comment. Revert unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367349 , @wangleiat wrote: > In D151298#4367225 , @xry111 wrote: > >> In D151298#4367215 , @wangleiat >> wrote: >> >>> In D151298#4367

[PATCH] D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in: https://github.com/ARM-software/acle/p

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. > I think the paragraph means: > > class Empty {}; > int test(Empty empty, int a); > > Then we should put `a` into `a1`, not `a0`. And we are indeed doing so. yes. with this patch, `a` will be passed with `a1` register. > I mean now GCC and Clang have the same beh

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham created this revision. simon_tatham added reviewers: peter.smith, MaskRay, dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Function po

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham added a comment. I think this began going wrong as a result of D148573 , which enabled `-fsanitize=function` on all targets, where previously it hadn't been running on Arm at all. But I'd rather make it work than turn it off again! Repository:

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham updated this revision to Diff 525065. simon_tatham added a comment. (oops, forgot to clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 Files: clang/lib/CodeGen/CGExpr.cpp clan

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

cor3ntin added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); + }

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

krasimir added a comment. Thank you! That's a bug in the raw string format manager. This code effectively first looks for a matching top-level style, and if that's not found, then it tries to derive one via the RawFormat's BasedOnStyle: https://github.com/llvm/llvm-project/blob/main/clang/lib/For

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367458 , @wangleiat wrote: >> I think the paragraph means: >> >> class Empty {}; >> int test(Empty empty, int a); >> >> Then we should put `a` into `a1`, not `a0`. And we are indeed doing so. > > yes. with this pat

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367496 , @xry111 wrote: > In D151298#4367458 , @wangleiat > wrote: > >>> I think the paragraph means: >>> >>> class Empty {}; >>> int test(Empty empty, int a); >>> >>> Then

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); + }

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); + }

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. Great start but there are still some rough edges to polish! Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:19 #include "clang/ExtractAPI/API

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. >>> If we want to ignore empty structures, it is not enough to only modify >>> psABI, because the current implementations of gcc and clang do not ignore >>> empty structures in all cases. For example: >>> >>> struct { struct{}; int i; }; // in this case, the empty st

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367620 , @wangleiat wrote: If we want to ignore empty structures, it is not enough to only modify psABI, because the current implementations of gcc and clang do not ignore empty structures in all cases.

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 525079. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/D

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:194 + NoMovt = false; +assert(hasV6MOps() && "Cannot generate execute-only code for this target"); } tschuett wrote: > What happens in release mode? At the top you now claim

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 525082. vikramRH added a comment. Handled review comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/include/clang/Basic/TargetOptions

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham updated this revision to Diff 525084. simon_tatham added a comment. How embarrassing. _Really_ upload the clang-formatted version this time. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://review

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

peter.smith added a comment. This looks good to me. Will be worth waiting for a day to give the US time zone time to leave any comments. I note that this is also broken in -fsanitize=kcfi [*] (https://reviews.llvm.org/D135411) although fixing that is a separate patch. Would you be able to rais

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder updated this revision to Diff 525094. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp ==

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5380-5381 +Builder.CreatePtrToInt(CalleePtr, IntPtrTy); +llvm::Value *AlignedCalleeAddress = Builder.CreateAnd( +CalleeAddress, llvm::ConstantInt::get(IntPtrTy, -2)); +

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4352094 , @craig.topper wrote: >> Preventing the simplification means adding target specific code in >> instcombine which seems even worse than adding it here given as @dschuff >> pointed out, there's precedent with x

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xen0n added a comment. FYI, in the matching GCC patch discussion it was suggested that such a treatment wouldn't be necessary in principle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D151315: [clangd] Add a switch to specify a default clangd configuration file

voertler created this revision. voertler added reviewers: dgoldman, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. voertler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; While this patch is an improvement, I wonder we should move it further. Has been thinking about i

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

aaron.ballman added reviewers: efriedma, rjmccall. aaron.ballman added a comment. Adding codegen code owners as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151298/new/ https://reviews.llvm.org/D151298 _

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham updated this revision to Diff 525111. simon_tatham added a comment. Clarify mask construction as @michaelplatings suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 Files: clang/lib

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` and there's no guarantee that there's not an extra allocation involved as a result. However, I've not s

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder added a comment. In D151300#4367884 , @aaron.ballman wrote: > LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` > and there's no guarantee that there's not an extra allocation involved as a > result. However, I've not s

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

aaron.ballman added a comment. In D151300#4367939 , @tbaeder wrote: > In D151300#4367884 , @aaron.ballman > wrote: > >> LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` >> and there's n

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder added a comment. In D151300#4367943 , @aaron.ballman wrote: > In D151300#4367939 , @tbaeder wrote: > >> In D151300#4367884 , >> @aaron.ballman wrote: >> >>> LGTM

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill created this revision. Endill added reviewers: aaron.ballman, hfinkel, dblaikie. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces a `// expected-maybe-not-diagnostic` that sile

[PATCH] D151321: [clangd] Dont run raw-lexer for OOB source locations

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We can get stal

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. rjmccall wrote: > Suggested re

[clang] 456d072 - Reland: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

Author: Takuya Shimizu Date: 2023-05-24T21:31:25+09:00 New Revision: 456d072405d29ac731ad22fa1ec198b9f8265c4e URL: https://github.com/llvm/llvm-project/commit/456d072405d29ac731ad22fa1ec198b9f8265c4e DIFF: https://github.com/llvm/llvm-project/commit/456d072405d29ac731ad22fa1ec198b9f8265c4e.diff

[clang] 29dc47a - [clang][Sema] `-Wshadow` warns about shadowings by static local variables

Author: Takuya Shimizu Date: 2023-05-24T21:31:25+09:00 New Revision: 29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2 URL: https://github.com/llvm/llvm-project/commit/29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2 DIFF: https://github.com/llvm/llvm-project/commit/29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2.diff

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG456d072405d2: Reland: [clang][AST] Print name instead of type when diagnosing uninitialized… (authored by hazohelet). Repository: rG LLVM Github M

[PATCH] D151214: [clang][Sema] `-Wshadow` warns about shadowings by static local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG29dc47a9eeeb: [clang][Sema] `-Wshadow` warns about shadowings by static local variables (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D151214?vs=524709&id=525126#toc Reposi

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin added a comment. In D150528#4365688 , @aaron.ballman wrote: > In general, I think this is looking pretty good, thank you! I'll leave it to > @erichkeane to do the final sign-off as attributes code owner since this is > making a fair number of

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings accepted this revision. michaelplatings added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 ___ cfe-commits mailing list cf

[PATCH] D151286: [clang][Diagnostics][NFC] Don't create oversized CaretLine

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151286/new/ https://reviews.llvm.org/D151286

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1343 const ConstantArrayType *CAT = CGM.getContext().getAsConstantArrayType(T); +assert(CAT &&

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9182c679dde7: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&`… (authored by courbet). Repository: rG LLVM Github Mono

[clang-tools-extra] 9182c67 - [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

Author: Clement Courbet Date: 2023-05-24T15:05:39+02:00 New Revision: 9182c679dde7cb6480e66b9231a53d43ad03908b URL: https://github.com/llvm/llvm-project/commit/9182c679dde7cb6480e66b9231a53d43ad03908b DIFF: https://github.com/llvm/llvm-project/commit/9182c679dde7cb6480e66b9231a53d43ad03908b.dif

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Misc/diag-style.cpp:10 +// CHECK-NEXT: {{^}} | ^~~~{{$}} +// CHECK-NEXT: {{^}}5 | {{$}} +// CHECK-NEXT:

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonars

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

aaron.ballman added a comment. In D150528#4368023 , @yronglin wrote: > In D150528#4365688 , @aaron.ballman > wrote: > >> In general, I think this is looking pretty good, thank you! I'll leave it to >> @erichkean

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

aaron.ballman added a comment. The release note references documentation that doesn't exist, so Sphinx is failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/ https://reviews.

[clang-tools-extra] 62dc3ba - [clang-tidy]Fix rG9182c679dde7cb6480e66b9231a53d43ad03908b

Author: Clement Courbet Date: 2023-05-24T15:19:00+02:00 New Revision: 62dc3ba8442fa3f7003d46d2838307452a0391f4 URL: https://github.com/llvm/llvm-project/commit/62dc3ba8442fa3f7003d46d2838307452a0391f4 DIFF: https://github.com/llvm/llvm-project/commit/62dc3ba8442fa3f7003d46d2838307452a0391f4.dif

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

ronlieb added a comment. seeing this issue in our downstream builders: [2023-05-24T11:46:07.333Z] /opt/rocm-5.6.0-12074/llvm/lib/clang/17.0.0/include/cpuid.h:333:22: error: static declaration of '__cpuidex' follows non-static declaration [2023-05-24T11:46:07.333Z] static __inline void __cpuide

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

courbet added a comment. In D151092#4368151 , @aaron.ballman wrote: > The release note references documentation that doesn't exist, so Sphinx is > failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942 Sorry, fixed in rG62dc3ba8442f

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

aaron.ballman added a comment. In D151092#4368225 , @courbet wrote: > In D151092#4368151 , @aaron.ballman > wrote: > >> The release note references documentation that doesn't exist, so Sphinx is >> failing: http

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

CarolineConcatto updated this revision to Diff 525146. CarolineConcatto marked an inline comment as done. CarolineConcatto edited the summary of this revision. CarolineConcatto added a comment. -Address review's comments about Q target type. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang-tools-extra] 32ffc55 - [clang-tidy] Really fix rG9182c679dde7

Author: Clement Courbet Date: 2023-05-24T15:21:50+02:00 New Revision: 32ffc1feda4cf3eeec5740af5c5f386e584c URL: https://github.com/llvm/llvm-project/commit/32ffc1feda4cf3eeec5740af5c5f386e584c DIFF: https://github.com/llvm/llvm-project/commit/32ffc1feda4cf3eeec5740af5c5f386e584c.dif

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

steakhal added a comment. Please leave a link in the summary to the RFC to discuss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 ___ cfe-commits mailing list

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4352163 , @nikic wrote: > 1. Say that we prefer preserving rotates over "simplifying" funnel shifts > (ending up with the rot2 pattern). Basically by skipping the optimization at > https://github.com/llvm/llvm-project/

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4368238 , @pmatos wrote: > In D150670#4352163 , @nikic wrote: > >> 1. Say that we prefer preserving rotates over "simplifying" funnel shifts >> (ending up with the rot2 pattern)

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic added a comment. In D150670#4368241 , @pmatos wrote: > In D150670#4368238 , @pmatos wrote: > >> In D150670#4352163 , @nikic wrote: >> >>> 1. Say that we prefer prese

[clang] cde1390 - [clang][Sema] Fix a crash when instantiating a non-type template argument in a dependent scope.

Author: Sheng Date: 2023-05-24T21:46:31+08:00 New Revision: cde139016a4eb2d71950e135f9c037987ecdb7cf URL: https://github.com/llvm/llvm-project/commit/cde139016a4eb2d71950e135f9c037987ecdb7cf DIFF: https://github.com/llvm/llvm-project/commit/cde139016a4eb2d71950e135f9c037987ecdb7cf.diff LOG: [c

[PATCH] D151062: [clang][Sema] Fix a crash when instantiating a non-type template argument in a dependent scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcde139016a4e: [clang][Sema] Fix a crash when instantiating a non-type template argument in a… (authored by 0x59616e). Herald added a project: clang.

[clang] 77908ef - [clang][NFC] Add a blank line in ReleaseNotes.rst

Author: Sheng Date: 2023-05-24T22:02:41+08:00 New Revision: 77908efab4391e7d401480c6cec307a5c45f1cce URL: https://github.com/llvm/llvm-project/commit/77908efab4391e7d401480c6cec307a5c45f1cce DIFF: https://github.com/llvm/llvm-project/commit/77908efab4391e7d401480c6cec307a5c45f1cce.diff LOG: [c

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); } aaron.ballma

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 525165. john.brawn added a comment. Use -Eonly in test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/T

[PATCH] D151337: ARM: default to arm_aapcscc (or VFP) for embedded MachO targets.

t.p.northover created this revision. Herald added subscribers: kristof.beyls, mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added a project: clang. These were always intended to be AAPCS targets and LLVM does treat the usual C calling convention th

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 525174. hnrklssn added a comment. Herald added a subscriber: ormris. Overhauled how update_cc_tests.py checks globals It now: - no longer matches the literal names, like update_test_checks.py does unless --preserve-names (which doesn't seem to see much use

[PATCH] D151339: [OpenCL] Add cl_ext_image_raw10_raw12 extension

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the defines for the `cl_ext_image_

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > nikic wrote: > > hnrklssn wr

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. If you are really determined to do this, then OK. I'm in a very bad mood and I don't want to spend my mental strength on debating (esp. on a corner case unlikely to affect "real" code) anymore. But remember to add a entry in GCC 14 changes.html, and test this thing: stru

[PATCH] D146809: [clang-repl] Implement Value pretty printing

aaron.ballman added a comment. I didn't have the chance to complete my review (this is a pretty massive change), but here are some in-progress comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:105 + Parser &getParser() const; + const misma

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > nikic wrote: > > nikic wrote

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

muggenhor added a comment. FYI: I've added a set of tests. But in the process discovered there's at least one assumption that doesn't hold for boost::optional. So I'll have to adjust the implementation for that. That's a bit more involved change, so will take some time. (Specifically the assum

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

aaron.ballman added a comment. > This patch introduces a `// expected-maybe-not-diagnostic` that silence typo in the summary, it introduces `// expected-maybe-no-diagnostics` To save other reviewers some clicking around, the reason why this is being proposed is because we want to use the `split

[PATCH] D150966: [clang] Don't define predefined macros multiple times

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Preprocessor/predefined-macros-no-warnings.c:5 +// warnings suppressed by default. +// RUN: %clang_cc1 %s -E -o /dev/null -Wsystem-h

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adjust the template pparameter depth when parsing default template arguments as they may introduce generic lambda whose pa

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: glandium, hans, thakis. Herald added subscribers: libc-commits, bviyer, ekilmer, Moerafaat, zero9178, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 525216. Endill added a comment. Add missing comma after enum item Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files: clang/include/clang/Frontend/VerifyDiagnosti

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill marked an inline comment as done. Endill added a comment. Thank for for providing a nice explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 ___

[clang] 78bf8a0 - [clang] Don't define predefined macros multiple times

Author: John Brawn Date: 2023-05-24T17:28:41+01:00 New Revision: 78bf8a0a2212c1826ce2a9c0f98c73e9b9b16367 URL: https://github.com/llvm/llvm-project/commit/78bf8a0a2212c1826ce2a9c0f98c73e9b9b16367 DIFF: https://github.com/llvm/llvm-project/commit/78bf8a0a2212c1826ce2a9c0f98c73e9b9b16367.diff LO

[PATCH] D150966: [clang] Don't define predefined macros multiple times

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78bf8a0a2212: [clang] Don't define predefined macros multiple times (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 525224. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin marked 2 inline comments as done. yronglin added a comment. Thanks, maybe I can do these trivially change in separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 __

  1   2   3   >