michaelplatings added inline comments.

================
Comment at: clang/lib/CodeGen/CGExpr.cpp:5380-5381
+            Builder.CreatePtrToInt(CalleePtr, IntPtrTy);
+        llvm::Value *AlignedCalleeAddress = Builder.CreateAnd(
+            CalleeAddress, llvm::ConstantInt::get(IntPtrTy, -2));
+        AlignedCalleePtr =
----------------
I think this line could be more readable. I suggest defining Mask separately 
and using `~1` instead of `-2`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151308/new/

https://reviews.llvm.org/D151308

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to