muggenhor added a comment.

FYI: I've added a set of tests. But in the process discovered there's at least 
one assumption that doesn't hold for boost::optional. So I'll have to adjust 
the implementation for that. That's a bit more involved change, so will take 
some time.

(Specifically the assumption is that converting constructors/assignment 
operators are templates themselves: `assert(F.getTemplateSpecializationArgs() 
!= nullptr);` in `valueOrConversionHasValue`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151192/new/

https://reviews.llvm.org/D151192

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to