[clang] d9e7173 - [clang][dataflow] Associate `FunctionToPointerDecay` nodes with a value.

Author: Martin Braenne Date: 2023-04-18T07:15:29Z New Revision: d9e717338f8042664177250315364094262c7073 URL: https://github.com/llvm/llvm-project/commit/d9e717338f8042664177250315364094262c7073 DIFF: https://github.com/llvm/llvm-project/commit/d9e717338f8042664177250315364094262c7073.diff LOG

[PATCH] D148006: [clang][dataflow] Associate `FunctionToPointerDecay` nodes with a value.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9e717338f80: [clang][dataflow] Associate `FunctionToPointerDecay` nodes with a value. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

Stoorx added a comment. That's my first commit into LLVM project. (Almost just for test of the contribution procedure.) Maybe I did something wrong, but the build fails on example tests. I wonder, whether this review request will be actually reviewed despite the failed condition? And maybe som

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:15-16 + +// The Arena owns the objects that model data within an analysis. +// Currently this is mostly Values and StorageLocations. +class Arena { gribozavr2 wrote: >

[PATCH] D148552: [include-cleaner] Unify behaviour for static & instance members

kadircet updated this revision to Diff 514546. kadircet marked 2 inline comments as done. kadircet added a comment. - Adress review comments - Handle Qualifier being null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148552/new/ https://reviews.llv

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2332 + + #if __RISCV_RVV_VLEN_BITS==512 + typedef vint8m1_t fixed_vint8m1_t __attribute__((riscv_rvv_vector_bits(512))); rjmccall wrote: > This probably needs a `defined(__RI

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4276099 , @rjmccall wrote: > The CodeGen change looks fine. I'm surprised you didn't need any code in > argument/parameter/call/return emission to do the actual fixed<->scalable > coercion; do we already have th

[PATCH] D148552: [include-cleaner] Unify behaviour for static & instance members

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc5fb7a79b58: [include-cleaner] Unify behaviour for static & instance members (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148552/ne

[clang-tools-extra] cc5fb7a - [include-cleaner] Unify behaviour for static & instance members

Author: Kadir Cetinkaya Date: 2023-04-18T10:01:31+02:00 New Revision: cc5fb7a79b58d7e6509b74e1935850e3307bbdc7 URL: https://github.com/llvm/llvm-project/commit/cc5fb7a79b58d7e6509b74e1935850e3307bbdc7 DIFF: https://github.com/llvm/llvm-project/commit/cc5fb7a79b58d7e6509b74e1935850e3307bbdc7.dif

[clang] f98ca36 - [RISCV] Modify arch string parsing order according to latest riscv spec

Author: Jun Sha (Joshua) Date: 2023-04-18T16:20:08+08:00 New Revision: f98ca363bed7405a23ad4b77167e39505a1ca9dd URL: https://github.com/llvm/llvm-project/commit/f98ca363bed7405a23ad4b77167e39505a1ca9dd DIFF: https://github.com/llvm/llvm-project/commit/f98ca363bed7405a23ad4b77167e39505a1ca9dd.di

[PATCH] D148315: [RISCV] Modify arch string parsing order according to latest riscv spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf98ca363bed7: [RISCV] Modify arch string parsing order according to latest riscv spec (authored by joshua-arch1). Herald added a project: clang. Hera

[PATCH] D148612: [clang][dataflow] Use existing accessors to check for copy and move assignment ops.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D148614: [clang][Interp] Add frame depth checking

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was already //some// form of this, but it was

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +std::optional +firstMatchedProvider(const include_cleaner::Includes &Includes, + llvm::ArrayRef Providers); VitaNuo wrote: > kadircet wrote: > > can you

[PATCH] D148596: [KMSAN] Enable on SystemZ

glider added a comment. Do you have a working kernel patch for SystemZ? I think we'd better name the functions taking the extra parameter differently - maybe at some point we'll even want them to coexist on certain architectures. Anyway, it might just look cleaner in the kernel code.

[PATCH] D148315: [RISCV] Modify arch string parsing order according to latest riscv spec

asb added a comment. @joshua-arch1: I've posted D146815 to fix the canonical ordering and directly committed rGa35e67fc5be654a7efdfa6125343b90f8960a487 to add some test coverage. Reposito

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

DavidSpickett added a comment. > That's my first commit into LLVM project. (Almost just for test of the > contribution procedure.) Welcome! > Maybe I did something wrong, but the build fails on example tests. Do the tests fail locally? I will look at the pre-commit logs as well. It may be fai

[clang] efae695 - Add -f[no-]loop-versioning option

Author: Mats Petersson Date: 2023-04-18T09:47:54+01:00 New Revision: efae695d52ccc987ddd3eb042eeb11f06cb2383b URL: https://github.com/llvm/llvm-project/commit/efae695d52ccc987ddd3eb042eeb11f06cb2383b DIFF: https://github.com/llvm/llvm-project/commit/efae695d52ccc987ddd3eb042eeb11f06cb2383b.diff

[PATCH] D141307: Add -f[no-]loop-versioning option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefae695d52cc: Add -f[no-]loop-versioning option (authored by MatsPetersson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii added a comment. The kernel patch is currently WIP; I'm trying to get rid of false positives. Just some examples of the findings so far: - s390x always uses separate address spaces for kernel and userspace, so we need to skip the `addr < TASK_SIZE` check in `is_bad_asm_addr()`. - There is a

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

Stoorx added a comment. Yes, it fails locally even for clean repository. I mean, just cloned main branch and tested immediately without any changes. I have found another review, which has the same tests failed. https://reviews.llvm.org/D148546 Moreover, you (@DavidSpickett) have already commen

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

DavidSpickett added a comment. I'd suggest rewording the title a bit: `[clang] Return std::unique_ptr from AllocateTarget` Titles are always weird but at least including the function name means someone staring at a build failure can skim for likely commits. It's not always possible though. Sa

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder updated this revision to Diff 514572. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Desc

[clang] 799b794 - [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

Author: mydeveloperday Date: 2023-04-18T10:17:28+01:00 New Revision: 799b794d7699bc7ecf07d8d588e125edb3967507 URL: https://github.com/llvm/llvm-project/commit/799b794d7699bc7ecf07d8d588e125edb3967507 DIFF: https://github.com/llvm/llvm-project/commit/799b794d7699bc7ecf07d8d588e125edb3967507.diff

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG799b794d7699: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable (authored by MyDeveloperDay). Changed prior to commit: h

[PATCH] D148574: [clang] Return std::unique_ptr from AllocateTarget

Stoorx added a comment. > Do you have commit access? No, I don't. And, according to the Policy (as I understood), someone with the commit access have to commit my changes prior I can request the access too. > If you want I can land this for you, I need a name and email address to use > for the

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

ilya-biryukov updated this revision to Diff 514579. ilya-biryukov added a comment. - clang-format the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148515/new/ https://reviews.llvm.org/D148515 Files: clang/lib/AST/Decl.cpp clang/test/Modu

[PATCH] D148596: [KMSAN] Enable on SystemZ

glider added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:118 ///(X=1,2,4,8) are accessed through pointers obtained via the /// __msan_metadata_ptr_for_load_X(ptr) /// __msan_metadata_ptr_for_store_X(ptr) i

[PATCH] D148574: [clang] Return std::unique_ptr from AllocateTarget

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > Or should I provide a real name? Username is fine as long as you're fine being credited as such. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D148574: [clang] Return std::unique_ptr from AllocateTarget

Stoorx added a comment. > Username is fine as long as you're fine being credited as such. Absolutely. What should I do further? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148574/new/ https://reviews.llvm.org/D148574 __

[clang] 830b359 - [clang] Return std::unique_ptr from AllocateTarget

Author: Stoorx Date: 2023-04-18T10:07:26Z New Revision: 830b359d3ab1f96875582bf687f4542df0d3527a URL: https://github.com/llvm/llvm-project/commit/830b359d3ab1f96875582bf687f4542df0d3527a DIFF: https://github.com/llvm/llvm-project/commit/830b359d3ab1f96875582bf687f4542df0d3527a.diff LOG: [clang

[PATCH] D148574: [clang] Return std::unique_ptr from AllocateTarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG830b359d3ab1: [clang] Return std::unique_ptr from AllocateTarget (authored by Stoorx, committed by DavidSpickett). Repository: rG LLV

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514586. MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added a comment. Address review comments, still would like to solve the indenting issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.or

[PATCH] D148574: [clang] Return std::unique_ptr from AllocateTarget

DavidSpickett added a comment. You may get some emails about build failures. Try to judge if they are relevant to you, ask here if you are not sure. I doubt it will do much given that it's just refactoring and both uses seem to be GPU offload targets. Repository: rG LLVM Github Monorepo CH

[clang] ccf7191 - [Modules] Do not rewrite existing decls when deserializing class fields

Author: Ilya Biryukov Date: 2023-04-18T12:40:39+02:00 New Revision: ccf7191719375cac15da5a3eb406e1efa602b096 URL: https://github.com/llvm/llvm-project/commit/ccf7191719375cac15da5a3eb406e1efa602b096 DIFF: https://github.com/llvm/llvm-project/commit/ccf7191719375cac15da5a3eb406e1efa602b096.diff

[clang] 67b298f - Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter

Author: Ilya Biryukov Date: 2023-04-18T12:40:39+02:00 New Revision: 67b298f6d82e0b4bb648ac0dabe895e816a77ef1 URL: https://github.com/llvm/llvm-project/commit/67b298f6d82e0b4bb648ac0dabe895e816a77ef1 DIFF: https://github.com/llvm/llvm-project/commit/67b298f6d82e0b4bb648ac0dabe895e816a77ef1.diff

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccf719171937: [Modules] Do not rewrite existing decls when deserializing class fields (authored by ilya-biryukov). Repository: rG LLVM Github Mono

[PATCH] D148574: [clang] Return std::unique_ptr from AllocateTarget

DavidSpickett added a comment. > What should I do further? And contribute more if you like :) Thanks for the contribution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148574/new/ https://reviews.llvm.org/D148574 ___

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon added a comment. Just a small ping to keep this patch on peoples radar and to try and get some reviewer attention (I am aware you're all quite busy, so thank you very much for any time you can spare) for more review feedback to push this patch further along the pipeline! Repository:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. Tested on AMDGPU (gfx90a) -- OpenMP tools dir in libomptarget: /home/janplehr/git/trunk17.0/build/llvm-project/runtimes/runtimes-bins/openmp/runtime/src -- LIBOMPTARGET: Building offloading runtime library libomptarget. -- LIBOMPTARGET: Not building aarch64 offloadi

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

sammccall updated this revision to Diff 514602. sammccall added a comment. Tweak comment Drop flow-condition substitution instead of moving into Arena, it's dead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148554/new/ https://reviews.llvm.org/D1

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:15-16 + +// The Arena owns the objects that model data within an analysis. +// Currently this is mostly Values and StorageLocations. +class Arena { mboehme wrote: > gr

[libunwind] 1ae57fe - [libunwind] Remove the legacy Unwind_AppleExtras.cpp

Author: Louis Dionne Date: 2023-04-18T12:03:06Z New Revision: 1ae57fed8806886238b7603f6b3b54350da83f0e URL: https://github.com/llvm/llvm-project/commit/1ae57fed8806886238b7603f6b3b54350da83f0e DIFF: https://github.com/llvm/llvm-project/commit/1ae57fed8806886238b7603f6b3b54350da83f0e.diff LOG:

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. need to handle `init;` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:91-97 + /// Returns a boolean value as a result of substituting `Val` and its sub + /// values based on entries in `SubstitutionsCache`. Intermediate resu

[clang] 1e4891e - [clang-repl] Enable debugging of JIT-ed code.

Author: Vassil Vassilev Date: 2023-04-18T13:19:42Z New Revision: 1e4891e681c51f3e2a724b4ac4e42380ec4a9be1 URL: https://github.com/llvm/llvm-project/commit/1e4891e681c51f3e2a724b4ac4e42380ec4a9be1 DIFF: https://github.com/llvm/llvm-project/commit/1e4891e681c51f3e2a724b4ac4e42380ec4a9be1.diff LO

[PATCH] D148481: [clang-repl] Enable debugging of JIT-ed code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4891e681c5: [clang-repl] Enable debugging of JIT-ed code. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D148573: Port -fsanitize=function to AArch64

peter.smith added a comment. As it stands I think this may have problems with -mbranch-protection. In that case we'll need a `BTI c` to be the target of the indirect branch. I'm guessing something like: _Z3funv BTI C ; In hint space B . + 8 .word .L__llvm_rtti_proxy-_Z3funv Otherwise

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

kadircet added a comment. Hi folks! We have a setup in which clang (more specifically clang-tools) is always built from a version close to HEAD and libcxx is fetched from user's checkout of the codebase (which can lag behind HEAD for ~a month). So the 1 week gap between https://github.com/llvm

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D148573: Port -fsanitize=function to AArch64

peter.smith added a comment. One other small thing. The docs page https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html would need the supported architectures updating: -fsanitize=function: Indirect call of a function through a function pointer of the wrong type (Darwin/Linux, C++ and

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added a comment. In D141824#4274461 , @argentite wrote: > We should probably also address the lack of linker issue as well. Should we > go for a precompiled dynamic library file? There seems to be some "precedent" > of this in other tests. Ye

[clang] e64fbf2 - Revert "[clang-repl] Enable debugging of JIT-ed code."

Author: Vassil Vassilev Date: 2023-04-18T13:41:38Z New Revision: e64fbf2cca8c4763a058ba59a48ab8e4b8193028 URL: https://github.com/llvm/llvm-project/commit/e64fbf2cca8c4763a058ba59a48ab8e4b8193028 DIFF: https://github.com/llvm/llvm-project/commit/e64fbf2cca8c4763a058ba59a48ab8e4b8193028.diff LO

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added a comment. This subject haunted us for quite some time now, and there is more behind what it seems at first. If I'm not mistaken, this patch is pretty much what is in D86874 except that it doesn't give up and still checks the upper-bound in this

[PATCH] D148583: [clang-scan-deps] Add clang-scan-deps to llvm-driver build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2423a334585: [clang-scan-deps] Add clang-scan-deps to llvm-driver build (authored by abrachet). Herald added a project: clang. Herald added a subscr

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna created this revision. Manna added reviewers: tahonermann, aaron.ballman. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, kristof.beyls. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

shafik added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:426 +return IndexCtx.handleReference(FD, D.getFieldLoc(), Parent, +ParentDC, SymbolRoleSet(), {}, E); + } nit Repository:

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; -

[clang] 0905c56 - [Headers][doc] Add FMA intrinsic descriptions

Author: Paul Robinson Date: 2023-04-18T09:31:09-07:00 New Revision: 0905c567f0c7328780c727b470a92cda1ee54697 URL: https://github.com/llvm/llvm-project/commit/0905c567f0c7328780c727b470a92cda1ee54697 DIFF: https://github.com/llvm/llvm-project/commit/0905c567f0c7328780c727b470a92cda1ee54697.diff

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0905c567f0c7: [Headers][doc] Add FMA intrinsic descriptions (authored by probinson). Herald added a project: clang. Changed prior to commit: https

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added a comment. I chose to leave the "for each element" cases as-is, but I will keep your comments in mind as I go through other intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148021/new/ https://reviews.llvm.org/D148021 ___

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

StrangeRanger added a comment. In D148467#4272231 , @MyDeveloperDay wrote: > for default `set;get` or `get;set` for when `AfterCSharpProperty` is true, > > public Foo { > set; > get; > } At least from my experience, the getter is specifi

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. >> public Foo { >> set; >> get; >> } > > At least from my experience, the getter is specified before the setter, > though I'm unsure how important this is in your eyes. Lets hold off the idea of swapping `set;get` around from this patch, but this

[clang] 8d2e9fc - [PowerPC] Add function pointer alignment to DataLayout

Author: David Tenty Date: 2023-04-18T13:00:27-04:00 New Revision: 8d2e9fc8553c91b1f22e82ffc2c00020f40bb0a2 URL: https://github.com/llvm/llvm-project/commit/8d2e9fc8553c91b1f22e82ffc2c00020f40bb0a2 DIFF: https://github.com/llvm/llvm-project/commit/8d2e9fc8553c91b1f22e82ffc2c00020f40bb0a2.diff L

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2e9fc8553c: [PowerPC] Add function pointer alignment to DataLayout (authored by daltenty). Herald added a project: clang. Herald added a subscriber

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. @xazax.hun do you still want to look at this again? I'm itching a little to get some use out of it :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 __

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

xazax.hun accepted this revision. xazax.hun added a comment. I am a bit overloaded at the moment, feel free to commit. I can still add comments later that could be addressed in a follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514682. MyDeveloperDay added a comment. add init support and fix indentation issue when only one property is defined but the is an auto-property CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 File

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514684. MyDeveloperDay added a comment. upload the correct patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[clang] 790c9ac - [ClangFE] Handle statement expressions properly with CheckAtomicAlignment().

Author: Jonas Paulsson Date: 2023-04-18T19:33:32+02:00 New Revision: 790c9ac529c9ad0d7e89e3de2041d85cfc411b40 URL: https://github.com/llvm/llvm-project/commit/790c9ac529c9ad0d7e89e3de2041d85cfc411b40 DIFF: https://github.com/llvm/llvm-project/commit/790c9ac529c9ad0d7e89e3de2041d85cfc411b40.diff

[PATCH] D148422: [ClangFE] Handle statement expressions properly with CheckAtomicAlignment()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG790c9ac529c9: [ClangFE] Handle statement expressions properly with CheckAtomicAlignment(). (authored by jonpa). Herald added a project: clang. Herald

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

StrangeRanger added a comment. In D148467#4277960 , @MyDeveloperDay wrote: > I'm trying to decide if I put that option in this change or in a separate > change (thoughts @HazardyKnusperkeks, @owenpan ) I'm not too privy to your workflow, but if by "in

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 514692. iii added a comment. - Better explain the ABI situation. - Extend the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://reviews.llvm.org/D148596 Files: clang/lib/Driver/ToolChains/L

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

ymandel accepted this revision. ymandel added a comment. Love it! Thanks. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:129 +} // namespace clang::dataflow \ No newline at end of file add newline? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514699. fahadnayyar added a comment. Fixing some more regression test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang-tools-extra/test/cla

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

samitolvanen marked 9 inline comments as done. samitolvanen added a comment. In D148385#4275617 , @jrtc27 wrote: > I can't help but feel the core of this should be target-independent, with TLI > or similar hooks to actually do the target-specific bits?

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 514702. chaitanyav added a comment. Update release notes about the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang

[clang] 310ee08 - Reland "[clang-repl] Enable debugging of JIT-ed code."

Author: Vassil Vassilev Date: 2023-04-18T18:33:52Z New Revision: 310ee08d5d45d9388333842a79bf4cef761afddf URL: https://github.com/llvm/llvm-project/commit/310ee08d5d45d9388333842a79bf4cef761afddf DIFF: https://github.com/llvm/llvm-project/commit/310ee08d5d45d9388333842a79bf4cef761afddf.diff LO

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

rjmccall added a comment. > You mean RISC-V specific code or generic code? If generic, I assume we got it > from SVE's earlier implementation. Ah, if SVE has a similar feature then that makes sense. Comment at: clang/include/clang/Basic/AttrDocs.td:2332 + + #if __RISCV_RVV_V

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

samitolvanen updated this revision to Diff 514708. samitolvanen added a comment. Addressed most of the feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148385/new/ https://reviews.llvm.org/D148385 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

aaron.ballman added inline comments. Comment at: clang/test/Sema/parentheses.cpp:34 public: - operator int(); + operator bool(); Stream &operator<<(int); aaron.ballman wrote: > Is this change necessary? Alternatively, can we add this as an overload > inste

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added a comment. In D148467#4277960 , @MyDeveloperDay wrote: >>> public Foo { >>> set; >>> get; >>> } >> >> At least from my experience, the getter is specified before the setter, >> though I'm unsure how important thi

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

aaron.ballman added a comment. Thanks for the static analysis fixes, however, it looks like quite a few of them were false positives again. When fixing any static analysis diagnostics, please put in the effort to determine whether it's actually correct or not, as it seem the Coverity diagnostic

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} aaron.ballman wrote: > NFC but matches our style guide. > > One thing to consi

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

dblaikie added a comment. In D146595#4235340 , @augusto2112 wrote: > In D146595#4235333 , @aprantl wrote: > >> I hope I'm not kicking off a long bike-shedding thread, but I would propose >> to either call the at

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148653 Files: clang/lib/Headers/mwaitxintrin.h clang/lib/Headers/pmmintrin.h Index:

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. @aaron.ballman am looking into this. If i change it back to `operation int();` and add `Stream& operator<<(bool)` I get ` - error: 'warning' diagnostics expected but not seen: File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein added a comment. Alright, cool, thanks! I'll land it tomorrow evening if there are no objections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing li

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

thurston added a comment. This is causing buildbot failures e.g., https://lab.llvm.org/buildbot/#/builders/5/builds/33084: TEST 'lld :: ELF/lto/ppc.ll' FAILED ... ld.lld: /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/MachineFu

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

thurston added a comment. Ah, I just noticed you had a follow-up commit (https://reviews.llvm.org/rG0236564771b432ebf050144eda4ef4b7424db8c3). I'm re-running the tests/build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147016/new/ https://revie

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 514730. void marked an inline comment as done. void added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files: clang-tools-extra/clangd/FindT

[clang-tools-extra] b51a03e - [Clang][NFC] Rename methods/vars to reflect their real usage

Author: Bill Wendling Date: 2023-04-18T13:48:08-07:00 New Revision: b51a03e1bbe7ea8868ffb24472fc532d0c00943c URL: https://github.com/llvm/llvm-project/commit/b51a03e1bbe7ea8868ffb24472fc532d0c00943c DIFF: https://github.com/llvm/llvm-project/commit/b51a03e1bbe7ea8868ffb24472fc532d0c00943c.diff

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx created this revision. Stoorx added a reviewer: DavidSpickett. Stoorx added a project: clang. Herald added a project: All. Stoorx requested review of this revision. In file `clang/lib/Basic/Module.cpp` the `Module` class had `submodule_begin()` and `submodule_end()` functions to retrieve c

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

goldstein.w.n added a comment. LGTM. I'm not a maintainer to please wait a day or so to push so that others can review. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the process

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Note that I think we should consider renaming the `-format` flag in the future. Ideally, it should reflect the fact that the scanner is doing different work, not just formatt

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

tahonermann added a comment. After seeing this review, I filed a support case with Synopsys with a request to stop reporting `AUTO_CAUSES_COPY` issues for small objects of class types, at least in the absence of additional evidence that a reference would be preferred. Commen

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 514744. Stoorx added a comment. Fix unchanged usage of old functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang/include/clang/Basic/Module.h cla

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 514746. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - rebase, invert inlining reporting chain, update diagnostic text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

  1   2   >