DavidSpickett added a comment. > That's my first commit into LLVM project. (Almost just for test of the > contribution procedure.)
Welcome! > Maybe I did something wrong, but the build fails on example tests. Do the tests fail locally? I will look at the pre-commit logs as well. It may be failures that were fixed already and this change needs to be rebased to include that. > I wonder, whether this review request will be actually reviewed despite the > failed condition? And maybe someone can provide some (simple) > tutorials/guides how to contribute here in more correct way. Yes, absolutely review isn't just about criticising code it's about solving problems. The intent of this change is great (down with raw pointers) and at first glance I don't think it should cause any failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148574/new/ https://reviews.llvm.org/D148574 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
