DavidSpickett added a comment.
I'd suggest rewording the title a bit: `[clang] Return
std::unique_ptr<TargetInfo> from AllocateTarget`
Titles are always weird but at least including the function name means someone
staring at a build failure can skim for likely commits. It's not always
possible though.
Same results for me without this change:
Failed Tests (6):
LLVM :: Examples/OrcV2Examples/lljit-with-remote-debugging.test
LLVM :: Examples/OrcV2Examples/lljit-with-thinlto-summaries.test
LLVM :: Examples/OrcV2Examples/orcv2-cbindings-add-object-file.test
LLVM :: Examples/OrcV2Examples/orcv2-cbindings-basic-usage.test
LLVM :: Examples/OrcV2Examples/orcv2-cbindings-lazy.test
LLVM :: Examples/OrcV2Examples/orcv2-cbindings-removable-code.test
The examples are not built by default you have to give `LLVM_BUILD_EXAMPLES=ON`
to CMake.
It's not your problem to fix those, this patch doesn't cause them so it's fine
to go in as is.
Do you have commit access?
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
If you want I can land this for you, I need a name and email address to use for
the commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148574/new/
https://reviews.llvm.org/D148574
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
