[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added subscribers: sammccall, klimek. MyDeveloperDay added a comment. In D147176#4231952 , @rymiel wrote: >> didn't go via the normal clang-format reviewers > > Is there a reason for this? This isn't the only case either, for example: > htt

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added a comment. Looks ok, would be good to run this on some code base. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:22 + cxxMethodDecl(anyOf(cxxConstructorDecl(isMoveConstructor()), + hasOverloade

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. I can auto add us as all as reviewers if you'd like? This means if the title contains `[clang-format]` or it impacts a file path of /clang/lib/Format it should in theory run this rule F26945275: image.png Repository: rG L

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + : Style.D

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. Also I've added a couple of other rules F26945535: image.png This should in theory, automatically add a comment to a clang-format review that contains a Format.h change but not a ClangFormatStyleOption.rst change and vice ve

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli created this revision. fpetrogalli added a reviewer: mizvekov. Herald added a project: All. fpetrogalli requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful for retriving crash reports of LIT runs when the temporary fo

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. ...test comment which should fire an automated, you don't have any unit tests...comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/ https://reviews.llvm.org/D147176 __

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

klimek added a comment. I apologize for not tagging appropriately - is that process documented somewhere? Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes hav

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

klimek added a comment. And thanks a lot for cleaning up, really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/ https://reviews.llvm.org/D147176 ___ cfe-commits mailing list cfe

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509580. Fznamznon added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/FrontendActions.h clang/lib/Front

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 509581. jplehr added a comment. Fix bug to corectly support the maximally supported dimensions as required by the spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 509583. jplehr added a comment. Removed accidentally added code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/libomptarget/include/interop.h openmp

[PATCH] D147197: [llvm-docs] Added documentation for the 'neg' operation

samtebbs added a comment. Thank you oyalesalami. It looks like these instructions don't actually exist anymore so shouldn't be documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147197/new/ https://reviews.llvm.org/D147197

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon added a comment. The test fail is unrelated, seem to be broken by https://reviews.llvm.org/D146811 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 509589. Krishna-13-cyber edited the summary of this revision. Krishna-13-cyber added a comment. This patch aims to remove some redundant cases of static assert messages where the expansions are particularly unhelpful. In this particular patch, we hav

[clang-tools-extra] f3a815a - [clangd] Map references from include'd files to directives

Author: Kadir Cetinkaya Date: 2023-03-30T12:06:22+02:00 New Revision: f3a815aa776f42c4f4b80fc8d19a69ff1b359906 URL: https://github.com/llvm/llvm-project/commit/f3a815aa776f42c4f4b80fc8d19a69ff1b359906 DIFF: https://github.com/llvm/llvm-project/commit/f3a815aa776f42c4f4b80fc8d19a69ff1b359906.dif

[PATCH] D147139: [clangd] Map references from include'd files to directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a815aa776f: [clangd] Map references from include'd files to directives (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147139/new/ h

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

kekcheburec added a comment. In D70401#4226597 , @pcwang-thead wrote: > In D70401#4226549 , @recallmenot > wrote: > >> In D70401#4205333 , @pcwang-thead >> wrote: >> >>> I

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. In D147176#4232808 , @klimek wrote: > I apologize for not tagging appropriately - is that process documented > somewhere? I've implemented it via Phabricator Herald rules now, so we should be good going forward, @klimek

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. I don't like using additional variables in unit tests, if someone changes 25400 multiple tests could break, each test should be stand alone in my view Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to Clan

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. Can you show your example from a implementation case and not just a declaration i.e. what happens with `int function1(int param1) {}` Comment at: clang/lib/Format/TokenAnnotator.cpp:4789 + if (Left.is(tok::l_paren) && Style.AlwaysBreakBeforeFu

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1374 +**AlwaysBreakBeforeFunctionParameters** (``Boolean``) :versionbadge:`clang-format 16.0` :ref:`¶ ` + If ``true``, always break before function parameters in a declaration. + --

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 509598. philnik added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42ae055b4c92: [NFC] Fix potential for use-after-free in DumpModuleInfoAction (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES

[clang] 42ae055 - [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Author: Mariya Podchishchaeva Date: 2023-03-30T06:44:23-04:00 New Revision: 42ae055b4c9282050636dd11198cad500424adf2 URL: https://github.com/llvm/llvm-project/commit/42ae055b4c9282050636dd11198cad500424adf2 DIFF: https://github.com/llvm/llvm-project/commit/42ae055b4c9282050636dd11198cad500424ad

[PATCH] D147213: [include-cleaner] Ignore builtin symbols in the WalkAST.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. There is no need to add headers for builtin symbols. Additionally, there is a bonus benefit which help eliminate some

[libunwind] ed61d6a - [libc++] Use the stdlib= Lit feature instead of use_system_cxx_lib

Author: Louis Dionne Date: 2023-03-30T06:57:56-04:00 New Revision: ed61d6a46611cfb144b260e0dd0fb1b5783562d9 URL: https://github.com/llvm/llvm-project/commit/ed61d6a46611cfb144b260e0dd0fb1b5783562d9 DIFF: https://github.com/llvm/llvm-project/commit/ed61d6a46611cfb144b260e0dd0fb1b5783562d9.diff

[clang] 243b355 - [clang][Interp] Support destructors

Author: Timm Bäder Date: 2023-03-30T13:17:04+02:00 New Revision: 243b355ee0f063cff4988f061215839020c2175b URL: https://github.com/llvm/llvm-project/commit/243b355ee0f063cff4988f061215839020c2175b DIFF: https://github.com/llvm/llvm-project/commit/243b355ee0f063cff4988f061215839020c2175b.diff LO

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG243b355ee0f0: [clang][Interp] Support destructors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D145545?vs=509281&id=50

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, agozillon. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-

[PATCH] D147121: [hwasan] remove requirment for PIE

Enna1 updated this revision to Diff 509611. Enna1 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147121/new/ https://reviews.llvm.org/D147121 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/sanitizer-ld.c I

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a subscriber: anakryiko. > eddyz87 added a comment. > > In D143967#4231746 , @jemarch wrote: > >>> eddyz87 added a comment. >>> ... >>> If we consider type tag a qualifier, conceptually it would be simpler >>> if ordering would not matter f

[PATCH] D147213: [include-cleaner] Ignore builtin symbols in the WalkAST.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83546221af43: [include-cleaner] Ignore builtin symbols in the WalkAST. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang-tools-extra] 8354622 - [include-cleaner] Ignore builtin symbols in the WalkAST.

Author: Haojian Wu Date: 2023-03-30T13:46:41+02:00 New Revision: 83546221af43ca347f8e1b1197a9df54810244e0 URL: https://github.com/llvm/llvm-project/commit/83546221af43ca347f8e1b1197a9df54810244e0 DIFF: https://github.com/llvm/llvm-project/commit/83546221af43ca347f8e1b1197a9df54810244e0.diff LO

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

carlosgalvezp added a comment. Herald added a project: clang-format. In D121584#3404704 , @curdeius wrote: > Yes, let's revert this. I should have a fix soon though. @curdeius Did you manage to find a fix suitable for both use cases? Repository: rG L

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:262 + + static_assert(invert(true) || invert(true), ""); // expected-error {{failed}} + +1 -- please spell out more of the diagnostic wording (I see you're following a pattern

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1338 + +auto ReferencedInclude = convertIncludes(SM, Inc); +include_cleaner::walkUsed( can we put the rest into a separate function (I know this function is already quite long

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon updated this revision to Diff 509626. agozillon added a comment. - [Flang][Driver][Test] Move flang-omp.f90 tests into omp-frontend-forwarding.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145264/new/ https://reviews.llvm.org/D145264

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon updated this revision to Diff 509628. agozillon added a comment. - [Flang][Driver][Test] Move flang-omp.f90 tests into omp-frontend-forwarding.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145264/new/ https://reviews.llvm.org/D145264

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon added a comment. Recent update(s) moved flag/driver testing of the flags from Clang to Flang's omp-frontend-forwarding.f90 aligning it with previous tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145264/new/ https://reviews.llvm.or

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. because of https://github.com/llvm/llvm-project/issues/61785 should this really be reverted? is basically saying `X * Y {` must be `X *Y{` but that obviously not the case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D144862: Implement code lense for used symbols.

VitaNuo updated this revision to Diff 509633. VitaNuo added a comment. Use custom command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-too

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 509632. Krishna-13-cyber added a comment. Herald added subscribers: llvm-commits, kadircet, arphaman. Herald added a project: LLVM. - Updated patch - Added testcases for chained operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D144862: Implement code lense for used symbols.

VitaNuo updated this revision to Diff 509636. VitaNuo added a comment. Improve argument handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cl

[PATCH] D147227: [clangd] Support Config in TestTU.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Add a config as a filed in TestT

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. Unfortunately I do not believe an mlir-translate test that tests if the OffloadModuleInterface is accessible when directly utilizing mlir-translate is possible for this patch... I forgot I removed the is device check as it is already done at the initial creation of th

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

awarzynski added a comment. The driver plumbing looks good to me. I will defer reviewing the OpenMP changes to experts. Thanks for working on this! Comment at: clang/include/clang/Driver/Options.td:2692 def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-a

[clang] 18fe663 - Correct deferred concepts with NTTP placeholder constraints

Author: Erich Keane Date: 2023-03-30T06:15:02-07:00 New Revision: 18fe66396906178872dd933a39e38779a5a3c722 URL: https://github.com/llvm/llvm-project/commit/18fe66396906178872dd933a39e38779a5a3c722 DIFF: https://github.com/llvm/llvm-project/commit/18fe66396906178872dd933a39e38779a5a3c722.diff L

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a comment. > > In D143967#4232089 , @jemarch wrote: > >> Thinking about typedef, some C cases may be problematic if we adopt the >> flexible rule we are discussing: >> >> typedef int bar; >> const bar __tag1 var1; >> bar var2; >> >

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

asb added a comment. I've added a couple of inline comments, but otherwise this seems fine to me. I'd suggest updating the patch description to reference Philip's documentation patch (which was posted soon after this), and also to explain why there are no codegen changes (I think "Either change

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added inline comments. Comment at: clang/include/clang/Driver/Options.td:2692 def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-assume-teams-oversubscription">, - Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; + Group, Flags<[CC1Option

[PATCH] D147233: [clangd] Enable unused-include diagnostic by default.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Based on https://reviews.llvm.or

[clang] 3ad1673 - [clang][Interp] Implement function pointers

Author: Timm Bäder Date: 2023-03-30T15:37:49+02:00 New Revision: 3ad167329aafde02e70b0327c0488602111a81ee URL: https://github.com/llvm/llvm-project/commit/3ad167329aafde02e70b0327c0488602111a81ee DIFF: https://github.com/llvm/llvm-project/commit/3ad167329aafde02e70b0327c0488602111a81ee.diff LO

[PATCH] D141472: [clang][Interp] Add function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad167329aaf: [clang][Interp] Implement function pointers (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D141472?vs=5079

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16718 void Sema::DiagnoseStaticAssertDetails(const Expr *E) { - if (const auto *Op = dyn_cast(E)) { + if (const auto *Op = dyn_cast(E);Op && Op->getOpcode() != BO_LOr) { const Expr *LHS = Op->getLH

[clang] 3930e33 - [clang][Interp] Add missing static_assert messages

Author: Timm Bäder Date: 2023-03-30T15:43:43+02:00 New Revision: 3930e3331e7173bbacb7181015d8f7ca93f4aaef URL: https://github.com/llvm/llvm-project/commit/3930e3331e7173bbacb7181015d8f7ca93f4aaef DIFF: https://github.com/llvm/llvm-project/commit/3930e3331e7173bbacb7181015d8f7ca93f4aaef.diff LO

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:266-268 + static_assert(invert(true) || invert(true) || false, ""); // expected-error {{failed}} + static_assert((true && invert(true)) || false, ""); // expected-error {{failed}} + static_

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

aaron.ballman added a comment. Thank you for working on this! The changes should also come with a release note in `clang/docs/ReleaseNotes.rst` to note the improvement. Comment at: clang/lib/AST/ExprConstant.cpp:2357-2361 +if (SubobjectDecl) { + Info.FFDiag(DiagLoc, d

[PATCH] D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements

dang created this revision. dang added reviewers: hctim, zixuw. Herald added subscribers: ChuanqiXu, arphaman. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This relands

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added a comment. So at the risk of adding to the number of decisions we need to come to a consensus on, I was about to update the KJ style guide to explicitly call out the difference in indentation for designated initializers when I realized that we (both KJ code authors and clang-format

[PATCH] D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements

dang added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:4898 + + clang_disposeString(SGFData); +} The previous version didn't free the string here which was the source of the leak @hctim Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. In D137327#4233290 , @MyDeveloperDay wrote: > because of https://github.com/llvm/llvm-project/issues/61785 should this > really be reverted? is basically saying `X * Y {` must be `X *Y{` but that > obviously not the case Tri

[clang] abf4a8c - [Clang] Improve diagnostics when using a concept as template argument

Author: Corentin Jabot Date: 2023-03-30T16:30:23+02:00 New Revision: abf4a8cb15d4faf04ee0da14e37d7349d3bde9a1 URL: https://github.com/llvm/llvm-project/commit/abf4a8cb15d4faf04ee0da14e37d7349d3bde9a1 DIFF: https://github.com/llvm/llvm-project/commit/abf4a8cb15d4faf04ee0da14e37d7349d3bde9a1.diff

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabf4a8cb15d4: [Clang] Improve diagnostics when using a concept as template argument (authored by cor3ntin). Changed prior to commit: https://revie

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

cor3ntin added a comment. @KyleFromKitware oups, this fell under the cracks. I think I'm happy with is as-is, do you need help landing it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143099/new/ https://reviews.llvm.org/D143099 ___ cfe-com

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:260 +- Fixed an issue in :doc:`performance-noexcept-move-constructor + ` which resulted in false Please keep alphabetical order (by check name) in this section. Reposi

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added a comment. In D143099#4233623 , @cor3ntin wrote: > @KyleFromKitware oups, this fell under the cracks. I think I'm happy with is > as-is, do you need help landing it? Yes, please. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

cor3ntin added a comment. In D143099#4233633 , @KyleFromKitware wrote: > In D143099#4233623 , @cor3ntin > wrote: > >> @KyleFromKitware oups, this fell under the cracks. I think I'm happy with is >> as-is, do yo

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. In D137327#4233551 , @thieta wrote: > In D137327#4233290 , > @MyDeveloperDay wrote: > >> because of https://github.com/llvm/llvm-project/issues/61785 should this >> really be reve

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added a comment. In D143099#4233651 , @cor3ntin wrote: > Sure. Let me know what name and email address you would like used for the > patch attribution! Thanks Kyle Edwards Is there some way I can set this in my profile settings so tha

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. @aaron.ballman Thanks for the review! I'll add a release note. Comment at: clang/lib/AST/ExprConstant.cpp:2357-2361 +if (SubobjectDecl) { + Info.FFDiag(DiagLoc, diag::note_constexpr_uninitialized) << SubobjectDecl; + Info.Note(Subobjec

[clang] cc8237d - [documentation] Fix some typos

Author: Ayushi Shukla Date: 2023-03-30T15:58:02+01:00 New Revision: cc8237d9d727b864fe65d2c9d620f3332f4235ca URL: https://github.com/llvm/llvm-project/commit/cc8237d9d727b864fe65d2c9d620f3332f4235ca DIFF: https://github.com/llvm/llvm-project/commit/cc8237d9d727b864fe65d2c9d620f3332f4235ca.diff

[PATCH] D146892: [documentation] Fix some typos

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc8237d9d727: [documentation] Fix some typos (authored by ayushi-8102, committed by samtebbs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ htt

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore abandoned this revision. stephanemoore added a comment. Abandoned this revision and folded the changes into another revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137740/new/ https://reviews.llvm.org/D137740

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4233414 , @jemarch wrote: >> If some tooling applies such tags movement it should also apply >> appropriate copying of tags, e.g. it should transform DWARF like this: >> >> var1 -> const -> typedef (bar) -> int >>

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added inline comments. Comment at: flang/tools/bbc/CMakeLists.txt:29 FortranLower +flangFrontendTool ) agozillon wrote: > awarzynski wrote: > > This a frontend driver library and so far `bbc` and `flang-new -fc1` have > > been entirely separate. Coul

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. Moving type tags past typedefs would also make C code reconstruction from BTF incomplete. Such reconstruction is used now by e.g. bpftool to create a vmlinux.h header with all kernel type definitions. So, I think type tags should not be moved past typedefs. Repository

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 509686. hazohelet added a comment. Added release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AS

[clang] 43aa293 - [AArch64] Basic target(+crypto) handling

Author: David Green Date: 2023-03-30T16:46:47+01:00 New Revision: 43aa293aeaf04e8da50c3c53169c0311e0c5 URL: https://github.com/llvm/llvm-project/commit/43aa293aeaf04e8da50c3c53169c0311e0c5 DIFF: https://github.com/llvm/llvm-project/commit/43aa293aeaf04e8da50c3c53169c0311e0c5.diff L

[PATCH] D142135: [AArch64] Basic target("+crypto") handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43aa293aeaf0: [AArch64] Basic target(+crypto) handling (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:70 + File.data() + LocInfo.second, File.end()); + L.SetCommentRetentionState(WithComment); + // Find the token. This part of code cop

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

tahonermann added a comment. Sorry for the delayed response. I managed to miss seeing this review request. Comment at: clang/include/clang/Lex/Lexer.h:598-599 + /// Returns the pointer that points to the beginning of line that contains + /// the given offset, or null if the

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509695. AMS21 marked 15 inline comments as done. AMS21 added a comment. Implement review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files: clang-tool

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:45-49 +const auto *ProtoType = Decl->getType()->castAs(); +const Expr *NoexceptExpr = ProtoType->getNoexceptExpr(); +if (NoexceptExpr) { + Noexcept

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks good to me. Leave it open for few days, maybe someone else want to comment. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCh

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:260 +- Fixed an issue in :doc:`performance-noexcept-move-constructor + ` which resulted in false Eugene.Zelenko wrote: > Please keep alphabetical order (by check name) in this se

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:260 +- Fixed an issue in :doc:`performance-noexcept-move-constructor + ` which resulted in false AMS21 wrote: > Eugene.Zelenko wrote: > > Please keep alphabetical order

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 509698. TIFitis marked an inline comment as done. TIFitis added a comment. Changed how size is calculated. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D1465

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357-1362 +int64_t getSizeInBytes(DataLayout &DL, const mlir::Type &type) { + if (isa(type)) +return DL.getTypeSize(cast(type).getElementType()); + + return -1; +

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

craig.topper updated this revision to Diff 509707. craig.topper added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147179/new/ https://reviews.llvm.org/D147179 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-ha

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1482 +if (prev_base) { + clang::CXXRecordDecl *prev_base_decl = + prev_base->getType()->getAsCXXRecordDecl(); Should we add a comment desc

[PATCH] D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rG142c3d9d1414: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements (authored by dang). Changed prior to commit: https://reviews.llvm.org/D147234?vs=509660&id=509714#toc Repository: rG LLVM

[clang] 142c3d9 - [clang][ExtractAPI] Reland ExtractAPI for libclang improvements

Author: Daniel Grumberg Date: 2023-03-30T18:13:58+01:00 New Revision: 142c3d9d1414847fd154c300ff12505283027505 URL: https://github.com/llvm/llvm-project/commit/142c3d9d1414847fd154c300ff12505283027505 DIFF: https://github.com/llvm/llvm-project/commit/142c3d9d1414847fd154c300ff12505283027505.dif

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:673 + EXPECT_EQ(FindBeginningOfLineOffset("int func1();\nint func2();", 13), 13); + EXPECT_EQ(FindBeginningOfLineOffset("int func1();\nint func2();", 12), 13); + EXPECT_EQ(FindBeginningOfLineO

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

cor3ntin added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:673 + EXPECT_EQ(FindBeginningOfLineOffset("int func1();\nint func2();", 13), 13); + EXPECT_EQ(FindBeginningOfLineOffset("int func1();\nint func2();", 12), 13); + EXPECT_EQ(FindBeginningOfLineOffset("

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 509725. TIFitis added a comment. Updated unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm

[clang] 1fab236 - [CMake] Switch to -fPIE for Fuchsia Toolchain

Author: Alex Brachet Date: 2023-03-30T18:00:50Z New Revision: 1fab236e6e4575d5af4f4722216df4dd6a872795 URL: https://github.com/llvm/llvm-project/commit/1fab236e6e4575d5af4f4722216df4dd6a872795 DIFF: https://github.com/llvm/llvm-project/commit/1fab236e6e4575d5af4f4722216df4dd6a872795.diff LOG:

[PATCH] D147250: [CMake] Switch to -fPIE for Fuchsia Toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fab236e6e45: [CMake] Switch to -fPIE for Fuchsia Toolchain (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

efriedma accepted this revision as: efriedma. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247 __

  1   2   3   >