agozillon added a comment.

Unfortunately I do not believe an mlir-translate test that tests if the 
OffloadModuleInterface is accessible when directly utilizing mlir-translate is 
possible for this patch... I forgot I removed the is device check as it is 
already done at the initial creation of the attribute. However, I do have a 
future patch that it will be utilised in and when @jsjodin's initial TargetOp 
work is in I can likely create a test around that functionality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145264/new/

https://reviews.llvm.org/D145264

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to