agozillon added inline comments.
================ Comment at: flang/tools/bbc/CMakeLists.txt:29 FortranLower +flangFrontendTool ) ---------------- agozillon wrote: > awarzynski wrote: > > This a frontend driver library and so far `bbc` and `flang-new -fc1` have > > been entirely separate. Could this dependency be avoided? > I had hoped to share LangOpts so that the setOffloadModuleInterfaceAttributes > function wouldn't turn into a monolithic set of arguments whenever it's > invoked if more arguments are added, but the dependency isn't ideal I agree! > > I could perhaps look into making some sort of shared data structure to be put > inside of CrossToolHelpers that might remove the dependency and be similarly > useable to how LangOpts works at the moment. If that doesn't work, I can > revert the change to just be a regular argument list and we can revisit the > topic if new options are ever added? Although looking at @domada's https://reviews.llvm.org/D146612 patch it reminds me that they could just be separate functions shared across tools (I perhaps got a little fixated on the idea of it being similar to a driver function handling all the options). Please do tell me whichever you'd prefer :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145264/new/ https://reviews.llvm.org/D145264 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
