MyDeveloperDay added a comment.
I don't like using additional variables in unit tests, if someone changes 25400
multiple tests could break, each test should be stand alone in my view
Herald added a comment.
NOTE: Clang-Format Team Automated Review Comment
Your review contains a change to ClangFormatStyleOptions.rst but not a change
to clang/include/clang/Format/Format.h
ClangFormatStyleOptions.rst is auto generated from Format.h via
clang/docs/tools/dump_format_style.py, please run this to regenerate the .rst
You can validate that the rst is valid by running.
./docs/tools/dump_format_style.py
mkdir -p html
/usr/bin/sphinx-build -n ./docs ./html
================
Comment at: clang/unittests/Format/FormatTest.cpp:25410-25415
+ verifyFormat("int function1(\n"
+ " int param1,\n"
+ " int param2,\n"
+ " int param3);\n"
+ "int function2();\n",
+ Code, Style);
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125171/new/
https://reviews.llvm.org/D125171
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
