[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added a comment. In D146101#4204653 , @jp4a50 wrote: >>> I think it's also worth noting that the google style guide gives an example >>> of designated initializers indented at 2 spaces (whereas their >>> "continuation indent" for wrapped functio

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 507975. tomasz-kaminski-sonarsource added a comment. Adding tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 Files: clang/include/clang/AS

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 507977. iains edited the summary of this revision. iains added a comment. rebased, split the changes to module and private linkage out, this needs to be refactored to collect the test functions into either module.h and / or sema.h Repository: rG LLVM Github

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains planned changes to this revision. iains added a comment. although this patch does handle the cases needed, it really needs refactoring. posting here since we are both working in this area and this might be useful input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang-tools-extra] f957b8f - [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name

Author: Carlos Galvez Date: 2023-03-24T07:22:04Z New Revision: f957b8fe1efe34ac04d1b2e6381e44edcef056b3 URL: https://github.com/llvm/llvm-project/commit/f957b8fe1efe34ac04d1b2e6381e44edcef056b3 DIFF: https://github.com/llvm/llvm-project/commit/f957b8fe1efe34ac04d1b2e6381e44edcef056b3.diff LOG:

[PATCH] D146713: [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name

This revision was automatically updated to reflect the committed changes. carlosgalvezp marked an inline comment as done. Closed by commit rGf957b8fe1efe: [clang-tidy][NFC] Improve naming convention in google-readability-avoid… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo C

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using Eugene.Zelenko wrote: > carlosgalvezp wrote: > > Eugene.Zelenko wrote: > > > Eugen

[PATCH] D146788: [clang][Interp] Fix zero-initializing of floating types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After the discussion in https://reviews.llvm.org/D1

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

sivachandra accepted this revision. sivachandra added inline comments. This revision is now accepted and ready to land. Comment at: libc/src/setjmp/riscv64/longjmp.cpp:54-55 + + LIBC_INLINE_ASM("seqz %0, %1" : "+r"(buf) : "r"(val) :); + LIBC_INLINE_ASM("add %0, %0, %1" : "+r"(b

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:84-85 + if (T->isAnyComplexType()) +return std::nullopt; + aaron.ballman wrote: > Hmmm, this seems surprising to me, I would have assumed that _Complex needed > to be a primitive

[clang] 3048c9e - Revert "Recommit [Modules] Remove unnecessary check when generating name lookup table in ASTWriter"

Author: Dmitry Chernenkov Date: 2023-03-24T07:59:04Z New Revision: 3048c9e15498161572483e3d4b81c9c37bf2770f URL: https://github.com/llvm/llvm-project/commit/3048c9e15498161572483e3d4b81c9c37bf2770f DIFF: https://github.com/llvm/llvm-project/commit/3048c9e15498161572483e3d4b81c9c37bf2770f.diff

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + aaron.ballman wrote: > The template definition isn't available within the header

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:382 -auto &Tokens = AST.getTokens(); -auto SpelledForExpanded = -Tokens.spelledForExpanded(Tokens.expandedTokens(Ref.RefLocation)); -if (!SpelledForExpand

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

hokein added a comment. thanks, the implementation looks good. I left some comments around the test. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2984 +TEST(Hover, UsedSymbols) { + struct { Can you add a test in the existing `TEST(Hover, Pre

[PATCH] D146732: [include-cleaner] Attribute references to explicit specializations

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:81 +// specializaiton using the exported name, but that's rare. +if (llvm::isa(ND) || !RD) + re

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:2037 + /// \endcode + int DesignatedInitializerIndentWidth; + owenpan wrote: > Please disregard my comment above. Comment at: clang/lib/Format/ContinuationIndente

[clang] b94175b - [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

Author: mydeveloperday Date: 2023-03-24T09:27:23Z New Revision: b94175b0ee5712cab8302ac62854106b82d3be08 URL: https://github.com/llvm/llvm-project/commit/b94175b0ee5712cab8302ac62854106b82d3be08 DIFF: https://github.com/llvm/llvm-project/commit/b94175b0ee5712cab8302ac62854106b82d3be08.diff LOG

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb94175b0ee57: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date (authored by MyDeveloperDay). Repository: rG LLVM Github

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:2025 + /// on a new line. When set to -1 (default), ``ContinuationIndentWidth`` is + /// used. \code + /// AlignAfterOpenBracket: AlwaysBreak Comment at: clang

[PATCH] D146732: [include-cleaner] Attribute references to explicit specializations

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:82 +if (llvm::isa(ND) || !RD) + return ND; +return RD; hokein wrote: > We seem to miss a testcase for `TypeAliasT

[PATCH] D146732: [include-cleaner] Attribute references to explicit specializations

kadircet updated this revision to Diff 508025. kadircet marked an inline comment as done. kadircet added a comment. - use isa_and_present - indentation for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146732/new/ https://reviews.llvm.org/D14

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:342 + // Add the notion of typedef for tag type (struct or enum) of the same name. + if (const ElaboratedType *ET = + dyn_cast(Decl->getUnderlyingType())) { This doesn't

[clang-tools-extra] 03101e1 - [include-cleaner] Attribute references to explicit specializations

Author: Kadir Cetinkaya Date: 2023-03-24T11:39:21+01:00 New Revision: 03101e141bf745f036be604e2a5a7c085eb02f5e URL: https://github.com/llvm/llvm-project/commit/03101e141bf745f036be604e2a5a7c085eb02f5e DIFF: https://github.com/llvm/llvm-project/commit/03101e141bf745f036be604e2a5a7c085eb02f5e.dif

[PATCH] D146732: [include-cleaner] Attribute references to explicit specializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03101e141bf7: [include-cleaner] Attribute references to explicit specializations (authored by kadircet). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

foad accepted this revision. foad added a comment. This revision is now accepted and ready to land. LGTM, thanks! If you want to remove some of the other unnecessary predicates from Real instructions you could do that in a separate NFC patch. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 508036. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/lib/Dri

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 508037. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 508038. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 508039. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 508040. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 508041. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst clan

[clang] f454a7c - [OpenCL] Emit EOL at end of generated header

Author: Sven van Haastregt Date: 2023-03-24T11:03:10Z New Revision: f454a7c6853def66c4f3a68bd2a0520489f6833c URL: https://github.com/llvm/llvm-project/commit/f454a7c6853def66c4f3a68bd2a0520489f6833c DIFF: https://github.com/llvm/llvm-project/commit/f454a7c6853def66c4f3a68bd2a0520489f6833c.diff

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a potential immediate invocation is met, it is immediately wrapped by a `ConstantExpr`. There is also a TreeTransfo

[PATCH] D146802: [Documentation] improved documentation of diagnostic messages by explaining thier syntax and test of clang by telling which subobject is uninitialized

simideveloper created this revision. Herald added a project: All. simideveloper requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146802 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AST/Interp

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. @philipp.tomsich Reverse Ping. What are your plans for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142410/new/ https://reviews.llvm.org/D142410 ___ cfe-commits mail

[clang] ef310c6 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2023-03-24T07:27:07-04:00 New Revision: ef310c6d498098f86095cd09ea89088c10e90fc3 URL: https://github.com/llvm/llvm-project/commit/ef310c6d498098f86095cd09ea89088c10e90fc3 DIFF: https://github.com/llvm/llvm-project/commit/ef310c6d498098f86095cd09ea89088c10e90fc3.diff

[PATCH] D146715: [NVPTX] Enforce half type support is present for builtins

jchlanda updated this revision to Diff 508046. jchlanda added a comment. Remove duplicated switch over builtins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146715/new/ https://reviews.llvm.org/D146715 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-nvptx-nativ

[PATCH] D146715: [NVPTX] Enforce half type support is present for builtins

jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18912 + case NVPTX::BI__nvvm_ldu_h2: { +return MakeHalfType(BuiltinID, E, *this); + } tra wrote: > We seem to be checking builtin IDs twice. Once here and then in MakeHalfType > wh

[PATCH] D146644: [documentation]Fixed Random Typos

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. Thank you for this, it looks like it fixes all of the typos reported in the issue. If you don't have commit access yet I can commit this with you as the author. Repository: rG LLVM Git

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 added a comment. Greetings Sir, Thank you for accepting my revision. Please do commit it as I am contributing for the first time and I don't have commit access. Thanks & Regards Priyanshi Agarwal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 508054. nextsilicon-itay-bookstein added a comment. Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test. @jdoerfert Does the PR CI run these, or are there build bots that cover the different target-offloading variants? Can I somehow

[clang] ea064ee - [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

Author: Mariusz Sikora Date: 2023-03-24T13:10:40+01:00 New Revision: ea064ee2a3bd22f5598d0eb76a1bbc3bf293b063 URL: https://github.com/llvm/llvm-project/commit/ea064ee2a3bd22f5598d0eb76a1bbc3bf293b063 DIFF: https://github.com/llvm/llvm-project/commit/ea064ee2a3bd22f5598d0eb76a1bbc3bf293b063.diff

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea064ee2a3bd: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions (authored by mariusz-sikora-at-amd). Repository: rG

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 508059. nextsilicon-itay-bookstein added a comment. Retry, wrong patch uploaded last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

aaron.ballman added a comment. In D146503#4217541 , @chaitanyav wrote: > Thank you, I will commit myself. Should i wait for the build to finish?. this > will be my first direct commit to repo. Sorry for not getting back to you sooner. In general it's g

[PATCH] D146808: [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16

mariusz-sikora-at-amd created this revision. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. mariusz-sikora-at-amd requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Rep

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

hans added a reviewer: mstorsjo. hans added a comment. +mstorsjo is this okay for mingw mode too? Comment at: clang/lib/Sema/SemaExpr.cpp:3558 +return PredefinedExpr::Create(Context, Loc, ResTy, IK, SL); + } else { // Pre-defined identifiers are of type char[x], where

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This should also have a release note, eventually. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as st

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added a comment. Test looks fine, still need a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 ___ cfe-commits mailing list cfe-commits

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

erichkeane added inline comments. Comment at: clang/test/AST/ast-dump-template-decls.cpp:193 +// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// CHECK-NEXT: `-TemplateArg

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 508068. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

[PATCH] D146808: [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16

foad accepted this revision. foad added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:234 TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2bf16, "V2sV2s*3V2s", "t", "atomic-ds-pk-add-16-insts") +TARG

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman added a comment. In D144651#4217750 , @john.brawn wrote: > Unfortunately I still can't reproduce this even using exactly the same cmake > command as you gave. Looking at above cmake log some possible causes of > difference are: > > - I'm

[PATCH] D146802: [Documentation] improved documentation of diagnostic messages by explaining thier syntax and test of clang by telling which subobject is uninitialized

probinson added a comment. You are combining documentation of the syntax for defining diagnostics, and changes to the content of certain diagnostics. The LLVM project wants to see one topic per patch, so these things need to be done separately. Also, the documentation probably does not want to

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 508072. junaire added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/cla

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber added a comment. The above Binary operator test case says that there are two Boolean expressions,**UsefulToPrintExpr** says we can avoid to print these expressions as they are don't need a note and are understandable. So if we go by this we will have to remove the note.By this

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements Value::dump related code so the pretty printing will work. The p

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:776 + let Subjects = SubjectList<[Function, ObjCMethod]>; + let Args = [StringArgument<"Name">]; + let Documentation = [TrampolineDocs]; augusto2112 wrote: > aaron.ballman wrote: >

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM (though I had a small nit), but you should add a release note when landing. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (Consta

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508076. tomasz-kaminski-sonarsource added a comment. Added FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files: clang/test/AST/ast-dump-

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/AST/ast-dump-template-decls.cpp:193 +// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// CHECK-NE

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 508077. tomasz-kaminski-sonarsource added a comment. Including release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 Files: clang/docs/Re

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:228 antecipation of `CWG2563 _`. +- Fix ``getSourceRange`` behavior on ``VarTemplateSpecializationDecl`` + and ``VarTemplatePartialSpecializationDecl

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + tbaeder wrote: > aaron.ballman wrote: > > The template definition isn't availa

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-template-decls.cpp:193 +// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// CHECK-NEXT: `-Template

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 508081. tomasz-kaminski-sonarsource added a comment. Updated release note to be more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

mikhail.ramalho added inline comments. Comment at: libc/src/setjmp/riscv64/longjmp.cpp:54-55 + + LIBC_INLINE_ASM("seqz %0, %1" : "+r"(buf) : "r"(val) :); + LIBC_INLINE_ASM("add %0, %0, %1" : "+r"(buf) : "r"(val), "r"(buf) :); +} sivachandra wrote: > Your commen

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

mstorsjo added a comment. In D146764#4219278 , @hans wrote: > +mstorsjo is this okay for mingw mode too? I believe the current form of the patch is fine - i.e. disabled by default in mingw mode, but enabled if the extra MS language extensions are enable

[PATCH] D146788: [clang][Interp] Fix zero-initializing of floating types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a suggestion. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1076-1081 + case PT_Float: { +const auto &Sem = Ctx.getASTContext().getFloatTy

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Let me know if you need someone to commit this for you, and include "Name To Use " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon updated this revision to Diff 508082. Fznamznon added a comment. Apply the suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146801/new/ https://reviews.llvm.org/D146801 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaEx

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (ConstantExpr *CE = dyn_cast_or_null(Inner)) +if (CE->isImmediateInvocation()) + Inner = CE->getSubExpr(); aaron.ballman wrote: > This will need reformatting, but

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using carlosgalvezp wrote: > Eugene.Zelenko wrote: > > carlosgalvezp wrote: > > > Eugen

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (ConstantExpr *CE = dyn_cast_or_null(Inner)) +if (CE->isImmediateInvocation()) + Inner = CE->getSubExpr(); Fznamznon wrote: > aaron.ballman wrote: > > This wi

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource added a comment. This is now tracked as https://github.com/llvm/llvm-project/issues/61680. Let me know if I should refer it in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 508086. Endill added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D146784#4219469 , @tomasz-kaminski-sonarsource wrote: > This is now tracked as https://github.com/llvm/llvm-project/issues/61680. Let

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508088. tomasz-kaminski-sonarsource added a comment. Updated FIXME with GitHub bug reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 File

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508091. tomasz-kaminski-sonarsource added a comment. Rebased on updated test commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files: clan

[clang] 467ed27 - [clang] Extend pragma dump to support expressions

Author: Vlad Serebrennikov Date: 2023-03-24T17:35:35+03:00 New Revision: 467ed2798772344e2a3b4a8d368575f1f9d1a8c6 URL: https://github.com/llvm/llvm-project/commit/467ed2798772344e2a3b4a8d368575f1f9d1a8c6 DIFF: https://github.com/llvm/llvm-project/commit/467ed2798772344e2a3b4a8d368575f1f9d1a8c6.

[PATCH] D144115: [clang] Extend pragma dump to support expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG467ed2798772: [clang] Extend pragma dump to support expressions (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D146802: [Documentation] improved documentation of diagnostic messages by explaining thier syntax and test of clang by telling which subobject is uninitialized

olista01 added a comment. There is existing documentation of the diagnostics system here, which you could extend if something is still unclear or incomplete: - clang/docs/InternalsManual.rst - https://clang.llvm.org/docs/InternalsManual.html#the-diagnostics-subsystem Repository: rG LLVM Gith

[PATCH] D146408: [clang][Interp] Start supporting complex types

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:84-85 + if (T->isAnyComplexType()) +return std::nullopt; + tbaeder wrote: > aaron.ballman wrote: > > Hmmm, this seems surprising to me, I would have assumed that _Complex >

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy, I

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 508099. skatrak added a comment. Herald added subscribers: Moerafaat, zero9178, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, nicolasvasilache, a

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508102. tomasz-kaminski-sonarsource added a comment. Reverted accidentally included changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne created this revision. SBallantyne added reviewers: MaskRay, awarzynski, DavidTruby, kiranchandramohan, tblah. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. SBallantyne requested review of this revision. Herald added subscr

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508104. tomasz-kaminski-sonarsource added a comment. Reintroduced bug commit refernces. Sorry for the noise, but I still sometimes get confused with arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. In D144651#4219340 , @aaron.ballman wrote: > In D144651#4217750 , @john.brawn > wrote: > >> Unfortunately I still can't reproduce this even using exactly the same cmake >> command as y

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 508105. tomasz-kaminski-sonarsource added a comment. Rebasing on test commit. My applogies for noise, I still get confused with arc sometimes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak marked 3 inline comments as done. skatrak added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:103 + std::error_code ec; + llvm::ToolOutputFile out(outDir + outFile, ec, llvm::sys::fs::OF_Text); + if (ec) awarzynski wrote: > skatra

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

kiranchandramohan added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.h:18 +#include "clang/Basic/DebugInfoOptions.h" #include "llvm/Support/CodeGen.h" The following patch might be useful to avoid adding the clang header. Could you

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

kadircet added a comment. (pardon the interruption, some drive-by comments :)) Comment at: clang-tools-extra/clangd/Hover.cpp:1174 + return; + +for (const include_cleaner::Header &H : Providers) { note that we don't care about each reference of

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, Res

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman added a comment. In D144651#4219633 , @fdeazeve wrote: > In D144651#4219340 , @aaron.ballman > wrote: > >> The build lab's lldb builders are all green, and greendragon's standalone >> build is also

[PATCH] D146808: [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69061f96275c: [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16 (authored by mariusz-sikora-at-amd). Repository: rG LLVM Github

[clang] 69061f9 - [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16

Author: Mariusz Sikora Date: 2023-03-24T16:27:44+01:00 New Revision: 69061f96275c3053623a8699ce641c0f0ac61aed URL: https://github.com/llvm/llvm-project/commit/69061f96275c3053623a8699ce641c0f0ac61aed DIFF: https://github.com/llvm/llvm-project/commit/69061f96275c3053623a8699ce641c0f0ac61aed.diff

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy, I

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

tblah added a comment. Thanks for adding this flang. Please could you add a test checking that the pass is actually run when the flag is given. For example, see the tests on this patch https://reviews.llvm.org/D146278 Comment at: flang/include/flang/Tools/CLOptions.inc:21 #

  1   2   >