foad accepted this revision. foad added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:234 TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2bf16, "V2sV2s*3V2s", "t", "atomic-ds-pk-add-16-insts") +TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2f16, "V2hV2h*3V2h", "t", "atomic-ds-pk-add-16-insts") ---------------- Just curious - is there a reason that these builtins can't be declared in LLVM's IntrinsicsAMDGPU.td? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146808/new/ https://reviews.llvm.org/D146808 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
