aaron.ballman added inline comments.
================
Comment at: clang/test/AST/ast-dump-template-decls.cpp:193
+// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} <line:{{[0-9]+}}:1,
line:{{[0-9]+}}:16> col:5 unTempl 'int'
+// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} <line:{{[0-9]+}}:1,
line:{{[0-9]+}}:5> col:5 unTempl 'int'
+// CHECK-NEXT: `-TemplateArgument type 'int'
----------------
tomasz-kaminski-sonarsource wrote:
> erichkeane wrote:
> > Hmm... thats curious. We shouldn't commit this unless there is a 'fixme'
> > on it showing we don't really mean it, but in reality, this just deserves a
> > Github bug.
> Will add a FIXME. Feel free to create a GitHub bug.
More test coverage is usually a good thing, but in this case, I'd prefer we
either fixed the issue or filed a bug (having a test file with a FIXME comment
but no issue basically means the issue will be ignored forever in practice, so
we're running a test with very little benefit beyond verifying there's not a
crash).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146784/new/
https://reviews.llvm.org/D146784
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
