tbaeder added inline comments.
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template <typename VisitFn> + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + ---------------- aaron.ballman wrote: > The template definition isn't available within the header file, so this is > fragile (impossible to instantiate from anything but ByteCodeExprGen.cpp). What's the alternative? If I make it a static function in `ByteCodeExprGen.cpp`, I'd have to make a lot of members of `ByteCodeEmitter` etc. public which is not a very clean solution. Moving the definition into the header file isn't very nice either, all the others are in the source file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
