[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 490056. eklepilkina added a comment. - Updated I extension verson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 Files: clang/lib/Driver/ToolChains/Arch/RISCV.

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

kadircet added a comment. regarding testing, i think updating all tests that we have in `IncludeCleanerTests` that call `computeUnusedIncludes` to also call the new function that'll use include-cleaner library should be enough. Comment at: clang-tools-extra/clangd/CMakeLists.

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains updated this revision to Diff 490062. iains added a comment. rebased, address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141908/new/ https://reviews.llvm.org/D141908 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/mo

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15258 + // units. Deleted and Defaulted functions are implicitly inline (but the + // inline state is not set at this point, so check the BodyKind explicitly). if (getLangOpts().CPlusPlusModules && current

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM basically. I still feel we need a FIXME there. But I don't want to block this for this reason especially we need to land this before the branch. Comment at: clang

[PATCH] D141577: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:921 PolicyAttrs.TailPolicy = Policy::PolicyType::Agnostic; // TAMA - if (PolicyAttrs.isUnspecified()) { -if (!IsMasked) { craig.topper wrote: > I guess removing this neg

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains marked 2 inline comments as done. iains added a comment. In D141908#4061409 , @ChuanqiXu wrote: > LGTM basically. I still feel we need a FIXME there. But I don't want to block > this for this reason especially we need to land this before the branch

[PATCH] D133574: [C2x] reject type definitions in offsetof

mstorsjo added a subscriber: aeubanks. mstorsjo added a comment. For clarity in the review - the relanded commit ended up reverted by @aeubanks in 39da55e8f548a11f7dadefa73ea73d809a5f1729 . The relanded commit triggers failed

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Herald added a subscriber: luke. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commi

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

ChuanqiXu added a comment. > Well.. we have time for another iteration, I am going to take a vacation for the Chinese New Year since tomorrow to February. So I am a little bit hurried : ) Comment at: clang/lib/Sema/SemaDecl.cpp:15258 + // units. Deleted and Defaulted functi

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

v.g.vassilev added a comment. In D119708#4060336 , @jansvoboda11 wrote: > In D119708#4059254 , @Hahnfeld > wrote: > >> Hello, sorry for the late heads-up, but this functionality is used by ROOT: >> https://gith

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

hokein added a comment. mostly good, just nits. Comment at: clang/tools/include-mapping/gen_std.py:31 // Generate C++ symbols python3 gen_std.py -cppreference cppreference/reference -language=cpp > StdSymbolMap.inc // Generate C symbols

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains updated this revision to Diff 490079. iains marked 5 inline comments as done. iains added a comment. address review commments, add an assert and a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141908/new/ https://reviews.llvm.org/D1419

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains added a comment. In D141908#4061451 , @ChuanqiXu wrote: >> Well.. we have time for another iteration, > > I am going to take a vacation for the Chinese New Year since tomorrow to > February. So I am a little bit hurried : ) (I added the FIXME) Hav

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:159 inline void createDefaultFIROptimizerPassPipeline( -mlir::PassManager &pm, llvm::OptimizationLevel optLevel = defaultOptLevel) { +mlir::PassManager &pm, bool stackArrays = false, l

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:1032 +if (IsMasked) { + if (PolicyAttrs.isTUMAPolicy() && !HasMaskPolicy) +appendPolicySuffix("_tum"); craig.topper wrote: > If you hadn't just removed Omit, it s

[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

sepavloff created this revision. sepavloff added reviewers: rjmccall, kpn, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D14

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:977 +llvm::SmallVector RVVIntrinsic::getSupportedUnMaskedPolicies() { + return { craig.topper wrote: > Possible improvement for a different patch: > > Could these policy lists

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff updated this revision to Diff 490088. sepavloff added a comment. Updated comment in test as proposed by Kevin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 Files: clang/lib/CodeGen/CGExprCom

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff added a comment. In D141765#4059214 , @kpn wrote: > Are we testing _Complex multiply or subtraction anywhere? I have a vague > memory of multiply not working correctly. There is a test `clang/test/CodeGen/complex-math.c` that checks complex o

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

iains updated this revision to Diff 490099. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140927/new/ https://reviews.llvm.org/D140927 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Parser.cpp clang/lib

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

jryans added a comment. @calebzulawski This looks ready to land to me! 🙂 Do you have commit access? If not, I can land it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490100. tblah marked 4 inline comments as done. tblah added a comment. Clarified a comment in stack-arrays.f90 and clarified the choice of FileCheck prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new

[clang] 6898d84 - Reland "nullptr returned from ActOnTag() is not a valid result"

Author: Haojian Wu Date: 2023-01-18T12:41:44+01:00 New Revision: 6898d8413ff4af205000eab1db3fa900b39c6097 URL: https://github.com/llvm/llvm-project/commit/6898d8413ff4af205000eab1db3fa900b39c6097 DIFF: https://github.com/llvm/llvm-project/commit/6898d8413ff4af205000eab1db3fa900b39c6097.diff LO

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein added a comment. In D141580#4061205 , @aeubanks wrote: > apologies for reverting this, but > https://reviews.llvm.org/rGf1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee is broken > and doesn't revert cleanly without this also being reverted, could you re

[PATCH] D142007: [NFC] Fix "form/from" typos

pfusik created this revision. Herald added subscribers: Moerafaat, zero9178, steakhal, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rridd

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:646 // "" for global namespace, "ns::" for normal namespace. + std::vector QueryScopes; + // Like QueryScopes, but also contains inline namespaces. could you actually chang

[clang] 0aaeb25 - [include-mapping] Fix gen_std.py test

Author: Viktoriia Bakalova Date: 2023-01-18T13:07:41Z New Revision: 0aaeb25525ecbc667a9029a4be0d87085392954a URL: https://github.com/llvm/llvm-project/commit/0aaeb25525ecbc667a9029a4be0d87085392954a DIFF: https://github.com/llvm/llvm-project/commit/0aaeb25525ecbc667a9029a4be0d87085392954a.diff

[PATCH] D141944: [include-mapping] Fix gen_std.py test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0aaeb25525ec: [include-mapping] Fix gen_std.py test (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: flang/test/Transforms/stack-arrays.f90:22-29 +! LLVM-IR: array_value_copy_simple +! LLVM-IR-NOT: malloc +! LLVM-IR-NOT: free +! LLVM-IR: all

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 490117. VitaNuo marked an inline comment as done. VitaNuo added a comment. Minor adjustments in accordance with review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.or

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo added a comment. Thanks for the comments! Comment at: clang/tools/include-mapping/gen_std.py:31 // Generate C++ symbols python3 gen_std.py -cppreference cppreference/reference -language=cpp > StdSymbolMap.inc // Generate C symbols --

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane marked an inline comment as done. erichkeane added a comment. In D141954#4060647 , @philnik wrote: > In D141954#4060246 , @erichkeane > wrote: > >> In D141954#4060244

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane updated this revision to Diff 490120. erichkeane added a reviewer: libc++. erichkeane added a comment. Add module map fix, add nit from Shafik. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141954/new/ https://reviews.llvm.org/D141954 Files: clang/docs/ReleaseNotes.rst c

[clang] e7300e7 - Diagnose extensions in 'offsetof'

Author: Aaron Ballman Date: 2023-01-18T08:51:21-05:00 New Revision: e7300e75b51a7e7d4e81975b4be7a6c65f9a8286 URL: https://github.com/llvm/llvm-project/commit/e7300e75b51a7e7d4e81975b4be7a6c65f9a8286 DIFF: https://github.com/llvm/llvm-project/commit/e7300e75b51a7e7d4e81975b4be7a6c65f9a8286.diff

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added a comment. Also, I forgot I added the release notes in that last patch :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141954/new/ https://reviews.llvm.org/D141954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4061428 , @mstorsjo wrote: > For clarity in the review - the relanded commit ended up reverted by > @aeubanks in 39da55e8f548a11f7dadefa73ea73d809a5f1729 >

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. @jryans I do not, I would appreciate that. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 ___ cfe-commits mailing list c

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/AST/Interp/Pointer.h:63-64 private: static constexpr unsigned PastEndMark = (unsigned)-1; static constexpr unsigned RootPtrMark = (unsigned)-1; aaron.ballm

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added a comment. Speaking of: I guess the libcxx failure is NOT caused by me? https://reviews.llvm.org/D141992 I see this on a different review, despite this not being committed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141954/new/ https://reviews.llvm.org/D141954 __

[PATCH] D137070: [clang][Interp] Support destructors

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1900-1902 +/// When calling this, we have a pointer of the local-to-destroy +/// on the stack

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added a comment. In D138958#4060633 , @lebedev.ri wrote: > Ok, if we must not unconditionally emit the memory attributes, then let's not. > Please stamp? :) FWIW, I don't think we should land any of this until after the Clang 16 branch ha

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4061962 , @erichkeane wrote: > Speaking of: I guess the libcxx failure is NOT caused by me? > https://reviews.llvm.org/D141992 > > I see this on a different review, despite this not being committed. That's not great

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added a comment. In D141954#4062029 , @philnik wrote: > In D141954#4061962 , @erichkeane > wrote: > >> Speaking of: I guess the libcxx failure is NOT caused by me? >> https://reviews.llvm.org/D141992

cfe-commits@lists.llvm.org

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:181 + ASSERT_EQ(Tokens.size(), 5u) << Tokens; + EXPECT_TOKEN(Tokens[1], tok::amp, TT_BinaryOperator); + how does this differentiate from `MyType & val2;` is that

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry created this revision. v1nh1shungry added reviewers: tom-anders, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Ok, so. I looked really hard, and essentially i'm not sure we can just change those attributes from implying `readonly`/`readnone`. Things kinda just fall apart Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.C

cfe-commits@lists.llvm.org

dkt01 marked an inline comment as done. dkt01 added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:181 + ASSERT_EQ(Tokens.size(), 5u) << Tokens; + EXPECT_TOKEN(Tokens[1], tok::amp, TT_BinaryOperator); + MyDeveloperDay wrote: > how do

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

mdtoguchi added inline comments. Comment at: clang/include/clang/Driver/Options.td:6654 +def _SLASH_fexcess_precision_EQ : CLJoined<"fexcess-precision=">, + Alias; + To expose to clang-cl, can we just make the original option a `CoreOption` instead of adding an

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, frasercrmck, rogfer01. Herald added subscribers: luke, VincentWu, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein updated this revision to Diff 490137. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140875/new/ https://reviews.llvm.org/D140875 Files: clang-tools-extra/c

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:471 + +// FIXME: this map should probably be in IncludeStructure. +llvm::StringMap> BySpelling; kadircet wrote: > agreed, let's change `StdlibHeaders` in `IncludeStructu

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:875 - updateNamesAndPolicy(IsMasked, hasPolicy(), HasTailPolicy, HasMaskPolicy, - Name, BuiltinName, OverloadedName, PolicyAttrs); @kito-cheng I think the

[PATCH] D142007: [NFC] Fix "form/from" typos

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, thanks! I don't think you need to wait for other owners to approve before landing this, this is pretty clearly an improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

saiislam created this revision. saiislam added reviewers: jhuber6, yaxunl. Herald added subscribers: kosarev, kerbowa, guansong, tpr, jvesely. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer:

[PATCH] D142007: [NFC] Fix "form/from" typos

pfusik added a comment. In D142007#4062211 , @ldionne wrote: > LGTM, thanks! I don't think you need to wait for other owners to approve > before landing this, this is pretty clearly an improvement. I have no commit access, could you please commit this f

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7085 if (Triple.isAMDGPU()) { -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); +handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), Cmd

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

KyleFromKitware updated this revision to Diff 490160. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141961/new/ https://reviews.llvm.org/D141961 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllMacros.cpp clang-tools-extra/cl

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

svenvh added inline comments. Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.Const from OpenCLBuiltins.td is lowered to a readnone attribute. +// FIXME: we don't, though. // CHECK-LABEL: @test_const_attr lebedev.ri wrote:

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.Const from OpenCLBuiltins.td is lowered to a readnone attribute. +// FIXME: we don't, though. // CHECK-LABEL: @t

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG865094746e2a: [clang][Interp] Track initialization state of local variables (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

xingxue updated this revision to Diff 490167. xingxue added a comment. Addressed comments. - added test scenarios for option `fopenmp` in `clang/test/Driver/aix-ld.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141862/new/ https://reviews.llvm.o

[clang] 8650947 - [clang][Interp] Track initialization state of local variables

Author: Timm Bäder Date: 2023-01-18T16:55:02+01:00 New Revision: 865094746e2ad759aee52df2a291420d4fdd1e02 URL: https://github.com/llvm/llvm-project/commit/865094746e2ad759aee52df2a291420d4fdd1e02 DIFF: https://github.com/llvm/llvm-project/commit/865094746e2ad759aee52df2a291420d4fdd1e02.diff LO

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, nikic. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald a

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7116 if (Triple.isAMDGPU()) { -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); +handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), CmdArgs); why do you need to

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

nikic added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2475 if (getOpts().findNearest(Value, Nearest, IncludedFlagsBitmask, - ExcludedFlagsBitmask) <= 1) { + ExcludedFlagsBitmask, 0, 1) <= 1) { Di

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz created this revision. Herald added a subscriber: arphaman. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are seeing issues with path serialization of the `SUBMODULE_TOPHEADER` field when the inpu

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

zahiraam updated this revision to Diff 490183. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/fexcess-precision.c Index: clang/test/

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked 5 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2171-2176 def err_reference_bind_to_vector_element : Error< "%select{non-const|volatile}0 reference cannot bind to vector element">; def err_re

[PATCH] D142030: [pp-trace] Print HashLoc parameter

KyleFromKitware created this revision. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". Herald added subscribers: kbarton, nemanjai. Herald added a project: All. KyleFromKitware requested review of this revision. Herald added a project: clang-tools-

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz added a comment. @akyrtzi it looks like you added this field a while back. Do you know if there are still consumers for the the libclang API, do we need to keep this field around? The alternative is to refactor the `TopHeaders` set to use `FileEntryRef` so that we can keep track of the co

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane updated this revision to Diff 490187. erichkeane added a comment. The changes to the module map file seemed to make things worse! I reverted it for now, hoping this just goes green. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141954/new/ https://reviews.llvm.org/D141954 F

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 490188. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5779-5780 + /// Has iterator modifier + bool HasIteratorModifier = false; + It can be removed Comment at: clang/test/OpenMP/target_map_messages.cpp:970-979 +

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Mordante added a comment. I see the current main pass for the module build in libc++. The error message seems different, from the message for missing parts of the module map. I'll dig a bit further to see whether I can find what's wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added a comment. In D131052#4052563 , @mstorsjo wrote: > Switched the macro to a function and changed the variables to cache > variables, to allow setting them in the grandparent scope without being a > macro. @beanz - Does this seems ok to yo

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl, bader. Herald added subscribers: kosarev, Naghasan, ldrumm, kerbowa, jvesely. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Neith

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_map_messages.cpp:970-979 + // ompx-error@+8 {{use of undeclared identifier 'itt'; did you mean 'it'?}} + // ompx-note@+7 {{'it' declared here}} + // omp-error@+6 {{use of undeclared identifier 'itt'; did you

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

lebedev.ri added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142033/new/ https://reviews.llvm.org/D142033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/test/OpenMP/target_map_messages.cpp:970-979 + // ompx-error@+8 {{use of undeclared identifier 'itt'; did you mean 'it'?}} + // ompx-note@+7 {{'it' declared here}} + // omp-error@+6 {{use of undeclared identifier 'itt'; did you m

[PATCH] D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1993 Builder.emplace(Recorder ? &Recorder->CCSema->getASTContext() : nullptr, -Item, SemaCCS, QueryScopes, *Inserter, FileName, +Recorde

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_map_messages.cpp:970-979 + // ompx-error@+8 {{use of undeclared identifier 'itt'; did you mean 'it'?}} + // ompx-note@+7 {{'it' declared here}} + // omp-error@+6 {{use of undeclared identifier 'itt'; did you

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

jansvoboda11 added a comment. If the plan is to eventually upstream that part of Cling, I'm fine with re-adding a safe version of this API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119708/new/ https://reviews.llvm.org/D119708 ___

[clang] 29d25f9 - [clang][Interp][NFC] Simplify InterpFrame constructor

Author: Timm Bäder Date: 2023-01-18T18:14:23+01:00 New Revision: 29d25f9e9a4c075023ac7d8f19e7073e9b2a0359 URL: https://github.com/llvm/llvm-project/commit/29d25f9e9a4c075023ac7d8f19e7073e9b2a0359 DIFF: https://github.com/llvm/llvm-project/commit/29d25f9e9a4c075023ac7d8f19e7073e9b2a0359.diff LO

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131052/new/ https://reviews.llvm.org/D131052 ___

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Mordante added a comment. I just tested locally with the latest nightly build Debian clang version 16.0.0 (++20230116071901+2563ad8ef1a8-1~exp1~20230116072002.532) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin and that passes the test that fails in the CI. Can

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to validate function attributes other than `convergent`? It's not obvious that presence of `nounwind` attribute is valida

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added a comment. In D141954#4062669 , @Mordante wrote: > I just tested locally with the latest nightly build > > Debian clang version 16.0.0 > (++20230116071901+2563ad8ef1a8-1~exp1~20230116072002.532) > Target: x86_64-pc-linux-gnu > Thre

[PATCH] D142030: [pp-trace] Print HashLoc parameter

KyleFromKitware updated this revision to Diff 490201. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/test/pp-trace/pp-trace-con

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. I posted the Swift patch here: https://github.com/apple/swift/pull/63002 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

saiislam updated this revision to Diff 490204. saiislam added a comment. Removed the unnecessary call to getArgs() and added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142022/new/ https://reviews.llvm.org/D142022 Files: clang/lib/

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7116 if (Triple.isAMDGPU()) { -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); +handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), Cmd

[PATCH] D142030: [pp-trace] Print HashLoc parameter

KyleFromKitware updated this revision to Diff 490206. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/test/pp-trace/pp-trace-con

[clang] 9ee625b - [Clang] Update the help message for `--offload-arch`

Author: Joseph Huber Date: 2023-01-18T11:41:08-06:00 New Revision: 9ee625bd992fba4ba5ef9102e5e02bc87c7252c4 URL: https://github.com/llvm/llvm-project/commit/9ee625bd992fba4ba5ef9102e5e02bc87c7252c4 DIFF: https://github.com/llvm/llvm-project/commit/9ee625bd992fba4ba5ef9102e5e02bc87c7252c4.diff

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:727-728 +this->emitSubOffset(*RT, E); + else +return false; + Should this be an early return before we visit anything? Or an assert on the assumption that we shoul

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz added a comment. @python3kgae, this change introduced a bunch of warning spew because it is using an API that was deprecated shortly before the change merged. Can you please address this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 490208. pmatos added a comment. Remove some unnecessary diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clang/in

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added a comment. @dblaikie, we would use this warning in Chrome OS. We use `icf=all` and have encountered bugs caused by function pointer comparisons. It's not that noisy compiling clang (eight hits). Working on testing it for Chrome OS. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D141472: [clang][Interp] Add function pointers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:138-139 case CK_IntegralToPointer: { if (isa(SubExpr)) return this->visit(SubExpr); Can we still reach this bit now? CHANGES SINCE LAST ACTION https://r

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 490214. arphaman added a comment. add more test coverage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/

  1   2   3   >