erichkeane added a comment. In D141954#4062029 <https://reviews.llvm.org/D141954#4062029>, @philnik wrote:
> In D141954#4061962 <https://reviews.llvm.org/D141954#4061962>, @erichkeane > wrote: > >> Speaking of: I guess the libcxx failure is NOT caused by me? >> https://reviews.llvm.org/D141992 >> >> I see this on a different review, despite this not being committed. > > That's not great. Seems like some recently landed patch broke this. Do you > mind committing the libc++-part of this patch to get the Clang CI green > again? (Assuming the libc++ CI is green) If this passes, I might just do the module-map patch as a separate commit to fix the CI, else the libcxx history is going to be awful strange :) I'm probably a bit from having this review approved anyway, as it is still 'night time' for most of my reviewers :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141954/new/ https://reviews.llvm.org/D141954 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
