aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM!
================ Comment at: clang/lib/AST/Interp/Pointer.h:63-64 private: static constexpr unsigned PastEndMark = (unsigned)-1; static constexpr unsigned RootPtrMark = (unsigned)-1; ---------------- aaron.ballman wrote: > tbaeder wrote: > > shafik wrote: > > > or `-1u` > > Alright, but those were not introduced in this patch. > Preference for `~0u` so the types all match up nicely, fine to do in a > post-commit NFC change. Don't forget to hit this one in post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
