[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1211-1212 +llvm::sort(Input, [](OffloadingImage &A, OffloadingImage &B) { + return A.StringData["triple"].compare(B.StringData["triple"]) == 1 || + A.StringData

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 updated this revision to Diff 471998. jhuber6 added a comment. Sorting on offload kind as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.org/D136701 Files: clang/test/Driver/linker-wrapper.c clang/

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || erichkeane wrote: > Ch

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-Funct

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472001. vhscampos added a comment. Combining release notes of Cortex-X3 and Neoverse V2. Make cortex-x3 use neoverse-v2 model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.o

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName

[PATCH] D136554: Implement CWG2631

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:507-508 ``-std=gnu++14`` to their build settings to restore the previous behaviour. +- Implemented DR2631. Invalid ``consteval`` calls in default arguments and default + member initializers are diag

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM if we add a test for `foo.std`. Comment at: clang/docs/ReleaseNotes.rst:351 + export declaration. Both are diagnosed as an error, but the diagnostic is + suppressed for use of reserved names in a system header.

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added a comment. LGTM. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) FreddyYe wrote: > pengfei wrote: > > FreddyYe wrote: > > > pengfei wrote: > > > > p

[clang] 67f8521 - [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

Author: Jan Sjodin Date: 2022-10-31T10:49:44-04:00 New Revision: 67f8521cd4b6a3bd23263ad21bd6841081fd084f URL: https://github.com/llvm/llvm-project/commit/67f8521cd4b6a3bd23263ad21bd6841081fd084f DIFF: https://github.com/llvm/llvm-project/commit/67f8521cd4b6a3bd23263ad21bd6841081fd084f.diff LO

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f8521cd4b6: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region… (authored by jsjodin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a difference between a `Pointer` and a "`P

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tahonermann added a comment. > Give some time for Aaron/Tom to have the chance to raise further comment but > I'm happy with it otherwise. I'm sorry for the delay getting back to this and I see this has already been pushed (and a fix then pushed). The changes look good to me too. Repository:

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-builtins-ilogb.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics hubert.reinterpretcast wrote: > There seems to be no C language test in the patch (although the

[PATCH] D136554: Implement CWG2631

cor3ntin marked 20 inline comments as done. cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:507-508 ``-std=gnu++14`` to their build settings to restore the previous behaviour. +- Implemented DR2631. Invalid ``consteval`` calls in default arguments and

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Test case can be simplified a bit further: template struct Struct1 { enum { enumValue1 }; Struct1(); }; void function2() { struct Struct3 {}; int i = Struct1::enumVal

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472011. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Address most of Aaron's comments (except the one about using Optional) - Better comment `ImmediateCallVisitor`. - Remove unused code in `ImmediateCallVisitor` Repository: rG LL

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3896313 , @ldionne wrote: > Looking at that commit, which had nothing to do with fixing availability > markup, I think this Clang patch might still be missing some diagnostics? > Should it diagnose when the typename

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

merrymeerkat added a comment. In D137077#3896369 , @aaron.ballman wrote: > Thank you for the patch! However, I think this isn't an improvement to the > diagnostic -- it's a cute phrase, but it doesn't help the programmer to > understand what about thei

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

mizvekov updated this revision to Diff 472017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136977/new/ https://reviews.llvm.org/D136977 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExprCXX.cpp clang

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 472016. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp clang/test/CXX/temp/temp.decls/tem

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov updated this revision to Diff 472018. mizvekov marked 12 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files: clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.c

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472019. cor3ntin added a comment. use llvm::optional to store the `ExpressionEvaluationContextRecord::InitializationContext` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov updated this revision to Diff 472020. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136564/new/ https://reviews.llvm.org/D136564 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaTemplate.cpp clang/lib/Sema/SemaTemplateDeducti

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov updated this revision to Diff 472021. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://reviews.llvm.org/D136565 Files: clang-tools-extra/clangd/unittests/HoverTests.cpp clang/lib/Sema/SemaTemplate.cpp clang/test/AST/a

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || ChuanqiXu wrote: > aaron

[PATCH] D136554: Implement CWG2631

cor3ntin marked 8 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/default-arguments-with-immediate.cpp:22 + +// CHECK: define {{.*}} i32 @_ZL3extv() + aaron.ballman wrote: > Move this check line up to where ext is declar

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 472029. luken-google added a comment. Check template constraint satisfaction logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/ReleaseNot

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

dblaikie added a comment. Could you link to the email/discourse discussion about supporting this mode (I think you've linked it in other discussions, be good to have it for reference here & Probably in the other review)? (I'm wondering if we need a new flag for this, or if it'll be OK to change

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. Because of the change to `InsertNode` to not assert on already cached concepts this patch now works. If I try to catch the recursive expansion on a higher level the test in `concepts.cpp` for 2-level concept expansion fails. There are some finite recursive use case

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

erichkeane added a comment. In D133052#3896663 , @luken-google wrote: > Because of the change to `InsertNode` to not assert on already cached > concepts this patch now works. If I try to catch the recursive expansion on a > higher level the test in `co

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:282 + bool isGlobalDecl(const VarDecl *VD) const { +return !VD->hasLocalStorage() || VD->isConstexpr(); + } tbaeder wrote: > shafik wrote: > > Why not `hasGlobalStorage()`? > >

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 472041. TIFitis added a comment. Fix build errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/F

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added a comment. In D136786#3896341 , @zahiraam wrote: >> I'm going to ignore fast-math right now, because I think the current >> handling is mostly OK, and this review is about unsafe-fp-math. The >> unsafe-fp-math case is a little sim

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

kito-cheng added a comment. Maybe we could add test like aarch64? https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/aarch64-mcpu.c#L20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136930/new/ https://reviews.llvm.org/D136930 _

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3896708 , @michele.scandale wrote: > In D136786#3896341 , @zahiraam > wrote: > >>> I'm going to ignore fast-math right now, because I think the current >>> handling is mostl

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:181 + FPFeatures.allowFPContractAcrossStatement()); } Shouldn't then this also check for FPFeatures.getFPContractMode() ? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190 CmdArgs.push_back("-tune-cpu"); -CmdArgs.push_back(A->getValue()); +if (strcmp(A->getValue(), "native") == 0) + CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUNam

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/constant-builtins-ilogb.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics aaron.ballman wrote: > hubert.reinterpretcast wrote: > > There seems to be no C langua

[clang] 2492c52 - [clang] Improve error recovery for pack expansion of expressions

Author: Matheus Izvekov Date: 2022-10-31T17:57:13+01:00 New Revision: 2492c52a05bcad4fab440ac13632051645d66678 URL: https://github.com/llvm/llvm-project/commit/2492c52a05bcad4fab440ac13632051645d66678 DIFF: https://github.com/llvm/llvm-project/commit/2492c52a05bcad4fab440ac13632051645d66678.dif

[clang] edf1a2e - [clang] Fix handling of unexpanded packs in template argument expressions.

Author: Matheus Izvekov Date: 2022-10-31T17:57:17+01:00 New Revision: edf1a2e89340c8fa64a679e7d4ec2b5ee92ec40f URL: https://github.com/llvm/llvm-project/commit/edf1a2e89340c8fa64a679e7d4ec2b5ee92ec40f DIFF: https://github.com/llvm/llvm-project/commit/edf1a2e89340c8fa64a679e7d4ec2b5ee92ec40f.dif

[clang-tools-extra] 5f820c0 - [clang] ASTImporter: Fix importing of va_list types and declarations

Author: Matheus Izvekov Date: 2022-10-31T17:57:18+01:00 New Revision: 5f820c0f55cd9d4f4520cc92eae0a1c4afe05a54 URL: https://github.com/llvm/llvm-project/commit/5f820c0f55cd9d4f4520cc92eae0a1c4afe05a54 DIFF: https://github.com/llvm/llvm-project/commit/5f820c0f55cd9d4f4520cc92eae0a1c4afe05a54.dif

[clang] ab11408 - [clang] Instantiate NTTPs and template default arguments with sugar

Author: Matheus Izvekov Date: 2022-10-31T17:57:18+01:00 New Revision: ab1140874fc6ab8ceb55a470489b80d953e1c6a6 URL: https://github.com/llvm/llvm-project/commit/ab1140874fc6ab8ceb55a470489b80d953e1c6a6 DIFF: https://github.com/llvm/llvm-project/commit/ab1140874fc6ab8ceb55a470489b80d953e1c6a6.dif

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2492c52a05bc: [clang] Improve error recovery for pack expansion of expressions (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/n

[clang-tools-extra] 279fe62 - [clang] Instantiate alias templates with sugar

Author: Matheus Izvekov Date: 2022-10-31T17:57:19+01:00 New Revision: 279fe6281d2ca5b2318c7437316c28750feaac8d URL: https://github.com/llvm/llvm-project/commit/279fe6281d2ca5b2318c7437316c28750feaac8d DIFF: https://github.com/llvm/llvm-project/commit/279fe6281d2ca5b2318c7437316c28750feaac8d.dif

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf1a2e89340: [clang] Fix handling of unexpanded packs in template argument expressions. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f820c0f55cd: [clang] ASTImporter: Fix importing of va_list types and declarations (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1368

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1140874fc6: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13656

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG279fe6281d2c: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

tahonermann added a comment. > Please add a comment something like this: Done. Thank you for the prior review comments. This is again ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919 ___

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked 9 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

tahonermann updated this revision to Diff 472050. tahonermann retitled this revision from "[Clang] Set thread_local Itanium ABI guard variables before calling constructors." to "[Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duratio

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

jmciver updated this revision to Diff 472051. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2) Refactor local linkage function, applyNoundefToLoadInst, to use static rather than an anonym

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman updated this revision to Diff 472052. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. Added an additional test case, reworked the comments in one of the tests as well. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/test/Modules/reserved-names-1.cpp:33 +expected-error {{module declaration must occur at the start of the translation unit}} + +// Show that

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

andrew.w.kaylor added a comment. In D136786#3893559 , @michele.scandale wrote: > The fact that `"unsafe-fp-math"="true"` implies `-ffp-contract=fast` is quite > unfortunate, and it is something that in principle should be addressed. > My understanding i

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

jmciver added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:676 +namespace { +void applyNoundefToLoadInst(bool enable, const clang::QualType &Ty, +llvm::LoadInst *Load) { tschuett wrote: > Nit: You meant static. Thank you f

Re: [clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Please include some details about the reason for a revert in the revert commit message in addition to the precanned revision/subject quoting On Wed, Oct 26, 2022 at 1:16 AM Matheus Izvekov via cfe-commits wrote: > > > Author: Matheus Izvekov > Date: 2022-10-26T10:14:27+02:00 > New Revision: a88eb

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

aaron.ballman added a comment. In D137077#3896561 , @merrymeerkat wrote: > In D137077#3896369 , @aaron.ballman > wrote: > >> Thank you for the patch! However, I think this isn't an improvement to the >> diagnos

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190 CmdArgs.push_back("-tune-cpu"); -CmdArgs.push_back(A->getValue()); +if (strcmp(A->getValue(), "native") == 0) + CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUN

[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06f640d3fb06: [X86] Enable EVEX GFNI instructions without avx512bw. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136554: Implement CWG2631

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:1315 + // Retrieve the rewritten init expression (for an init expression containing + // immediate calls) With the top level FullExpr and ConstantExpr stripped off. + const Expr *getAdjustedRew

[clang] 06f640d - [X86] Enable EVEX GFNI instructions without avx512bw.

Author: Craig Topper Date: 2022-10-31T10:31:45-07:00 New Revision: 06f640d3fb060e2e9cfed1d7c44636c7ffe3308b URL: https://github.com/llvm/llvm-project/commit/06f640d3fb060e2e9cfed1d7c44636c7ffe3308b DIFF: https://github.com/llvm/llvm-project/commit/06f640d3fb060e2e9cfed1d7c44636c7ffe3308b.diff

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

Abpostelnicu added a comment. @sammccall was there any progress on this so far? This would be really useful to be a clang-tidy check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https://reviews.llvm.org/D121593 _

Re: [clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Sure. The original reason was for a pre-existing problem uncovered in a dependent patch (broken canonicalization of NTTPs), which the underlying issue has been fixed, and then this was merged and reverted again, for a different pre-existing bug with this patch made worse. That bug has been fixed by

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[clang] 6fa0e3d - [X86][Driver] Remove stale FIXME. NFC

Author: Craig Topper Date: 2022-10-31T10:41:40-07:00 New Revision: 6fa0e3df97ac1280da98bd1bc156dad5e036246b URL: https://github.com/llvm/llvm-project/commit/6fa0e3df97ac1280da98bd1bc156dad5e036246b DIFF: https://github.com/llvm/llvm-project/commit/6fa0e3df97ac1280da98bd1bc156dad5e036246b.diff

[PATCH] D137054: [X86][Driver] Remove stale FIXME. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa0e3df97ac: [X86][Driver] Remove stale FIXME. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137054/new/ https://reviews.ll

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-builtins-ilogb.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics hubert.reinterpretcast wrote: > aaron.ballman wrote: > > hubert.reinterpretcast wrote: > > > Th

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || philnik wrote: > a

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472071. cor3ntin marked 6 inline comments as done. cor3ntin added a comment. Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

dblaikie added a comment. @ben.boeckel maybe this'd be the place to discuss the motivation for this feature (picking up from your comment here: https://reviews.llvm.org/D134267#3892629 ) Could you expound a bit on why "write the .pcm to the same path as the .o" isn't sufficient? (like Split DW

[PATCH] D134089: [clang] Mention vector in the description for -mno-implict-float.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134089/new/ https://reviews.llvm.org/D134089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb updated this revision to Diff 472079. krisb added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137067/new/ https://reviews.llvm.org/D137067 Files: clang/test/CodeGenCXX/debug-info-enum-metadata-collision.

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb added a comment. In D137067#3896524 , @dblaikie wrote: > Test case can be simplified a bit further: Thank you! > but otherwise I'm OK with this - I don't /fully/ understand it, but it sounds > plausible enough. (if you have time, I wouldn't mind

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet wrote: > egorzhdan wrote: > > kadircet wrote: > > > i d

[clang-tools-extra] ee1f132 - Revert "[clang] ASTImporter: Fix importing of va_list types and declarations"

Author: Matheus Izvekov Date: 2022-10-31T19:34:23+01:00 New Revision: ee1f132d2c4d399be711275a62698ea9e766c199 URL: https://github.com/llvm/llvm-project/commit/ee1f132d2c4d399be711275a62698ea9e766c199 DIFF: https://github.com/llvm/llvm-project/commit/ee1f132d2c4d399be711275a62698ea9e766c199.dif

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. I think the 'this results in a hard error, not failed lookup' is a necessity here based on discussions on the core reflector. Also see: https://reviews.llvm.org/D133052 Re

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added a comment. I'll need to have another look at this, apparently the synthesized `std` namespace breaks some tests on arm platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 _

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

aaron.ballman added reviewers: clang-language-wg, aaron.ballman. aaron.ballman added a comment. Thank you for the changes! One thing you should add is a release note so users know there's been a diagnostic improvement. Comment at: clang/lib/Parse/ParseDecl.cpp:5384-5385 +boo

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472086. erichkeane added a comment. Add DELETE_ME so that the libcxx tests run. Due to the nature of this patch, it is possible that I will have missed a few cases where we should be 're-starting' the substitution stack checking. CHANGES SINCE LAST ACT

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jsjodin added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4712 +Module &M, OffloadEntriesInfoManager &OffloadEntriesInfoManager, +bool isDevice) { + // If we are in target mode, load the metadata from the host IR. This code has ---

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || philnik wrote: > a

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1685 + + const std::string ompOffloadInfoName = "omp_offload.info"; + Drive by, add doxygen documentation to all methods + members please. Repository: rG LLVM Githu

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

luken-google added a comment. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

aaron.ballman added a comment. Thank you for the new diagnostic, please be sure to add a release note so users know there's a new warning. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup

[PATCH] D136554: Implement CWG2631

aaron.ballman added a comment. I'm still thinking about the implementation, but I think this is heading in the correct direction. Comment at: clang/lib/AST/ExprCXX.cpp:970-973 +const Expr *CXXDefaultArgExpr::getExpr() const { + return CXXDefaultArgExprBits.HasRewrittenInit ?

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472093. erichkeane added a comment. ACTUALLY add the libcxx testing, also rebase so hopefully it applies cleanly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 472094. TIFitis added a comment. Removed isDevice from parameters. Added documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 Files: clang/lib/CodeGen/CGO

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4712 +Module &M, OffloadEntriesInfoManager &OffloadEntriesInfoManager, +bool isDevice) { + // If we are in target mode, load the metadata from t

[PATCH] D136925: [clangd] Index scoped enums for code completion

tom-anders updated this revision to Diff 472101. tom-anders marked 3 inline comments as done. tom-anders added a comment. Herald added a subscriber: wenlei. Add test to CodeCompletionTests, only consider unscoped enums in this patch (move scoped enums to separate patch) Repository: rG LLVM Gi

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders created this revision. tom-anders added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders updated this revision to Diff 472103. tom-anders added a comment. Added missing hunk in CodeComplete.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/ https://reviews.llvm.org/D137104 Files: clang-tools-extra/clangd/CodeCo

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472108. cor3ntin added a comment. Move more getExpr methods in the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam created this revision. zahiraam added reviewers: majnemer, rnk. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Microsoft allows the support of ‘constexpr’ with ‘__declspec(dllimport) starting from VS2017 15.u update 4. See Constexpr

[clang] 7af01fe - [lit] Remove undefined keyword from a Driver test

Author: Paul Robinson Date: 2022-10-31T13:01:05-07:00 New Revision: 7af01fe42f1634297601016cd4ef84c34cd84bca URL: https://github.com/llvm/llvm-project/commit/7af01fe42f1634297601016cd4ef84c34cd84bca DIFF: https://github.com/llvm/llvm-project/commit/7af01fe42f1634297601016cd4ef84c34cd84bca.diff

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song added a comment. @aaron.ballman or @dblaikie I have addressed the comments, could you take a look again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136807/new/ https://reviews.llvm.org/D136807

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk added a comment. Unless I'm missing something, I think Clang's behavior here is preferable to MSVC's. MSVC produces code which will not link. Clang turns the linker error into a compiler error, which is generally easier for the user to understand. To my knowledge, it is still true that ther

[PATCH] D133998: [HIP][test] Avoid %T

probinson added a comment. I filed #58711 to get the test fixed; in the meantime, removed `clang-driver` and added `XFAIL: *` in rG7af01fe4 Repository: rG LLVM Github Mon

<    1   2   3   >