aaron.ballman added a comment. In D137077#3896561 <https://reviews.llvm.org/D137077#3896561>, @merrymeerkat wrote:
> In D137077#3896369 <https://reviews.llvm.org/D137077#3896369>, @aaron.ballman > wrote: > >> Thank you for the patch! However, I think this isn't an improvement to the >> diagnostic -- it's a cute phrase, but it doesn't help the programmer to >> understand what about their code needs to change. > > Hi Aaron! Agreed--thank you for the review! I was just following a tutorial > on how to make changes to LLVM, so this was not a real code review :) > Cheers! Ahhh, that makes a lot more sense, thank for letting me know! (This is like the fourth time I've seen someone submit these same changes and I was confused as to why this was such a popular attempted modification, lol.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137077/new/ https://reviews.llvm.org/D137077 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
