cor3ntin marked 8 inline comments as done. cor3ntin added inline comments.
================ Comment at: clang/test/CodeGenCXX/default-arguments-with-immediate.cpp:22 + +// CHECK: define {{.*}} i32 @_ZL3extv() + ---------------- aaron.ballman wrote: > Move this check line up to where ext is declared? I moved it after `test_function`, which where it is defined, because it is a static function, it is only defined if odr used, and only odr used if the parameter is defaulted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits