[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > royjacobson wr

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue &createTop() { +return takeOwnership(std::make_unique()); + } ymandel wrote: > xazax.hun wrote: > > gribozavr2 wrote: > > > yma

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1192 + const Environment &Env1, const Value &Val2, + const Environment &Env2) final { +// Changes to a sound

[PATCH] D135916: Itanium ABI: Pack non-pod members of packed types

dblaikie created this revision. dblaikie added reviewers: rnk, abrachet. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Seems there's a narrow case - where a packed type doesn't pack its base subobject

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3852362 , @aaron.ballman wrote: > what's the need for adding this matcher? Do you plan to use it for some > in-tree needs? We usually only add new matchers where there's an immediate > need for them because of how ex

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3854675 , @hubert.reinterpretcast wrote: >> I reached out to the GCC author to confirm that the committee acknowledges >> that there should be a change to temp.func.order p6.2.1, but no consensus on >> what changes to

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

shafik added a comment. The following also generates an `ImplicitValueInitExpr`: template struct B { T a[N]; }; int main() { constexpr B arr = {}; constexpr int x = arr.a[0]; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

efriedma updated this revision to Diff 467601. efriedma added a comment. Add dedicated error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134928/new/ https://reviews.llvm.org/D134928 Files: clang/docs/ReleaseNotes.rst clang/include/c

[clang] 9363071 - Move GCC-compatible pod-packing change to v16/old behavior available at v15 and below

Author: David Blaikie Date: 2022-10-13T21:13:19Z New Revision: 9363071303ec59bc9e0d9b989f08390b37e3f5e4 URL: https://github.com/llvm/llvm-project/commit/9363071303ec59bc9e0d9b989f08390b37e3f5e4 DIFF: https://github.com/llvm/llvm-project/commit/9363071303ec59bc9e0d9b989f08390b37e3f5e4.diff LOG:

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc behavior

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. In D117616#3732261 , @dblaikie wrote: > In D117616#3731188 , @abrachet > wrote: > >> While digging around failures we were seeing related to this I found some >> behavior that diverges

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:737 +auto ArrayType = IVIE->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = dyn_cast(ArrayType); +const size_t NumElems = CAT->getSize().getZExtValue(); I believe

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman, hubert.reinterpretcast, rjmccall. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, for thread_lo

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz updated this revision to Diff 467606. beanz added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CMakeLists.txt

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void created this revision. void added reviewers: kees, serge-sans-paille, rsmith, efriedma. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The diagnostic was confusing and reporting that an array contains

[PATCH] D134507: [Clang] add missing ClangABICompat check

tahonermann added a comment. > Per further discussions in D128745 , this > is not needed. I agree that the code change is not needed. I think it is worth keeping the test though (modified to verify the expected ambiguity). Repository: rG LLVM Github Monorep

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

python3kgae added inline comments. Comment at: llvm/lib/Target/DirectX/DXILResource.h:46 // can only be added to the end, and not removed. enum class Kinds : uint32_t { Invalid = 0, Could we move ResourceBase::Kinds to Frontend/HLSL/HLSLResource.h so w

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void added a comment. In D135727#3854252 , @kees wrote: > In D135727#3853896 , @void wrote: > >> @kees @serge-sans-paille: It appears to me that a terminating array of size >> > 2 *isn't* treated as a FAM in Clan

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467609. ymandel added a comment. Added FIXMEs for noted issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files: clang/include/clang/Analysis/FlowSensitive/Da

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Hmm - pinging this since my last comment didn't seem to send mail (at least not that appeared on llvm-commits archive) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 __

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:241 + // Pointer arithmethic special case. This is supported for one of + // LHS and RHS being a pointer type and the other being an integer type. + if (BO->getType()->isPointerType()) { ---

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel marked 6 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:527-528 +auto *Prop2 = Val2.getProperty("has_value"); +return Prop1 == Prop2 || (Prop1 != nullptr && Prop2 != nu

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467611. ymandel added a comment. fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added a comment. In D135326#3854141 , @rjmccall wrote: > I don't remember the history of the `-fc++-abi` flag at all, so if that's a > driver flag, you'll probably need to investigate it more to remove it. Maybe > it was added for testing purp

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

drodriguez updated this revision to Diff 467617. drodriguez added a comment. >From internal review: use virtual method in ToolChain instead of static_cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options ``-funsafe-math-optim

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. Herald added a subscriber: abrachet. Herald added a project: All. FWIW, the existence of this flag and the TargetCXXABI abstraction (which predates the flag, but might otherwise be more simply factored/implemented with inheritance rather than switch tables) came up in d

[PATCH] D135923: [clang-dataflow][NFC] Mark test analysis classes as `final`.

ymandel created this revision. ymandel added a reviewer: xazax.hun. Herald added a subscriber: rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Change from marking individual methods as `final` to marking the whole class. Repository

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467621. ayzhao added a comment. Herald added a subscriber: arphaman. implement constexpr and anonymous bitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467622. ayzhao added a comment. unify spacing in CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/c

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15717 +// FIXME: unimplemented +llvm_unreachable("unimplemented"); } 0x59616e wrote: > cor3ntin wrote: > > This is fairly important, ie you should make sure the feature works in

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

shafik added a comment. Thank you for this fix, I have some comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16068 DiagRuntimeBehavior(BaseExpr->getBeginLoc(), BaseExpr, PDiag(DiagID) << toString(index, 10, true) -

[PATCH] D135421: Driver: Change default Android linker to lld.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d9c4a7425d9: Driver: Change default Android linker to lld. (authored by pcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 8d9c4a7 - Driver: Change default Android linker to lld.

Author: Peter Collingbourne Date: 2022-10-13T15:40:30-07:00 New Revision: 8d9c4a7425d9b097c275eb3465aa88a6d19d6c9d URL: https://github.com/llvm/llvm-project/commit/8d9c4a7425d9b097c275eb3465aa88a6d19d6c9d DIFF: https://github.com/llvm/llvm-project/commit/8d9c4a7425d9b097c275eb3465aa88a6d19d6c9d

[PATCH] D135872: [clang-format] Handle unions like structs and classes

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135872/new/ https://reviews.llvm.org/D135872 _

[PATCH] D135866: [clang-format][NFC] Fix comment grammer in ContinuationIndenter

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135866/new/ https://reviews.llvm.org/D135866 _

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1304 LLVMStyle.RequiresClausePosition = FormatStyle::RCPS_OwnLine; + LLVMStyle.RequiresExpressionIndentation = FormatStyle::REI_Keyword; LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave;

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467626. ayzhao added a comment. Restrict CodeGen test to Linux only since Windows semantics for bitfields are weird Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Fi

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16068 DiagRuntimeBehavior(BaseExpr->getBeginLoc(), BaseExpr, PDiag(DiagID) << toString(index, 10, true) - << toString(size, 10, true) ---

[PATCH] D135923: [clang-dataflow][NFC] Mark test analysis classes as `final`.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135923/new/ https://reviews.llvm.org/D135923 __

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467631. python3kgae added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add resource shape to metadata. Conflict with https://reviews.llvm.org/D135110, will rebase once https://reviews.llvm.org/D135110 is in.

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

jdoerfert added a comment. First, as noted, I asked @jhuber6 to update this. In D135614#3847775 , @tra wrote: > Is that really something we need/want to do? I've never seen anyone > complaining about this particular issue. I have, and not only once. He

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

jdoerfert added a comment. This now looks good. The test is the only things I don't understand. Comment at: clang/test/OpenMP/irbuilder_simd_aligned.cpp:69 +// CHECK: omp_loop.preheader: +// CHECK-COUNT-3: call void @llvm.assume(i1 true) [ "align" +// CHECK-NEXT:br la

[PATCH] D135926: [clang] Fix crash with -funique-internal-linkage-names

ellis created this revision. Herald added a project: All. ellis added reviewers: tmsriram, hoy, dblaikie. ellis published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calling `getFunctionLinkage(CalleeInfo.getCalleeDecl())` will crash when the d

[PATCH] D133753: [clang][Interp] WIP: Array fillers

shafik added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:83 + /// that have an array filler. + const InterpSize NumFullElems = 0; + const Expr *ArrayFiller = nullptr; How about `NumElemsWithFiller`? Comment at: clang/li

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

drodriguez updated this revision to Diff 467644. drodriguez added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467647. ayzhao added a comment. Fix object lifetime issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/clang/

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

shafik added a comment. I commented on the bug report: https://github.com/llvm/llvm-project/issues/54158 I wanted to also add a note here, I don't believe this is a valid change. The example should be ill-formed as was clarified by defect report 2374

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

pcc added a comment. Does that DR apply retroactively to C++17? I get the impression that "Status: C++20" means that the issue was only fixed in C++20, which would make this well-formed with `-std=c++17`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

shafik added a subscriber: aaron.ballman. shafik added a comment. In D120862#3857340 , @pcc wrote: > Does that DR apply retroactively to C++17? I get the impression that "Status: > C++20" means that the issue was only fixed in C++20, which would make thi

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

thesamesam added a comment. My objection based on config support is no longer relevant, as it's been solved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133375/new/ https://reviews.llvm.org/D133375 ___

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589 + // On platforms other than AIX, gdb is the default option. + // On AIX, dbx will be automatically pick up in the presense of the + // debugger tuning argument, so set gdb on

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467661. ayzhao added a comment. run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Decl.

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

vsapsai created this revision. vsapsai added reviewers: aaron.ballman, erichkeane, rtrieu. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Instead of dumping `Expr*` memory address, output `Expr` representa

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM basically. Our discussion is mainly about the future work in Attr.td and not this patch. So I think they are not blocking issues. Comment at: clang/lib/AST/ODRDia

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai added a comment. To fix pre-merge errors like error: 'error' diagnostics seen but not expected: File .../clang/test/Modules/Output/odr_hash.cpp.tmp/Inputs/first.h Line 3797: ... found 'AlignedDoublePtr' with attribute ' __attribute__((align_value(0xb7dc9b8)))' posted D135931

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added inline comments. Comment at: llvm/lib/Target/DirectX/DXILResource.h:46 // can only be added to the end, and not removed. enum class Kinds : uint32_t { Invalid = 0, python3kgae wrote: > Could we move ResourceBase::Kinds to Frontend/HLSL/HLSL

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

kees added a comment. In D135727#3856978 , @void wrote: > I think we opened the can or worms. :-) At this point I think the can we opened has worms with cans of worms with cans of worms. I'd say it's turtles all the way down, but it seems to just be wor

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

kees added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:15 { -return (void *)es->s_uuid + 80; // expected-warning {{refers past the end of the array}} +return (void *)es->s_uuid + 80; // expected-warning {{refers past the end of the arr

[PATCH] D135932: Add AVX-IFMA instructions.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer to

[clang] 00b9bed - [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

Author: Ting Wang Date: 2022-10-13T22:57:40-04:00 New Revision: 00b9bed1f05a72962643f8a41d30256c55bd19f5 URL: https://github.com/llvm/llvm-project/commit/00b9bed1f05a72962643f8a41d30256c55bd19f5 DIFF: https://github.com/llvm/llvm-project/commit/00b9bed1f05a72962643f8a41d30256c55bd19f5.diff LOG

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

This revision was automatically updated to reflect the committed changes. Closed by commit rG00b9bed1f05a: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than… (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D135936: [X86] Support -march=raptorlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467674. ayzhao added a comment. add test for constexpr array and a whitespace fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

LuoYuanke added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__AVXNECONVERT__"); + Builder.defineMacro("__AVXNECONVERT_SUPPORTED__"); if (HasAVXVNNI) Do we need it here? Repository: rG LLVM Github Monorepo CH

[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. The codes look good and also the tests pass. So LGTM. Thanks! Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1082-1094 +auto merge = [this, &Redecl, FD](auto &&F) { + auto *Existing = cast_or_null(Red

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 467677. rymiel added a comment. Full stops in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/F

[clang] f59f116 - AMDGPU: Add __builtin_amdgcn_permlane64

Author: Matt Arsenault Date: 2022-10-13T21:12:11-07:00 New Revision: f59f116bd5c357b1cb4b04693c88d41484e168d5 URL: https://github.com/llvm/llvm-project/commit/f59f116bd5c357b1cb4b04693c88d41484e168d5 DIFF: https://github.com/llvm/llvm-project/commit/f59f116bd5c357b1cb4b04693c88d41484e168d5.diff

[PATCH] D134872: AMDGPU: Add __builtin_amdgcn_permlane64

arsenm closed this revision. arsenm added a comment. f59f116bd5c357b1cb4b04693c88d41484e168d5 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134872/new/ https://reviews.llvm.org/D134872 __

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. Changing the default LLVM style would change the output of all the requires-related test cases in `FormatTest.Concepts`. Should I change these test cases to use the new indentation or pass the `REI_Keyword` style to them? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is supported */ +#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__) Is this FIXME still relevant? Don't we support _Float16 with S

[PATCH] D135936: [X86] Support -march=raptorlake

craig.topper added inline comments. Comment at: clang/test/CodeGen/target-builtin-noerror.c:129 (void)__builtin_cpu_is("tremont"); + (void)__builtin_cpu_is("raptorlake"); (void)__builtin_cpu_is("westmere"); Was this list once in alphabetical order? =

[PATCH] D135937: [X86] Support -march=meteorlake

craig.topper added inline comments. Comment at: clang/test/CodeGen/target-builtin-noerror.c:129 (void)__builtin_cpu_is("tremont"); + (void)__builtin_cpu_is("meteorlake"); (void)__builtin_cpu_is("westmere"); I think this list was once in alphabetical order

[PATCH] D135936: [X86] Support -march=raptorlake

craig.topper added a comment. Release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135936/new/ https://reviews.llvm.org/D135936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D135937: [X86] Support -march=meteorlake

craig.topper added a comment. Release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__AVXVNNIINT8__"); + Builder.defineMacro("__AVXVNNIINT8_SUPPORTED__"); if (HasAVXVNNI) Why is this define needed? Comment at: clan

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__AVXNECONVERT__"); + Builder.defineMacro("__AVXNECONVERT_SUPPORTED__"); if (HasAVXVNNI) LuoYuanke wrote: > Do we need it here? We don't need it. ==

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added inline comments. Comment at: clang/include/clang/Sema/Scope.h:483-488 + /// Determine whether this scope is some OpenMP directive with + /// order clause which specifies concurrent scope. + bool isOpenMPOrderClauseScope() const{ +return getFlags() & Sco

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/avxneconvertintrin.h:47 +static __inline__ __m128 __DEFAULT_FN_ATTRS128 +_mm_cvtneebf16_ps(const __m128bh *__A) { + return (__m128)__builtin_ia32_vcvtneebf162ps128((const __v8hi *)__A); I think the bf1

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:41 - void report(SourceLocation Loc, NamedDecl *ND) { + void report(SourceLocation Loc, NamedDecl *ND, RefType RT) { if (!ND || Loc.isInvalid()) using default

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

zixuan-wu added a comment. In D116735#3429850 , @craig.topper wrote: > I'm seeing a regression on 401.bzip2 and possibly 471.astar. And I'm not > seeing large improvements on 471.omnetpp or 483.xalancbmk. LGTM. But do you still get regression on spec?

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks added a comment. Fun fact, there is one instance of such a case within the clang-format code. I can't remember where (I stumbled upon this in January, and tried to fix it ever since), should that be reformatted with this patch, or with a follow up? Comment

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:108 - S.Current = - new InterpFrame(S, const_cast(Func), S.Current, {}, {}); + S.Current = new InterpFrame(S, const_cast(Func), {}); // Result of

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver updated this revision to Diff 467690. jmciver edited the summary of this revision. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary) Resolve merge conflicts due to the adoption of the ptr

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder updated this revision to Diff 467691. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135013/new/ https://reviews.llvm.org/D135013 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp Index: clang/test/AST/

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder added a comment. Thanks for the reproducer! Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:748 + } else { +assert(false && "default initializer for non-primitive type"); + } shafik wrote: > I guess this covers both arrays and cla

<    1   2