jdoerfert added a comment. This now looks good. The test is the only things I don't understand.
================ Comment at: clang/test/OpenMP/irbuilder_simd_aligned.cpp:69 +// CHECK: omp_loop.preheader: +// CHECK-COUNT-3: call void @llvm.assume(i1 true) [ "align" +// CHECK-NEXT: br label [[OMP_LOOP_HEADER:%.*]] ---------------- Did you not check the alignment here on purpose? I'd assume this is the most important line in the test, no? Also, consider this cannot be auto-updated anymore w/o loosing manual updates. ================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:631 + Value *IfCond, omp::OrderKind Order, ConstantInt *Simdlen, + ConstantInt *Safelen); ---------------- No llvm:: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
