beanz added inline comments.
================
Comment at: llvm/lib/Target/DirectX/DXILResource.h:46
// can only be added to the end, and not removed.
enum class Kinds : uint32_t {
Invalid = 0,
----------------
python3kgae wrote:
> Could we move ResourceBase::Kinds to Frontend/HLSL/HLSLResource.h so we can
> share it between clang and llvm?
Within reason, we can move any code that makes sense to share. We should do
that in changes where the moved code will be used rather than making this
change larger.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135110/new/
https://reviews.llvm.org/D135110
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
