ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
The codes look good and also the tests pass. So LGTM. Thanks!
================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1082-1094
+ auto merge = [this, &Redecl, FD](auto &&F) {
+ auto *Existing =
cast_or_null<FunctionDecl>(Redecl.getKnownMergeTarget());
+ RedeclarableResult NewRedecl(Existing ? F(Existing) : nullptr,
+ Redecl.getFirstID(), Redecl.isKeyDecl());
+ mergeRedeclarableTemplate(F(FD), NewRedecl);
+ };
+ if (Kind == FunctionDecl::TK_FunctionTemplate)
----------------
nit: I feel it lack a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131858/new/
https://reviews.llvm.org/D131858
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
