[PATCH] D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value

yonghong-song added a comment. In D134705#3818657 , @dblaikie wrote: > SGTM - could you also add some CHECKs in the test that show the enumeration > was added to the enumerators list on the CU (& you can probably test with > just one enumerator - don't

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:465 + /// post-call event. + class NoErrnoConstraint : public ErrnoConstraintBa

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/docs/ReleaseNotes.rst:236-239 +- Clang now supports loading multiple configuration files. The files from + default configuration paths are loaded first, unless ``--no-default-config`` + option is used. All files explicitly spec

[PATCH] D132249: [clang][analyzer] Add some functions to StreamChecker with errno modeling.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.h:110 +/// \arg \c InvalE Expression that causes invalidation of \c errno. +ProgramStateRef setErrnoStdMustBeChecked(ProgramStateRef State, + Checker

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

cor3ntin added a comment. In D53847#3819344 , @ayzhao wrote: > add test and fix for P2092 These changes look good to me, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: clang/docs/ReleaseNotes.rst:236-239 +- Clang now supports loading multiple configuration files. The files from + default configuration paths are loaded first, unless ``--no-default-config`` + opt

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463455. mgorny marked an inline comment as done. mgorny added a comment. Updated docs per @sepavloff 's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder updated this revision to Diff 463456. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/In

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/docs/ReleaseNotes.rst:236-239 +- Clang now supports loading multiple configuration files. The files from + default configuration paths are loaded first, unless ``--no-default-config`` + option is used. All files explicitly spec

[PATCH] D134797: [X86][vectorcall] Make floating-type passed by value to match with MSVC

pengfei created this revision. pengfei added a reviewer: rnk. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The passing format of floating-point types are different from vector when SSE registers exha

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

DavidSpickett added inline comments. Comment at: clang/lib/Support/CMakeLists.txt:21 + # libLLVM-*.so, to be used by clang-tblgen. This is so clang-tblgen doesn't + # accidentally link against libLLVMSupport twice (once statically and once via + # libLLVM-*.so). -

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1089 + + bool ModeSuffixUnique = !ClangNameParts.ModeSuffix.empty() && + ClangNameParts.ModeSuffix != RealMode.str(); sepavlof

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463464. mgorny added a comment. Rename the bool to `TryModeSuffix`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Dr

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 marked 5 inline comments as done. 10ne1 added a comment. FYI: @MaskRay I think you will be very happy that after the simplifications Nick suggested the Distro::* additions are not necessary anymore. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:377-389 const Strin

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 updated this revision to Diff 463465. 10ne1 marked an inline comment as done. 10ne1 edited the summary of this revision. Herald added subscribers: atanasyan, arichardson, sdardis. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 Files: cl

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134361/new/ https://reviews.llvm.org/D134361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder updated this revision to Diff 463467. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:173 +APSInt RHSInt = RHS.toAPSInt(); +APSInt Result = LHSInt % RHSInt; + `Result`is unused in here now I guess. Also `RHSInt` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1098 + // Try loading separate config for the target (variants 3. and 4.) + CfgFileName = RealTriple.str() + ".cfg"; + if (searchForFile(CfgFilePath, CfgFileSearchDirs, CfgFileName, getVFS()) && -

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder updated this revision to Diff 463472. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

arichardson added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. // ---

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgument

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. Can someone make a final review please? Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 ___ cfe-commits mailing list cf

[PATCH] D134733: [clang-format][chore] transparent #include name regex

kwk added a comment. @MyDeveloperDay please see my potentially uneducated comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:400 +llvm::Regex getCppIncludeRegex() { + static const char CppIncludeRegexPattern[] = + R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1098 + // Try loading separate config for the target (variants 3. and 4.) + CfgFileName = RealTriple.str() + ".cfg"; + if (searchForFile(CfgFilePath, CfgFileSearchDirs, CfgFileName, getVFS()) &&

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle added inline comments. Comment at: clang/lib/Support/CMakeLists.txt:21 + # libLLVM-*.so, to be used by clang-tblgen. This is so clang-tblgen doesn't + # accidentally link against libLLVMSupport twice (once statically and once via + # libLLVM-*.so). D

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1098 + // Try loading separate config for the target (variants 3. and 4.) + CfgFileName = RealTriple.str() + ".cfg"; + if (searchForFile(CfgFilePath, CfgFileSearchDirs, CfgFileName, getVFS()) && -

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

DavidSpickett added a comment. +1 from me also, but someone else should check that this is a reasonable way to implement it cmake wise (not that this is a horrible hack but I never can tell with cmake). One more question, does this same issue potentially apply to llvm-tblgen and has that got a

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement visiting `ConditionalOperator`s. This al

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. //

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

mstorsjo added a reviewer: beanz. mstorsjo added a subscriber: beanz. mstorsjo added a comment. Adding @beanz who might have some more cmake knowledge on whether this is the best/least bad way of doing things. Comment at: clang/lib/Support/CMakeLists.txt:26 +DISABLE_LLVM_L

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. // -

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. //

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

aaron.ballman added reviewers: phosek, Ericson2314. aaron.ballman added a comment. Adding the CMake code owners as reviewers for input on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134637/new/ https://reviews.llvm.org/D134637

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. // -

[PATCH] D134652: [clang-format] Add Basic Carbon Support/Infrastructure to clang-format

MyDeveloperDay updated this revision to Diff 463502. MyDeveloperDay retitled this revision from "[clang-format] Add Really Basic Carbon Support/Infrastructure" to "[clang-format] Add Basic Carbon Support/Infrastructure to clang-format". MyDeveloperDay added a comment. Improve the handling of gen

[PATCH] D134749: [clang][Interp] Implement Div opcode

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:181 + + + constexpr int LHS = 12; The only test coverage is for integer division; do you intend to also cover floating-point division? Repository: rG LLVM Github Monorepo C

[PATCH] D134744: [clang][Interp] Implement rem opcode

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:161 +// expected-note {{division by zero}} + + Same question here as with div in regards to testing float behavior. (If you don't intend t

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. //

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:161 +// expected-note {{division by zero}} + + aaron.ballman wrote: > Same question here as with div in regards to testing float behavior. (If yo

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. // -

[PATCH] D134744: [clang][Interp] Implement rem opcode

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:161 +// expected-note {{division by zero}} + + tbaeder wrote: > aaron.ballman wrote: > > Same question here as with div in regards to testi

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:641 return this->visitInitializer(DIE->getExpr()); + } else if (const auto AILE = dyn_cast(Initializer)) { +// TODO: This compiles to quite a lot of bytecode if the array is larger

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

tbaeder updated this revision to Diff 463515. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134804/new/ https://reviews.llvm.org/D134804 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:654-664 + if (!this->emitDupPtr(SubExpr)) +return false; + + if (!this->visit(SubExpr)) +return false; + + if (!this->emitI

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

aaron.ballman added a comment. Generally looks reasonable to me. Comment at: clang/test/AST/Interp/records.cpp:52 static_assert(!ints2.c, ""); constexpr Ints ints3 = getInts(); Can you think of a reasonable way for us to test that you're handling the RVO p

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. @sammccall ping, is the explanation above reasonable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 ___ cfe-commits mailing list cfe

[PATCH] D134057: [clang][Interp] Start implementing record types

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:689 +const Decl *Callee = CE->getCalleeDecl(); +const Function *Func = P.getFunction(dyn_cast(Callee)); + tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: >

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

aaron.ballman added a comment. Thank you for working on this! It looks pretty close to good, with just a few comments. Can you also add a release note for the changes as well (to clang/docs/ReleaseNotes.rst)? Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16733 + while (auto

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a comment. This looks reasonable to me but let's have another pair of eyes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 ___ cfe-co

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

tbaeder updated this revision to Diff 463522. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134361/new/ https://reviews.llvm.org/D134361 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:52 static_assert(!ints2.c, ""); constexpr Ints ints3 = getInts(); aaron.ballman wrote: > Can you think of a reasonable way for us to test that you're handling the RVO > pointer prop

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/AST/Interp/records.cpp:52 static_assert(!ints2.c, ""); constexpr Ints ints3 = getInts(); tbaeder wrote: > aaro

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134361/new/ https://reviews.llvm.org/D134361 ___ cfe-commits mailing lis

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:161 +// expected-note {{division by zero}} + + aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > Same question here as with di

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463531. mgorny marked 2 inline comments as done. mgorny added a comment. Swap driver and target config loading order. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

arichardson added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. // ---

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-

[PATCH] D134744: [clang][Interp] Implement rem opcode

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:161 +// expected-note {{division by zero}} + + tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder updated this revision to Diff 463543. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:161 +// expected-note {{division by zero}} + + aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463548. mgorny edited the summary of this revision. mgorny added a comment. Herald added subscribers: pcwang-thead, s.egerton, simoncook. Implement the backwards compatible logic for using name prefix if 1) no target override options are used, and 2) name pref

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added a comment. @sepavloff, @arichardson, does this approach look OK? I've included the cheribsd name in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list c

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske updated this revision to Diff 463575. balazske marked 6 inline comments as done. balazske added a comment. Implemented review comments, changed warning text, changed documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133119/new/

[clang] 3d20806 - [clang][DR2621] using enum NAME lookup fix

Author: Nathan Sidwell Date: 2022-09-28T08:50:27-07:00 New Revision: 3d2080683f1dc37010fb56cf7d0e1632cda00f15 URL: https://github.com/llvm/llvm-project/commit/3d2080683f1dc37010fb56cf7d0e1632cda00f15 DIFF: https://github.com/llvm/llvm-project/commit/3d2080683f1dc37010fb56cf7d0e1632cda00f15.diff

[PATCH] D134283: [clang][DR2621] using enum NAME lookup fix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d2080683f1d: [clang][DR2621] using enum NAME lookup fix (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ilya-biryukov added a comment. Is this the only thing that blocks D53847 ? I suggest to stamp this if so (happy to do it myself). In case @ChuanqiXu will have comments we can address them in post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3819109 , @mwyman wrote: > In D86049#3818981 , @plotfi wrote: > >> @ahatanak I can revive some of what I was working on from >> https://reviews.llvm.org/D86049?id=285923 if we thin

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight. Herald added subscribers: arphaman, delcypher. Herald added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. aaron.ballman requested review of this revision. Herald added proje

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov added a comment. In D126481#3818769 , @martong wrote: > Yeah okay. I get it now. Thank you for your patience and your time on > elaborating the issue. > > First, I think we'd need to fabricate a test case that shows us the bug even > with

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov added a comment. @martong > Then we can iterate onto the solution. What we could do is to collect the > constants and types on the way of the cast visitation and then apply the same > logic that you have in D103096 . Suppose we have found the way

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added inline comments. Comment at: clang/test/ExtractAPI/enum.c:3 // RUN: split-file %s %t -// RUN: sed -e "s@INPUT_DIR@%{/t:regex_replacement}@g" \ +// RUN: sed -e "s@INPUT_FILE@%/et/input.h@g" -e "s@INPUT_DIR@%{/t:regex_replacement}@g" \ // RUN: %t/reference.ou

[clang] 44ad670 - [clang][msan] Turn on -fsanitize-memory-param-retval by default

Author: Arthur Eubanks Date: 2022-09-28T09:36:39-07:00 New Revision: 44ad67031cc1a10483337f8b1f728e2be237685e URL: https://github.com/llvm/llvm-project/commit/44ad67031cc1a10483337f8b1f728e2be237685e DIFF: https://github.com/llvm/llvm-project/commit/44ad67031cc1a10483337f8b1f728e2be237685e.diff

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG44ad67031cc1: [clang][msan] Turn on -fsanitize-memory-param-retval by default (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/ne

[clang] 4824059 - Moving some C papers around on the status page; NFC

Author: Aaron Ballman Date: 2022-09-28T12:37:52-04:00 New Revision: 4824059c1a7d1b03c0e01b4ba4b0c53305e22d0a URL: https://github.com/llvm/llvm-project/commit/4824059c1a7d1b03c0e01b4ba4b0c53305e22d0a DIFF: https://github.com/llvm/llvm-project/commit/4824059c1a7d1b03c0e01b4ba4b0c53305e22d0a.diff

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. Moving this to a top level discussion because it's easier to write replies here than in an inline comment. >> If it's that the tool is trying to get the type information purely from the >> string representation, maybe the tool should be doing things differently - >> r

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Decl.cpp:4480 + // the tag is anonymous and we should print it differently. + if (Name.isIdentifier() && !Name.getAsIdentifierInfo()

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1515 +// This is a temporary fix while we don't support C2x 6.5.2.5p4 +if (getLangOpts().C2x && GetLookAheadToken(2).getKind() == tok::l_brace) { + Diag(Tok, diag::err_c2x_auto_compound_li

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 ___ cfe-commits mailing list cfe-

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ayzhao added a comment. In D134578#3821178 , @ilya-biryukov wrote: > Is this the only thing that blocks D53847 ? > I suggest to stamp this if so (happy to do it myself). In case @ChuanqiXu > will have comments we can add

[clang] 6f2b347 - Add missing `struct` keyword to the test p2-2.cpp

Author: Alan Zhao Date: 2022-09-28T09:48:00-07:00 New Revision: 6f2b34789541ff95d7f339eac5dc031d29655a58 URL: https://github.com/llvm/llvm-project/commit/6f2b34789541ff95d7f339eac5dc031d29655a58 DIFF: https://github.com/llvm/llvm-project/commit/6f2b34789541ff95d7f339eac5dc031d29655a58.diff LOG

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2b34789541: Add missing `struct` keyword to the test p2-2.cpp (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134578/new/ https://revi

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

ahatanak added a comment. In D86049#3819109 , @mwyman wrote: > In D86049#3818981 , @plotfi wrote: > >> @ahatanak I can revive some of what I was working on from >> https://reviews.llvm.org/D86049?id=285923 if we th

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

aaron.ballman added a comment. In D134578#3821301 , @ayzhao wrote: > In D134578#3821178 , @ilya-biryukov > wrote: > >> Is this the only thing that blocks D53847 ? >> I suggest to

[clang] 4848f3b - [C++2a] P0634r3: Down with typename!

Author: Nicolas Lesser Date: 2022-09-28T09:50:19-07:00 New Revision: 4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735 URL: https://github.com/llvm/llvm-project/commit/4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735 DIFF: https://github.com/llvm/llvm-project/commit/4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735.diff

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4848f3bf2ff5: [C++2a] P0634r3: Down with typename! (authored by Rakete, committed by ayzhao). Changed prior to commit: https://reviews.llvm.or

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:649 + +if (!ElemT) + return false; Curious what case requires this check? Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:382 + ByteCodeExprGen *Ctx

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:649 + +if (!ElemT) + return false; shafik wrote: > Curious what case requires this check? I don't think there's a real test case for this, we could as well change the in

[PATCH] D134815: [Sema] print more readable identifier of anonymous struct of -Wconsumed

inclyc created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. inclyc published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Working in D133574 we discovered -Wconsumed print

[PATCH] D134815: [Sema] print more readable identifier of anonymous struct of -Wconsumed

aaron.ballman added a comment. FWIW, I approached this in a slightly different way here: https://reviews.llvm.org/D134813 -- I've not landed it yet because I'm still hoping I can find a way to not modify lit just to fix one fragile test, but I think we ultimately want to go this other route bec

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3821183 , @plotfi wrote: > In D86049#3819109 , @mwyman wrote: > >> In D86049#3818981 , @plotfi wrote: >> >>> @ahatanak I can revive some of

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

shafik added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:72 +static_assert(~-1 == 0, ""); +static_assert(~255 == -256, ""); + Some more tests covering `~INT_MIN == INT_MAX` and vice versa and unscoped enum case as well e.g. ``` enum E {}; E

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134804/new/ https://reviews.llvm.org/D134804 ___ cfe-commits mailing list cfe

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

msebor updated this revision to Diff 463607. msebor marked an inline comment as done. msebor added a comment. Changes from previous version: - Replace loop with `Expr::IgnoreImpCasts()`. - Use a multiline comment in a test to improve readability. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

msebor added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16733 + while (auto *BaseCast = dyn_cast(BaseExpr)) +BaseExpr = BaseCast->getSubExpr(); +} aaron.ballman wrote: > tbaeder wrote: > > There is `Expr::ignoreParenImpCasts()` o

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:363 const StringRef TripleStr = GCCInstallation.getTriple().str(); - const Multilib &Multilib = GCCInstallation.getMultilib(); + std::string Path = (InstallDir + "/../../../../" + Triple

[clang] 60727d8 - [C2x] implement typeof and typeof_unqual

Author: Aaron Ballman Date: 2022-09-28T13:27:52-04:00 New Revision: 60727d856927383daf304fcf8f19fcc8ade828ad URL: https://github.com/llvm/llvm-project/commit/60727d856927383daf304fcf8f19fcc8ade828ad DIFF: https://github.com/llvm/llvm-project/commit/60727d856927383daf304fcf8f19fcc8ade828ad.diff

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60727d856927: [C2x] implement typeof and typeof_unqual (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >