shafik added inline comments.
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:649 + + if (!ElemT) + return false; ---------------- Curious what case requires this check? ================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:382 + ByteCodeExprGen<Emitter> *Ctx; + Optional<uint64_t> OldArrayIndex; +}; ---------------- Why an `Optional`? Your not checking it and I don't see how it won't be set? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134361/new/ https://reviews.llvm.org/D134361 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
