This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2b34789541: Add missing `struct` keyword to the test p2-2.cpp (authored by ayzhao).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134578/new/ https://reviews.llvm.org/D134578 Files: clang/test/CXX/module/module.interface/p2-2.cpp Index: clang/test/CXX/module/module.interface/p2-2.cpp =================================================================== --- clang/test/CXX/module/module.interface/p2-2.cpp +++ clang/test/CXX/module/module.interface/p2-2.cpp @@ -14,7 +14,7 @@ U bar(); }; -export template <typename T> X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} +export template <typename T> struct X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} export template <typename T> void X<T>::foo(); // expected-error {{cannot export 'foo' as it is not at namespace scope}} export template <typename T> template <typename U> U X<T>::bar(); // expected-error {{cannot export 'bar' as it is not at namespace scope}} @@ -32,6 +32,6 @@ export template <typename U> U Y::bar(); // expected-error {{cannot export 'bar' as it is not at namespace scope}} export { - template <typename T> X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} - struct Y::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} + template <typename T> struct X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} + struct Y::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} }
Index: clang/test/CXX/module/module.interface/p2-2.cpp =================================================================== --- clang/test/CXX/module/module.interface/p2-2.cpp +++ clang/test/CXX/module/module.interface/p2-2.cpp @@ -14,7 +14,7 @@ U bar(); }; -export template <typename T> X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} +export template <typename T> struct X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} export template <typename T> void X<T>::foo(); // expected-error {{cannot export 'foo' as it is not at namespace scope}} export template <typename T> template <typename U> U X<T>::bar(); // expected-error {{cannot export 'bar' as it is not at namespace scope}} @@ -32,6 +32,6 @@ export template <typename U> U Y::bar(); // expected-error {{cannot export 'bar' as it is not at namespace scope}} export { - template <typename T> X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} - struct Y::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} + template <typename T> struct X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} + struct Y::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}} }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits