msebor added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16733 + while (auto *BaseCast = dyn_cast<ImplicitCastExpr>(BaseExpr)) + BaseExpr = BaseCast->getSubExpr(); + } ---------------- aaron.ballman wrote: > tbaeder wrote: > > There is `Expr::ignoreParenImpCasts()` or `Expr::ImpCasts()` that should do > > this loop for you. > +1, I would use `Expr::IgnoreImpCasts()` instead of this manual loop. Sure. Thank you both for the suggestion! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134311/new/ https://reviews.llvm.org/D134311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
