[clang-tools-extra] 5331e12 - [clang][transformer] Fix crash on replacement-less ASTEdit.

Author: Clement Courbet Date: 2022-08-10T09:08:05+02:00 New Revision: 5331e1229aa6d0d33b5ec9fab7c05310187746d9 URL: https://github.com/llvm/llvm-project/commit/5331e1229aa6d0d33b5ec9fab7c05310187746d9 DIFF: https://github.com/llvm/llvm-project/commit/5331e1229aa6d0d33b5ec9fab7c05310187746d9.dif

[PATCH] D128887: [clang][transformer] Fix crash on replacement-less ASTEdit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5331e1229aa6: [clang][transformer] Fix crash on replacement-less ASTEdit. (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple x86_64-unknown-unkno

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson updated this revision to Diff 451376. royjacobson added a comment. Don't regress on invalid (non-dependent) friend destructor declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ https://reviews.llvm.org/D131541 File

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson added a subscriber: hubert.reinterpretcast. royjacobson added a comment. Hi @hubert.reinterpretcast, thanks for the quick catch! I have posted this initial patch, but it still misses the case template struct E { friend T::S::~V(); }; Something goes wrong there that I have

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

awarzynski added a comment. Many thanks for implementing this! I've only skimmed through so far, but mostly makes sense. Will take a closer look later. Could you update the summary by adding more detail? What options are enabled and whether the semantics from Clang are preserved or not (they sh

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 451377. MaskRay added a comment. fix some tests in a better way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files: clang/lib/Basic/LangStandards.cpp clang/tes

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

RKSimon added a comment. Are you intending to AutoUpgrade the existing intrinsics in IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131547/new/ https://reviews.llvm.org/D131547 ___ cfe-commits mailing

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

domada added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2598 for (OMPClause *C : S.clauses()) { // Currently only simdlen clause is supported +if (!(isa(C) || isa(C))) Could you update this comment? Comment at:

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:379 + /// Shared implementation of `pushCall` overloads. + void pushCallInternal(const FunctionDecl *FuncDecl, +Arra

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9114 + unsigned int MinElts = SrcTy->getElementCount().getKnownMinValue(); + Value *Call = llvm::UndefValue::get(VTy); + for (unsigned int I = 0; I < Ops.size(); I++) { Please use Poison

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. Still LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.h:2 +//===--- BareMetal.h - Bare Metal Tool and ToolChain -*- C++ +//-*-===// // Line overflowed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

ygribov added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131448/new/ https://reviews.llvm.org/D131448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3710656 , @erichkeane wrote: > Ok, fixed the test failure in clang, AND it managed to fix > all the failures in libcxx! > > HOWEVER, it appears that libcxx/test/libcxx/modules_include.sh.cpp > is now hanging? > > I

[PATCH] D131553: [analyzer] exploded-graph-rewriter: Fix python3 string encoding issues

steakhal created this revision. steakhal added reviewers: NoQ, martong, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa772f775a2ba: [clang-tidy] Support C++14 in bugprone-signal-handle

[clang-tools-extra] a772f77 - [clang-tidy] Support C++14 in bugprone-signal-handler.

Author: Balázs Kéri Date: 2022-08-10T12:00:16+02:00 New Revision: a772f775a2ba401e95a0bbe73deb6300f1dc12c0 URL: https://github.com/llvm/llvm-project/commit/a772f775a2ba401e95a0bbe73deb6300f1dc12c0 DIFF: https://github.com/llvm/llvm-project/commit/a772f775a2ba401e95a0bbe73deb6300f1dc12c0.diff L

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij created this revision. Herald added a project: All. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a crash when trying to emit a constant compound literal. For C++ Clang evaluates either casts or binary operat

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D131479: Handle explicitly defaulted consteval special members.

ilya-biryukov added a comment. Should we follow suggestion from CWG Issue 2602 to fix this instead? I think the trick is to keep the constructor consteval, but complain when processing its call, e.g. somewhere around `HandleCon

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

simon_tatham added a comment. The clang code change looks reasonable to me, but I'm not the most expert in that area. The intended result certainly seems sensible, because the C90-compatible version of that code //without// a constant literal is happy to do double→float conversion at compile t

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc added a comment. @aaron.ballman @shafik (Help wanted). These type traits will not cause clang to crash if current patch applied, but the `bool x` in that test case will evaluate to `false`. I think the problem behind the github issue is that we don't check the number of arguments for b

[clang] 286d59e - [clang][AArch64][SVE] Add unary +/- operators for SVE types

Author: David Truby Date: 2022-08-10T10:32:43Z New Revision: 286d59ef6f7118c8a0600f3d281593700528a5d3 URL: https://github.com/llvm/llvm-project/commit/286d59ef6f7118c8a0600f3d281593700528a5d3 DIFF: https://github.com/llvm/llvm-project/commit/286d59ef6f7118c8a0600f3d281593700528a5d3.diff LOG: [

[PATCH] D130984: [clang][AArch64][SVE] Add unary +/- operators for SVE types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG286d59ef6f71: [clang][AArch64][SVE] Add unary +/- operators for SVE types (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

kadircet added a comment. I agree with Nathan to some extent that this doesn't carry as much weight, but if we can get it without introducing much complexity to the user (i.e. a new modifier they need to remember), it's worth having since we don't need too much effort to support it.

[PATCH] D130974: [analyzer] Fix for the crash in #56873

steakhal added a comment. In D130974#3709502 , @isuckatcs wrote: >> Some checker should have caught the uninitialized value earlier than the >> defaultEvalCall(). >> I guess, the MallocCkecher could have checked for it in PreStmt. >> Or alternatively, th

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

wyt updated this revision to Diff 451411. wyt added a comment. Relocate function and fix comment for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131065/new/ https://reviews.llvm.org/D131065 Files: clang/include/clang/Analysis/Flow

[clang] 8a4c40b - [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

Author: Wei Yi Tee Date: 2022-08-10T11:27:03Z New Revision: 8a4c40bfe8e6605ffc9d866f8620618dfdde2875 URL: https://github.com/llvm/llvm-project/commit/8a4c40bfe8e6605ffc9d866f8620618dfdde2875 DIFF: https://github.com/llvm/llvm-project/commit/8a4c40bfe8e6605ffc9d866f8620618dfdde2875.diff LOG: [c

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a4c40bfe8e6: [clang][dataflow] Store DeclContext of block being analysed in Environment if… (authored by wyt). Repository: rG LLVM Github Monorep

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler updated this revision to Diff 451420. ckandeler marked an inline comment as done. ckandeler added a comment. Fixed style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llvm.org/D130015 Files: clang-to

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:603 H.addExtraModifier(*Location, - HighlightingModifier::UsedAsMutableReference); + IsRef ? HighlightingModifier::UsedAsMutableRe

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9077 +Value *CodeGenFunction::EmmitSVESetTuples(const SVETypeFlags &TypeFlags, + llvm::Type *Ty, nit: s/Emmit/Emit/ How about naming these: *

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

RKSimon added a comment. @balazske This is failing on https://lab.llvm.org/buildbot/#/builders/139/builds/26335 - do you have a fix in progress or should I revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet updated this revision to Diff 451425. courbet added a comment. Replace both versions of `withNote()` with a single `ASTEdit note()` generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128807/new/ https://reviews.llvm.org/D128807 Files

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet added a comment. Thanks for the comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:250-251 +// Adds a note to the given edit or edits. If there are several edits, the note +// is added to each one of them. +// \code ymandel wr

[PATCH] D131563: [clang] Fix clang multiarch isssue with musl

listout created this revision. listout added reviewers: dlj, atanasyan, MaskRay, Bdragon28. Herald added subscribers: StephenFan, pengfei, fedor.sergeev, kristof.beyls. Herald added a project: All. listout requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D131563: [clang] Fix clang multiarch isssue with musl

listout added a comment. The patch needs some rework for 15.x and above version. If people think it's appropriate then I'll be glad to make the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131563/new/ https://reviews.llvm.org/D131563 ___

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. I didn't do a full review because I spotted enough concerns that we might want to talk about the approach more first. I think the goal should be to avoid adding a `-std=` to any RUN line unless the test really requires it. I spotted a lot of instances where we wen

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

erichkeane accepted this revision. erichkeane added a comment. Yep, looks fine to me. We might consider adding an additional warning-as-warning for the alternative case (could you put a comment on this 'if' statement to that effect?). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1315

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451432. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/lib

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 added a comment. As discussed offline, we are already following the discussion 2602 . We are keeping the constructor `consteval` to allow complaining when we are actually processing the call to data member constructors

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3711956 , @ChuanqiXu wrote: > In D126907#3710656 , @erichkeane > wrote: > >> Ok, fixed the test failure in clang, AND it managed to fix >> all the failures in libcxx! >> >>

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. I'm not a git expert by any means, but you might be able to address the patch issues with `git diff -U999 main > foo.patch` from the root llvm-project directory so that you're getting a diff with 999 lines of context and the differences are against the `main` bran

[PATCH] D128095: clang: fix checking parameter packs for expansion

erichkeane added a comment. Can you make a better commit message? I don't have a good idea of the intent/description of what you're trying to do here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 ___

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. In D126676#3703024 , @jansvoboda11 wrote: > Also, I'd like to test this patch internally to see if it affects anything on > our end. I should be able to do so next week. Ping @jansvoboda11 - any update on testing this? Repos

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 _

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

erichkeane added a comment. This is a sizable patch, and it isn't really clear from context what I'm looking at. Can you please improve the description/commit message to better clarify what you are trying to do, what you did, and how you are trying to accomplish it? Repository: rG LLVM Git

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo updated this revision to Diff 451434. mstorsjo added a comment. Rebased, to fix (trivial) conflicts in the release notes file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126676/new/ https://reviews.llvm.org/D126676 Files: clang/docs/

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3045 + if (!(Simdlen == nullptr && Safelen == nullptr)) { +ConstantInt *VectorizeWidth = Simdlen == nullptr ? Safelen : Simdlen; addLoopMetadata( domada wrote: > Coul

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

davrec added inline comments. Comment at: clang/test/Sema/Resugar/resugar-expr.cpp:244 +// N-error@-2 {{with an rvalue of type 'int'}} +} // namespace t21 Compositions of MemberExprs/CXXMemberCallExprs have an issue: ``` template struct A { struct Inner {

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

arnamoy10 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3045 + if (!(Simdlen == nullptr && Safelen == nullptr)) { +ConstantInt *VectorizeWidth = Simdlen == nullptr ? Safelen : Simdlen; addLoopMetadata( psoni2628 wrote: > d

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3711956 , @ChuanqiXu wrote: > In D126907#3710656 , @erichkeane > wrote: > >> Ok, fixed the test failure in clang, AND it managed to fix >> all the failures in libcxx! >> >>

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:379 + /// Shared implementation of `pushCall` overloads. + void pushCallInternal(const FunctionDecl *FuncDecl, +ArrayRef Args);

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep updated this revision to Diff 451445. samestep added a comment. Address Stanislav's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131438/new/ https://reviews.llvm.org/D131438 Files: clang/include/clang/Analysis/FlowSensitive/Da

[clang] 000c8fe - [clang][dataflow] Analyze constructor bodies

Author: Sam Estep Date: 2022-08-10T14:01:45Z New Revision: 000c8fef86abb7f056cbea2de99f21dca4b81bf8 URL: https://github.com/llvm/llvm-project/commit/000c8fef86abb7f056cbea2de99f21dca4b81bf8 DIFF: https://github.com/llvm/llvm-project/commit/000c8fef86abb7f056cbea2de99f21dca4b81bf8.diff LOG: [cl

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG000c8fef86ab: [clang][dataflow] Analyze constructor bodies (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:150 +[{isa(S)}], +"global functions">; This string literal looks suspiciously wrong to me. This is the text that shows up in a diagnostic

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added a comment. In D118996#3712218 , @RKSimon wrote: > @balazske This is failing on > https://lab.llvm.org/buildbot/#/builders/139/builds/26335 - do you have a fix > in progress or should I revert? Fix is not in progress, it may take some day

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 451449. psoni2628 added a comment. - Add comments based on reviewer's feedback - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irb

[clang] e4642d7 - [clang] Correct documentation for NEON and SVE operator support

Author: David Truby Date: 2022-08-10T15:16:38+01:00 New Revision: e4642d78a89930720bc84a4775614c45327bc0dc URL: https://github.com/llvm/llvm-project/commit/e4642d78a89930720bc84a4775614c45327bc0dc DIFF: https://github.com/llvm/llvm-project/commit/e4642d78a89930720bc84a4775614c45327bc0dc.diff L

[PATCH] D131479: Handle explicitly defaulted consteval special members.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side. Thanks for explaining, I was confused because I looked at the code right after defaulted check and thought we were working around that particular error. Turns

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

CarolineConcatto added a comment. > Are you intending to AutoUpgrade the existing intrinsics in IR? @RKSimon AFAIK we want to remove them altogether. It is not expected that external projects depend on these intrinsics. It is a legacy intrinsic that was introduced before we had vector.extract

[clang-tools-extra] 2534041 - Revert rGa772f775a2ba401e95a0bbe73deb6300f1dc12c0 "[clang-tidy] Support C++14 in bugprone-signal-handler."

Author: Simon Pilgrim Date: 2022-08-10T15:25:04+01:00 New Revision: 25340410c9a574d438b8868630fc8a9297d03dd7 URL: https://github.com/llvm/llvm-project/commit/25340410c9a574d438b8868630fc8a9297d03dd7 DIFF: https://github.com/llvm/llvm-project/commit/25340410c9a574d438b8868630fc8a9297d03dd7.diff

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

zatrazz added a comment. It does help on test-suite, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/ https://reviews.llvm.org/D131528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

listout updated this revision to Diff 451452. listout added a comment. Herald added subscribers: pcwang-thead, luke957, s.egerton, simoncook. Less drastic changes and rebased with main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131563/new/ https://reviews.llvm.org/D131563 Files: c

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.

[PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. Re rollout: I suggested further up to put this behind an opt-in variable. That would've allowed people to test this on their setups. I still think that's a good suggestion, and it would've identified the MSVC issue at least. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

andrewng added a comment. In D118996#3712493 , @balazske wrote: > In D118996#3712218 , @RKSimon wrote: > >> @balazske This is failing on >> https://lab.llvm.org/buildbot/#/builders/139/builds/26335 - do you have

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

listout updated this revision to Diff 451459. listout added a comment. Fix missing '+' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131563/new/ https://reviews.llvm.org/D131563 Files: clang/lib/Driver/ToolChains/Linux.cpp Index: clang/lib/Driver/ToolChains/Linux.cpp ==

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3029-3032 +addLoopMetadata( +CanonicalLoop, +MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.parallel_accesses"), + AccessGroup})); ---

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko updated this revision to Diff 451464. ivanmurashko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/lib/Basic/SourceManager.cpp Index: clang/lib/Basic/

[PATCH] D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The __ARM_FEAT

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

RKSimon added a comment. In D131547#3712509 , @CarolineConcatto wrote: >> Are you intending to AutoUpgrade the existing intrinsics in IR? > > @RKSimon > AFAIK we want to remove them altogether. > It is not expected that external projects depend on the

[PATCH] D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

peterwaller-arm requested changes to this revision. peterwaller-arm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/AArch64.cpp:493 + // C/C++ operators work on both VLS and VLA SVE types + if (FPU & SveMode) +Builde

[PATCH] D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

peterwaller-arm accepted this revision. peterwaller-arm added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/AArch64.cpp:493 + // C/C++ operators work on both VLS and VLA SVE types + if (FPU & SveMode) +Builder.defineMa

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

mizvekov added inline comments. Comment at: clang/test/Sema/Resugar/resugar-expr.cpp:244 +// N-error@-2 {{with an rvalue of type 'int'}} +} // namespace t21 davrec wrote: > Compositions of MemberExprs/CXXMemberCallExprs have an issue: > ``` > template struct A {

[PATCH] D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture

kito-cheng added a comment. I guess we should checking `J` extension is enabled somewhere when user trying to enable HWASAN? or checking that at HWASAN library at run-time? otherwise my understanding is user will get crash when enabling HWASAN if linux and/or HW don't support that? Repository

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. Hi - I tried to incorporate all the feedback here and added a post to discourse suggesting tweaks to the developer policy - please have a look and review it: https://discourse.llvm.org/t/rfc-updates-to-developer-policy-around-c-standards-bump/64383 Repository: rG LLVM

[clang] e78c80e - [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

Author: Ivan Murashko Date: 2022-08-10T16:37:42+01:00 New Revision: e78c80e3d622d455934102dabd765a60ac917739 URL: https://github.com/llvm/llvm-project/commit/e78c80e3d622d455934102dabd765a60ac917739 DIFF: https://github.com/llvm/llvm-project/commit/e78c80e3d622d455934102dabd765a60ac917739.diff

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rGe78c80e3d622: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of… (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D90275: [clang][IR] Add support for leaf attribute

nlopes added a comment. In D90275#3707793 , @nlopes wrote: > In D90275#3671983 , @gulfem wrote: > >> In D90275#3671019 , @nlopes wrote: >> >>> Could you please add a descript

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

mgabka created this revision. mgabka added a reviewer: paulwalker-arm. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. mgabka requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 451500. psoni2628 added a comment. - Add LoopMDList CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_safelen.cpp clang/test/Open

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. In D90275#3712880 , @nlopes wrote: > In D90275#3707793 , @nlopes wrote: > >> In D90275#3671983 , @gulfem wrote: >> >>> In D90275#3671019

[PATCH] D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture

smd added a comment. In D131345#3712814 , @kito-cheng wrote: > I guess we should checking `J` extension is enabled somewhere when user > trying to enable HWASAN? or checking that at HWASAN library at run-time? > otherwise my understanding is user will

[PATCH] D90275: [clang][IR] Add support for leaf attribute

nlopes added a comment. In D90275#3712969 , @gulfem wrote: > In D90275#3712880 , @nlopes wrote: > >> In D90275#3707793 , @nlopes wrote: >> >>> In D90275#3671983

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

sberg added a comment. With this commit, $ cat test.cc #include "boost/numeric/conversion/cast.hpp" int main() { return boost::numeric_cast(0L); } $ clang++ test.cc succeeds without any diagnostic, while with its parent commit https://github.com/llvm/llvm-project/commit/b364535304181

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. In D90275#3712991 , @nlopes wrote: > In D90275#3712969 , @gulfem wrote: > >> In D90275#3712880 , @nlopes wrote: >> >>> In D90275#3707793

[PATCH] D130974: [analyzer] Fix for the crash in #56873

isuckatcs added a comment. > If so, shouldn't be some dependencies across these revisions? I don't think they are that closely related. This patch is about fixing an assertion failure. This assertion failure happens because we don't handle a case not because the checker doesn't exist. Also the

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

paulwalker-arm added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1285 OS << "#endif\n\n"; + OS << "#undef __ai\n\n"; OS << "#endif /*__ARM_FEATURE_SVE */\n\n"; Can you also do this for `__aio`? Repository: rG LLVM Github Monorepo

[clang] 06fc5a7 - Driver: Refactor and support per target dirs in baremetal

Author: Manoj Gupta Date: 2022-08-10T09:13:30-07:00 New Revision: 06fc5a7714621324b121fb3ee03ac15eb018cf99 URL: https://github.com/llvm/llvm-project/commit/06fc5a7714621324b121fb3ee03ac15eb018cf99 DIFF: https://github.com/llvm/llvm-project/commit/06fc5a7714621324b121fb3ee03ac15eb018cf99.diff L

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

This revision was automatically updated to reflect the committed changes. Closed by commit rG06fc5a771462: Driver: Refactor and support per target dirs in baremetal (authored by manojgupta). Changed prior to commit: https://reviews.llvm.org/D131225?vs=451352&id=451517#toc Repository: rG LLVM

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: aaron.ballman, ivanmurashko, njames93. vladimir.plyashkun added a project: clang-tools-extra. Herald added a project: All. vladimir.plyashkun requested review of this revision. Herald added a subscriber: cfe-commits. It

[PATCH] D131514: [analyzer] [NFC] Add more test cases for equality tracking

ASDenysPetrov updated this revision to Diff 451527. ASDenysPetrov added a comment. C-standard does not support templates. Replaced function template with the function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131514/new/ https://reviews.llvm.org/D131514 Files: clang/test/Analys

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. Prabhuk requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131

[clang] 7e2b995 - [analyzer] [NFC] Add more test cases for equality tracking

Author: Denys Petrov Date: 2022-08-10T19:52:55+03:00 New Revision: 7e2b995e0cced8a292c3de9e4ec6a503223de38a URL: https://github.com/llvm/llvm-project/commit/7e2b995e0cced8a292c3de9e4ec6a503223de38a DIFF: https://github.com/llvm/llvm-project/commit/7e2b995e0cced8a292c3de9e4ec6a503223de38a.diff

[PATCH] D131514: [analyzer] [NFC] Add more test cases for equality tracking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e2b995e0cce: [analyzer] [NFC] Add more test cases for equality tracking (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker added a comment. Pinging this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

ilya-biryukov added a comment. Could you please add a test with a compilation database that models the blocking behavior, attempts cancellation and ensures no diagnostics are produced? I also suggest adding a callback similar to `Callbacks.onFailedAST`, which could be used for testing this beha

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

ayermolo added a comment. Thanks for reverting this. Previous commit broke build of projects using fmt library. https://github.com/fmtlib/fmt/blame/master/include/fmt/format.h fmt/fmt/include/fmt/format.h:1904:9: error: cannot capture a bit-field by reference if (sign) *it++ = detail::s

  1   2   3   >