erichkeane accepted this revision.
erichkeane added a comment.

Yep, looks fine to me.  We might consider adding an additional 
warning-as-warning for the alternative case (could you put a comment on this 
'if' statement to that effect?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131528/new/

https://reviews.llvm.org/D131528

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to