samestep added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:379 + /// Shared implementation of `pushCall` overloads. + void pushCallInternal(const FunctionDecl *FuncDecl, + ArrayRef<const Expr *> Args); ---------------- sgatev wrote: > Let's add a note that unlike `pushCall`, this member is invoked on the > environment of the callee. Will do, thanks! ================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:380 + void pushCallInternal(const FunctionDecl *FuncDecl, + ArrayRef<const Expr *> Args); + ---------------- sgatev wrote: > `#include "llvm/ADT/ArrayRef.h"` When I add this, I get a warning: "Included header `ArrayRef.h` is not used directly" ================ Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:667-670 + const ControlFlowContext *CFCtx = Env.getControlFlowContext(F); + + if (!CFCtx) + return; ---------------- sgatev wrote: > đź‘Ť Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131438/new/ https://reviews.llvm.org/D131438 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
