[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 450243. python3kgae added a comment. Rebase and fix test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files: clang/include/clang/Basic/TargetOptions.h

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added a comment. In D130754#3701837 , @nikic wrote: > This change caused a significant compile-time regression for `O0` builds > (about 1%): > http://llvm-compile-time-tracker.com/compare.php?from=45bae1be90472c696f6ba3bb4f8fabee76040fa9&to=6f86

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c106c93eb68: [clangd] Change the url for clang-tidy check documentation (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ h

[clang-tools-extra] 4c106c9 - [clangd] Change the url for clang-tidy check documentation

Author: Nathan James Date: 2022-08-05T08:42:52+01:00 New Revision: 4c106c93eb68f8f9f201202677cd31e326c16823 URL: https://github.com/llvm/llvm-project/commit/4c106c93eb68f8f9f201202677cd31e326c16823 DIFF: https://github.com/llvm/llvm-project/commit/4c106c93eb68f8f9f201202677cd31e326c16823.diff

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

v.g.vassilev added a comment. Maybe we can add a little more context. In the case of static compilation the file system is pretty much read-only and taking a snapshot of it usually is sufficient. In the interactive C++ case the compilation is longer and people can create and include files, etc.

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added a comment. In D130754#3701858 , @pengfei wrote: > In D130754#3701837 , @nikic wrote: > >> This change caused a significant compile-time regression for `O0` builds >> (about 1%): >> http://llvm-comp

[clang] 501faaa - [clang][analyzer] Add more wide-character functions to CStringChecker

Author: Balázs Kéri Date: 2022-08-05T10:32:53+02:00 New Revision: 501faaa0d65e9814566ef65e58d834c13b8a URL: https://github.com/llvm/llvm-project/commit/501faaa0d65e9814566ef65e58d834c13b8a DIFF: https://github.com/llvm/llvm-project/commit/501faaa0d65e9814566ef65e58d834c13b8a.diff L

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG501faaa0d65e: [clang][analyzer] Add more wide-character functions to CStringChecker (authored by balazske). Repository: rG LLVM Github Monorepo C

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

LiuChen3 added a comment. In D131134#3699742 , @craig.topper wrote: > How does this interact with `-march=native -m32`. Won't that pick up the amx > flag from CPUID? In D131134#3699344 , @aaron.ballman wrote

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

LiuChen3 added a comment. In D131134#3699742 , @craig.topper wrote: > How does this interact with `-march=native -m32`. Won't that pick up the amx > flag from CPUID? Good point. I will continue the work. Repository: rG LLVM Github Monorepo CHANGES

[clang] 809b416 - [NFC] Requires x86-registered-target for test/pr56919.cpp

Author: Chuanqi Xu Date: 2022-08-05T16:46:38+08:00 New Revision: 809b4166413f157ce8e45ba0f80438701bf2e133 URL: https://github.com/llvm/llvm-project/commit/809b4166413f157ce8e45ba0f80438701bf2e133 DIFF: https://github.com/llvm/llvm-project/commit/809b4166413f157ce8e45ba0f80438701bf2e133.diff LO

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 450259. yurai007 added a comment. Fix std::initializer_list lifetime issue in test case revealed on CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130268/new/ https://reviews.llvm.org/D130268 Files: llvm/

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added a comment. IMO the relevant point is the (non-)const-ness of the corresponding parameter, i.e. can the passed object get mutated or not. The fact that there's an ampersand at the call site (which is not even the case if the variable is itself a pointer) does not tell me that.

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

steakhal added a comment. Please, consider stating the motivation behind this change. For me, by looking at the modified test, it feels like we would lose legitimate findings (aka. true-positive reports) by applying this change. From my perspective, the store to `i` is //dead//, since it will be

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

aaron.ballman added a comment. This seems like a reasonable set of changes, but I'd prefer someone more well-versed in codegen make the final call. Comment at: clang/lib/CodeGen/TargetInfo.h:63 + /// Returns Swift ABI info helper for the target. + const SwiftABIInfo &getSwif

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd31a689844: [NFC] Add SmallVector constructor to allow creation of SmallVector from… (authored by yurai007). Repository: rG LLVM Github Monor

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

steakhal added inline comments. Comment at: clang/test/Analysis/dead-stores.cpp:225 +void functionReferenceParameter(int &i) { + i = 5; // no warning +} By checking it on godbolt, this line never raised a warning. https://godbolt.org/z/n7fP5od5q You must be ref

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:537-539 + auto *Caller = Env.getDeclCtx(); + Env = Environment(ExitState->Env); + Env.setDeclCtx(Caller); I believe you'll need t

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

aaron.ballman added a comment. > Undefined macros evaluate to zero, so when checking for a smaller value, we > need to include the case when the macro is undefined. The code being changed already checks `defined(__cplusplus)` so there no undefined macro value being tested. What's more, if `__cp

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:63 + /// Returns Swift ABI info helper for the target. + const SwiftABIInfo &getSwiftABIInfo() const { return *SwiftInfo; } + aaron.ballman wrote: > `SwiftInfo` isn't always initiali

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

aaron.ballman updated this revision to Diff 450271. aaron.ballman added a comment. Improved from review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131194/new/ https://reviews.llvm.org/D131194 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGExprConstant.cpp cla

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

aaron.ballman added a comment. In D131194#3700688 , @efriedma wrote: > Instead of trying to dig through subexpressions of the ConstantExpr to try to > infer the type we need, can we just compute it directly? > > QualType RetType = CE->getType(); > if

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

hokein added a comment. +1 on downgrading to a warning, so that users can have time to do cleanup on their codebase. We also see internal breakages caused by this change. It breaks some code using the magic_enum library, a simple repro example: #inclu

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong created this revision. ShawnZhong added a reviewer: rsmith. ShawnZhong added a project: clang. Herald added a project: All. ShawnZhong requested review of this revision. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/53253 Repository: rG LLVM

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added reviewers: erichkeane, cjdb, clang-language-wg, jyknight. aaron.ballman added a comment. In D130894#3701749 , @tbaeder wrote: > For the record, the output now looks something like this: > > test.cpp:24:1: error: static assertion fail

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong updated this revision to Diff 450274. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131255/new/ https://reviews.llvm.org/D131255 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/constant-conversion.c Index: clang/test/Sema/con

[PATCH] D130894: [clang] Print more information about failed static assertions

xbolva00 added a comment. or test.cpp:25:17: note: evaluated expression: '0' > 'a' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added reviewers: aaron.ballman, clang-language-wg. aaron.ballman added a comment. Thank you for working on this! I think this is going in the right direction, but I think there's some more work needed here because the rules depend on the type of the bit-field (at least in C, I've n

[clang] 4bc9e60 - Removing redundant code; NFC

Author: Aaron Ballman Date: 2022-08-05T09:17:20-04:00 New Revision: 4bc9e603065b59976f3a16b7ecc6b5fb109f5f2d URL: https://github.com/llvm/llvm-project/commit/4bc9e603065b59976f3a16b7ecc6b5fb109f5f2d DIFF: https://github.com/llvm/llvm-project/commit/4bc9e603065b59976f3a16b7ecc6b5fb109f5f2d.diff

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

wyt updated this revision to Diff 450276. wyt marked an inline comment as done. wyt added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131065/new/ https://reviews.llvm.org/D131065 Files: clang/include/clang/Analysis/F

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. It would be great to get this landed. Can someone pls take a look at it? It's quite independent from the remainder of the work and self-contained. maybe @tlively ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/ne

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. It would be great to get this landed. Can someone pls take a look at it? It's quite independent from the remainder of the work and self-contained. maybe @tlively ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/ne

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:64 CodeGenModule &CGM; uint32_t ResourceCounters[static_cast( hlsl::ResourceClass::NumClasses)] = {0}; Anastasia wrote: > This is not part of this change but any reason why it

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. I don't know much about fixit hints, would they be appropriate to display it below the line itself, e.g. test.cpp:24:17: note: expression evaluates to static_assert(c != c); '0' != '0' ~~^~~~ Or would it be even better to just inline th

[PATCH] D131258: [Sema] Merge variable template specializations

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Clang used to produce redefinition errors, see tests for examples. Repository: rG LLVM Github Monorepo h

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong added a comment. Thanks for the quick reply and the reference on the C standard! On the C++ side, Section C.1.8 specified that `int` bit-fields are signed: > Change: Bit-fields of type plain int are signed. > Rationale: Leaving the choice of signedness to implementations could lead to

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added a comment. In D131255#3702286 , @ShawnZhong wrote: > Thanks for the quick reply and the reference on the C standard! > > On the C++ side, Section C.1.8 specified that `int` bit-fields are signed: > >> Change: Bit-fields of type plain

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added a comment. In D130894#3702233 , @tbaeder wrote: > I don't know much about fixit hints, would they be appropriate to display it > below the line itself, e.g. > > test.cpp:24:17: note: expression evaluates to > static_assert(c != c)

[PATCH] D130894: [clang] Print more information about failed static assertions

xbolva00 added a comment. Any tests with macros? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D129231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 updated this revision to Diff 450298. barannikov88 added a comment. Assert that Swift ABI info is initialized before accessing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: cla

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 updated this revision to Diff 450294. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/SwiftCallin

[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk created this revision. JackAKirk added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. JackAKirk requested review of this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. As stated here (h

[PATCH] D130894: [clang] Print more information about failed static assertions

cjdb added a comment. Thank you so much for working on this! It's been on my todo list for a while and just haven't gotten around to it. In D130894#3702166 , @aaron.ballman wrote: > In D130894#3701749 , @tbaede

[PATCH] D131143: [Clang] Interaction of FP pragmas and function template instantiation

rjmccall added a comment. I completely agree with Eli. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131143/new/ https://reviews.llvm.org/D131143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D131143: [Clang] Interaction of FP pragmas and function template instantiation

sepavloff added a comment. In D131143#3700373 , @efriedma wrote: >> In the case is explicit instantiation there is apparent connection >> between a point in source code and instantiated function. It can >> support interaction of pragmas that act in that p

[PATCH] D130907: [Clang] Use pragma FENV_ROUND to reset rounding mode settings.

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:398 +// If dynamic rounding mode is specified in absence of FENV_ACCESS, treat it +// as setting default rounding mode. +FpPragmaStack.CurrentValue.clearConstRoundingModeOverride();

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz created this revision. beanz added reviewers: bogner, aaron.ballman, python3kgae, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. In HLSL buffer types support array subscripting syntax for loa

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D129231 ___

[PATCH] D131265: Fixed sm version for .and bmma operator.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Good catch. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131265/new/ https://reviews.llvm.org/D131265

[PATCH] D131076: [clang][modules] Don't depend on sharing FileManager during module build

benlangmuir updated this revision to Diff 450313. benlangmuir added a comment. Herald added a subscriber: ormris. Attempt to fix test failure seen on Windows. It revealed two bugs - Avoid reusing the FileManager at the top-level in clang-scan-deps to make the test behave as expected - Make the F

[PATCH] D126291: [flang][Driver] Update link job on windows

amyk added a comment. Hi, I have come across a failure involving `flang/test/Driver/linker-flags.f90` that occurs when the default linker is lld. I have opened an external issue for it here: https://github.com/llvm/llvm-project/issues/56955 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: pengfei, guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clan

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

ddcc added a comment. I missed line 19, yeah that makes sense. @iana is that ok with you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131213/new/ https://reviews.llvm.org/D131213 ___ cfe-commits mailin

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

iana added a comment. In D131213#3702699 , @ddcc wrote: > I missed line 19, yeah that makes sense. @iana is that ok with you? Ah, I didn't see that either. Can we just lose the `defined` on line 26 then? It's redundant and little confusing. Repository

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

aaron.ballman added a comment. In D131213#3702707 , @iana wrote: > In D131213#3702699 , @ddcc wrote: > >> I missed line 19, yeah that makes sense. @iana is that ok with you? > > Ah, I didn't see that either. Can w

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; Better to make it a property of MappedVars. Also, are there any issues if just restore it

[PATCH] D131273: [clang] Fix redirection behaviour for cached FileEntryRef

benlangmuir created this revision. benlangmuir added a reviewer: bnbarham. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 6a79e2ff1989b

[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk added a comment. In D131265#3702594 , @tra wrote: > Good catch. LGTM. Thanks. If you could land it for me that would be much appreciated. I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

ldionne created this revision. ldionne added a reviewer: leonardchan. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Newer SDKs don't even provide libstdc++ headers, so it's effectively never va

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

ldionne added a comment. @leonardchan Does this fix the Fuchsia issues you were seeing? I think I understand what went wrong and I think this version of the patch should address the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

dblaikie added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

tra added a comment. This change breaks `clang++ --cuda-device-only` compilation. Clang does not create any output in this case. Reverting the change fixes the problem. Reproducible with: echo '__global__ void k(){}' | bin/clang++ --offload-arch=sm_70 -x cuda - --cuda-device-only -v -c -

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; ABataev wrote: > Better to make it a property of MappedVars. Also, are there any iss

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 added a comment. In D128441#3702800 , @tra wrote: > This change breaks `clang++ --cuda-device-only` compilation. Clang does not > create any output in this case. Reverting the change fixes the problem. > > Reproducible with: > > echo '__global

[PATCH] D131268: [HLSL] Generate buffer subscript operators

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:220 + +// Const subscript operators return copies of elements, non-const return a +// reference so that they are assignable. If we reuse this function for StructuredB

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

vitalybuka added a subscriber: smd. vitalybuka added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->siz

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450338. ckissane added a comment. - cleanup some compression nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serializati

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D131277: clang: fix typo availbility

sloorush created this revision. Herald added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. sloorush requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #56787. Fixing the spelling of availability. I am

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik planned changes to this revision. philnik added a comment. This is useless until we have some `no_unique_address` in clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 _

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

abrahamcd added a comment. In D131084#3697211 , @vaibhav.y wrote: > Submitting for review: > > Some notes: > > There are a couple of ways I think we can acheive this, per the spec: > > 1. The reportingDescriptor (rule) objects can be given a default > co

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 created this revision. jhuber6 added a reviewer: tra. Herald added subscribers: mattd, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When performing device only compilation, the

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

tra added a comment. In D128441#3702816 , @jhuber6 wrote: > Is it spitting it out as `foo123.cubin` instead? That's the output name it passes to `ptxas`, but it's treated as a temporary file and is removed at the end, so the user gets nothing. Reposit

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added a comment. In D130372#3699036 , @martong wrote: > LGTM! Nice work! Thank you. I prefer to load this along with the motivation part D131006 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450343. ckissane added a comment. - remove OptionalCompressionKind noneIfUnsupported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clang

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1474-1475 + if (!CompressionScheme) { +Error("compression class " + + (CompressionScheme->Name + " is not available").str()); return nullptr; leon

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:220 + +// Const subscript operators return copies of elements, non-const return a +// reference so that they are assignable. python3kgae wrote: > If we reuse this function

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450345. ckissane added a comment. - format error string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serialization.cpp c

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel created this revision. ymandel added reviewers: samestep, xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch evolves the cache of `Co

[clang] 3e0e556 - [CUDA] Fixed sm version constrain for __bmma_m8n8k128_mma_and_popc_b1.

Author: Jack Kirk Date: 2022-08-05T12:14:06-07:00 New Revision: 3e0e5568a6a8c744d26f79a1e55360fe2655867c URL: https://github.com/llvm/llvm-project/commit/3e0e5568a6a8c744d26f79a1e55360fe2655867c DIFF: https://github.com/llvm/llvm-project/commit/3e0e5568a6a8c744d26f79a1e55360fe2655867c.diff LOG

[PATCH] D131265: Fixed sm version for .and bmma operator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e0e5568a6a8: [CUDA] Fixed sm version constrain for __bmma_m8n8k128_mma_and_popc_b1. (authored by JackAKirk, committed by tra). Changed prior to com

[PATCH] D131265: Fixed sm version for .and bmma operator.

tra added a comment. Looks like the tests needed to be updated (and I've found one bug which explains how we've missed this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131265/new/ https://reviews.llvm.org/D131265 _

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

smd added a comment. Hi folks, I've been working on support hwasan for risc-v and I believe I've found an issue with the existing lit tests this commit causes. Tests stack-{oob,uar,uas}.c check for correct backtrace being printed. From the code and comments the idea is to not to print any hwasa

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added a comment. In D103562#3702962 , @smd wrote: > Hi folks, > > I've been working on support hwasan for risc-v and I believe I've found an > issue with the existing lit tests this commit causes. > Tests stack-{oob,uar,uas}.c check for correct ba

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > vitalybuka wrote: > > maybe we should pop everything up to "pc" t

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel updated this revision to Diff 450353. ymandel added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131280/new/ https://reviews.llvm.org/D131280 Files: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h

[clang] d038bb1 - [clang] Fix redirection behaviour for cached FileEntryRef

Author: Ben Langmuir Date: 2022-08-05T12:23:38-07:00 New Revision: d038bb196c51dcf80cbe771f4229b4e227c6c5b6 URL: https://github.com/llvm/llvm-project/commit/d038bb196c51dcf80cbe771f4229b4e227c6c5b6 DIFF: https://github.com/llvm/llvm-project/commit/d038bb196c51dcf80cbe771f4229b4e227c6c5b6.diff

[PATCH] D131273: [clang] Fix redirection behaviour for cached FileEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGd038bb196c51: [clang] Fix redirection behaviour for cached FileEntryRef (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131273/new/

[PATCH] D131076: [clang][modules] Don't depend on sharing FileManager during module build

benlangmuir updated this revision to Diff 450356. benlangmuir added a comment. Split out the FileManager change into https://reviews.llvm.org/D131273 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131076/new/ https://reviews.llvm.org/D131076 Files: clang/include/clang/Driver/Options.t

[clang] fb89cc0 - [clang][modules] Don't depend on sharing FileManager during module build

Author: Ben Langmuir Date: 2022-08-05T12:24:40-07:00 New Revision: fb89cc0ddbd9a588ee15148451e7d0bcbc1ef411 URL: https://github.com/llvm/llvm-project/commit/fb89cc0ddbd9a588ee15148451e7d0bcbc1ef411 DIFF: https://github.com/llvm/llvm-project/commit/fb89cc0ddbd9a588ee15148451e7d0bcbc1ef411.diff

[PATCH] D131076: [clang][modules] Don't depend on sharing FileManager during module build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb89cc0ddbd9: [clang][modules] Don't depend on sharing FileManager during module build (authored by benlangmuir). Repository: rG LLVM Github Monor

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. Any progress? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https://reviews.llvm.org/D121593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice to have some tests for this, but since it's just forwarding arguments to `FileManager` I'm also fine with this as is. Repository: rG LLVM Github Monorepo CHA

[clang-tools-extra] 13bc713 - fixes clang-tidy/checks/list.rst: a line was accidentally removed in 95a92995d45fc6fada43ecd91eba3e7aea90487a

Author: Rashmi Mudduluru Date: 2022-08-05T12:36:03-07:00 New Revision: 13bc71310920dced155328e25aa382dc2bb1ef9f URL: https://github.com/llvm/llvm-project/commit/13bc71310920dced155328e25aa382dc2bb1ef9f DIFF: https://github.com/llvm/llvm-project/commit/13bc71310920dced155328e25aa382dc2bb1ef9f.di

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 450358. JonasToth added a comment. - add test with typedef - [docs] improve documentation for misc-const-correctness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793

  1   2   >